Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows 1255 encoding doesn't work well. possibly should be replaced by UTF-8 #3

Open
Ijmir opened this issue Feb 18, 2015 · 4 comments

Comments

@Ijmir
Copy link

Ijmir commented Feb 18, 2015

No description provided.

@almog almog closed this as completed Jun 13, 2015
@almog
Copy link
Owner

almog commented Jun 13, 2015

Could you elaborate on how it doesn't work? For all I can see, the content is well encoded.
Perhaps your RSS client do not support Windows 1255?
Either way, I do not mind switching it to UTF-8, feel free to send a pull request.

@almog almog reopened this Jun 13, 2015
@Ijmir
Copy link
Author

Ijmir commented Jun 17, 2015

I had problems in seeing hebrew in chrome in the feed. when I switched to UTF-8 I could see the content. on the other hand It could break on other platforms/configurations so I'm not sure the UTF-8 is the best solution - it just worked for me.

@kostyay
Copy link

kostyay commented Jul 7, 2015

utf-8 worked for me too in chrome

@almog
Copy link
Owner

almog commented Jul 7, 2015

@Ijmir @kostyay Great (and sorry for the delayed response), would you mind sending a pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants