From eafaef368345515e15ac2c14a4c17d68a146032d Mon Sep 17 00:00:00 2001 From: ChristineWuerth Date: Thu, 26 Sep 2024 12:15:17 +0100 Subject: [PATCH 1/3] Added issues log to content list and breacrumbs pages --- docs/components/breadcrumbs.md | 16 ++++++++++++++-- docs/components/content-list.md | 21 +++++++++++++++++++-- 2 files changed, 33 insertions(+), 4 deletions(-) diff --git a/docs/components/breadcrumbs.md b/docs/components/breadcrumbs.md index f92f890..b6a9c9e 100644 --- a/docs/components/breadcrumbs.md +++ b/docs/components/breadcrumbs.md @@ -167,8 +167,20 @@ issues: # To add additional issues duplicate the the fields below (adhering to the formating) but increase the count by one integer. 0: # Both title and link are REQUIRED in order to display this information on the page. - title: #Delete this comment before entering the title of the GitHub issue. - link: #Delete this comment before entering the URL of the corresponding GitHub issue. + title: Breadcrumbs don't show the page you are on. Is that a problem? + link: https://github.com/alphagov/govuk_publishing_components/issues/4257 + 1: + # Both title and link are REQUIRED in order to display this information on the page. + title: We can’t give specialist document finders a parent taxonomy topic, because there’s no route back. + link: https://github.com/alphagov/govuk_publishing_components/issues/4258 + 2: + # Both title and link are REQUIRED in order to display this information on the page. + title: Parts or all of breadcrumbs missing on some pages + link: https://github.com/alphagov/govuk_publishing_components/issues/4259 + 3: + # Both title and link are REQUIRED in order to display this information on the page. + title: When content is tagged to multiple topics the breadcrumb component selects one in alphabetical order. Are there alternatives that would work better for users? + link: https://github.com/alphagov/govuk_publishing_components/issues/4260 # Kati's additional suggestions diff --git a/docs/components/content-list.md b/docs/components/content-list.md index 3b5c8b1..07974e8 100644 --- a/docs/components/content-list.md +++ b/docs/components/content-list.md @@ -217,6 +217,23 @@ issues: # To add additional issues duplicate the the fields below (adhering to the formating) but increase the count by one integer. 0: # Both title and link are REQUIRED in order to display this information on the page. - title: #Delete this comment before entering the title of the GitHub issue. - link: #Delete this comment before entering the URL of the corresponding GitHub issue. + title: There is no visual differentiation between navigating within a page and across pages. + link: https://github.com/alphagov/govuk_publishing_components/issues/4261 + 1: + # Both title and link are REQUIRED in order to display this information on the page. + title: The components gives very low visibility of which page in a list is active. + link: https://github.com/alphagov/govuk_publishing_components/issues/4262 + 2: + # Both title and link are REQUIRED in order to display this information on the page. + title: The contents list is too low in the type hierarchy. + link: https://github.com/alphagov/govuk_publishing_components/issues/4263 + 3: + # Both title and link are REQUIRED in order to display this information on the page. + title: The m-dash is unusual as a visual marker on gov.uk. + link: https://github.com/alphagov/govuk_publishing_components/issues/4264 + 4: + # Both title and link are REQUIRED in order to display this information on the page. + title: Inconsistent position in source order + link: https://github.com/alphagov/govuk_publishing_components/issues/4265 + --- \ No newline at end of file From bb84505db287742954208ca9dedd0640539f72b6 Mon Sep 17 00:00:00 2001 From: ChristineWuerth Date: Thu, 26 Sep 2024 13:16:06 +0100 Subject: [PATCH 2/3] added issues on print link --- docs/components/print-link.md | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/docs/components/print-link.md b/docs/components/print-link.md index ca44a70..16d977d 100644 --- a/docs/components/print-link.md +++ b/docs/components/print-link.md @@ -130,6 +130,10 @@ issues: # To add additional issues duplicate the the fields below (adhering to the formating) but increase the count by one integer. 0: # Both title and link are REQUIRED in order to display this information on the page. - title: #Delete this comment before entering the title of the GitHub issue. - link: #Delete this comment before entering the URL of the corresponding GitHub issue. + title: Not all pages display the print link. + link: https://github.com/alphagov/govuk_publishing_components/issues/4266 + 1: + # Both title and link are REQUIRED in order to display this information on the page. + title: Where print link is repeated at the top and bottom of a page the lock-up is currently inconsistent. + link: https://github.com/alphagov/govuk_publishing_components/issues/4267 --- \ No newline at end of file From 7943d95a7595bfcc21b573e238cce4689a0829aa Mon Sep 17 00:00:00 2001 From: ChristineWuerth Date: Thu, 26 Sep 2024 13:58:49 +0100 Subject: [PATCH 3/3] Added one more issue to print link --- docs/components/print-link.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/components/print-link.md b/docs/components/print-link.md index 16d977d..9c5ae51 100644 --- a/docs/components/print-link.md +++ b/docs/components/print-link.md @@ -136,4 +136,8 @@ issues: # Both title and link are REQUIRED in order to display this information on the page. title: Where print link is repeated at the top and bottom of a page the lock-up is currently inconsistent. link: https://github.com/alphagov/govuk_publishing_components/issues/4267 + 2: + # Both title and link are REQUIRED in order to display this information on the page. + title: In dark mode the icon is not visible. + link: https://github.com/alphagov/govuk_publishing_components/issues/4268 --- \ No newline at end of file