From 5c0c8b5d732146ed40d2c857e583918c7e2c9671 Mon Sep 17 00:00:00 2001 From: Ryota Kobayashi <45661924+naipaka@users.noreply.github.com> Date: Wed, 31 Jul 2024 15:02:28 +0900 Subject: [PATCH] fix: Fixed the potential cast error in `avoid_single_child` (#41) * fix: Fixed the potential cast error in `avoid_single_child` * chore: Add ListView test with non ListLiteral --- packages/altive_lints/lib/src/lints/avoid_single_child.dart | 4 +++- .../altive_lints/lint_test/lints/avoid_single_child.dart | 6 ++++++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/packages/altive_lints/lib/src/lints/avoid_single_child.dart b/packages/altive_lints/lib/src/lints/avoid_single_child.dart index 649f555..4ade29a 100644 --- a/packages/altive_lints/lib/src/lints/avoid_single_child.dart +++ b/packages/altive_lints/lib/src/lints/avoid_single_child.dart @@ -65,7 +65,9 @@ class AvoidSingleChild extends DartLintRule { ); final childrenList = childrenArg is NamedExpression - ? childrenArg.expression as ListLiteral + ? childrenArg.expression is ListLiteral + ? childrenArg.expression as ListLiteral + : null : null; if (childrenList != null && childrenList.elements.length == 1) { diff --git a/packages/altive_lints/lint_test/lints/avoid_single_child.dart b/packages/altive_lints/lint_test/lints/avoid_single_child.dart index dcaa7d5..9edcd01 100644 --- a/packages/altive_lints/lint_test/lints/avoid_single_child.dart +++ b/packages/altive_lints/lint_test/lints/avoid_single_child.dart @@ -44,6 +44,12 @@ class MyWidget extends StatelessWidget { Text('World'), ], ), + ListView( + children: List.generate( + 10, + (index) => Text('Hello $index'), + ), + ), ], ); }