Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify the number of tests run by IonHashTests matches expectations #5

Open
pbcornell opened this issue Jul 24, 2019 · 1 comment
Open

Comments

@pbcornell
Copy link

In particular, since each test is defined as a property of a suite object, if two distinct Ion test values from ion_hash_tests.ion result in the same test name, the last one wins by overwriting an earlier test (of the same name). We should verify that this is not occurring and thereby confirm that we have the test coverage we think we have.

@pbcornell pbcornell added this to the M1 milestone Jul 24, 2019
@pbcornell pbcornell modified the milestones: M1, M2 Mar 17, 2020
@pbcornell
Copy link
Author

The ion_hash_tests.ion file defines 166 identity expectations and 5 md5 expectations, and all the digesters defined in IonHashTests.ts (BinaryReader, BinaryWriter, ReaderSkip, TextReader, TextWriter) are performing 157 identity assertions and 5 md5 assertions. The 9 missing identity assertions are:

  • redundant/duplicate tests:
    null.null // redundant with null
    1234.5 // duplicate test
    2017-01-01T00:00:00+00:00 // redundant with 2017-01-01T00:00:00Z
  • skipped tests:
    $0
    {$0:1}
    $0::{}
  • -0 issues:
    -0
    0d-0
    -0d-0

There's nothing particularly unexpected here, which is encouraging. Removing from M2, but keeping open as there's some cleanup to be done at some point (specifically $0 support and addressing the edge cases around -0).

@pbcornell pbcornell removed this from the M2 milestone Mar 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant