From 4deaca769e11289a309fd5ca4e4918ba19ac59b1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=E5=94=AF=E7=84=B6?= Date: Thu, 27 Jan 2022 16:31:02 +0800 Subject: [PATCH] chore: add prettier & lint-staged (#7) * chore: add prettier & lint-staged the package was using eslint to enforce a code style(@mysticatea/eslint-config) while it's no longer maintained. It just added a prettier config to be close to the eslint config * fix: ignore .eslintcache * chore: do not run prettier on md files for less changes * chore: fix linting errors refs: https://github.com/prettier/prettier/issues/12137 * chore: prettier lib/* tests/lib/* * chore: add eol --- .eslintrc.js | 11 +- .gitignore | 1 + .husky/.gitignore | 1 + .husky/pre-commit | 4 + .prettierrc | 16 ++ lib/index.js | 2 +- lib/rules/callback-return.js | 3 +- lib/rules/exports-style.js | 3 +- lib/rules/file-extension-in-import.js | 6 +- lib/rules/global-require.js | 3 +- lib/rules/handle-callback-err.js | 3 +- lib/rules/no-callback-literal.js | 3 +- lib/rules/no-deprecated-api.js | 18 +- lib/rules/no-exports-assign.js | 3 +- lib/rules/no-extraneous-import.js | 3 +- lib/rules/no-extraneous-require.js | 3 +- lib/rules/no-hide-core-modules.js | 3 +- lib/rules/no-missing-import.js | 3 +- lib/rules/no-missing-require.js | 3 +- lib/rules/no-mixed-requires.js | 3 +- lib/rules/no-new-require.js | 3 +- lib/rules/no-path-concat.js | 3 +- lib/rules/no-process-env.js | 3 +- lib/rules/no-process-exit.js | 3 +- lib/rules/no-restricted-import.js | 3 +- lib/rules/no-restricted-require.js | 3 +- lib/rules/no-sync.js | 3 +- lib/rules/no-unpublished-bin.js | 3 +- lib/rules/no-unpublished-import.js | 3 +- lib/rules/no-unpublished-require.js | 3 +- lib/rules/no-unsupported-features.js | 6 +- .../no-unsupported-features/es-builtins.js | 3 +- .../no-unsupported-features/es-syntax.js | 3 +- .../no-unsupported-features/node-builtins.js | 4 +- lib/rules/prefer-global/buffer.js | 3 +- lib/rules/prefer-global/console.js | 3 +- lib/rules/prefer-global/process.js | 3 +- lib/rules/prefer-global/text-decoder.js | 3 +- lib/rules/prefer-global/text-encoder.js | 3 +- lib/rules/prefer-global/url-search-params.js | 3 +- lib/rules/prefer-global/url.js | 3 +- lib/rules/prefer-promises/dns.js | 3 +- lib/rules/prefer-promises/fs.js | 3 +- lib/rules/process-exit-as-throw.js | 3 +- lib/rules/shebang.js | 3 +- lib/util/check-publish.js | 2 +- lib/util/get-allow-modules.js | 4 +- lib/util/get-convert-path.js | 6 +- lib/util/get-npmignore.js | 3 +- lib/util/get-resolve-paths.js | 4 +- lib/util/get-try-extensions.js | 4 +- package.json | 185 +++++++------- tests/lib/configs/recommended.js | 47 ++-- tests/lib/rules/callback-return.js | 72 ++---- tests/lib/rules/file-extension-in-import.js | 1 - tests/lib/rules/global-require.js | 3 +- tests/lib/rules/handle-callback-err.js | 21 +- tests/lib/rules/no-deprecated-api.js | 3 +- tests/lib/rules/no-extraneous-import.js | 1 - tests/lib/rules/no-missing-import.js | 1 - tests/lib/rules/no-missing-require.js | 2 +- tests/lib/rules/no-mixed-requires.js | 21 +- tests/lib/rules/no-path-concat.js | 11 +- tests/lib/rules/no-restricted-import.js | 1 - tests/lib/rules/no-unpublished-import.js | 1 - tests/lib/rules/no-unpublished-require.js | 2 +- tests/lib/rules/no-unsupported-features.js | 18 +- .../no-unsupported-features/es-builtins.js | 12 +- .../no-unsupported-features/es-syntax.js | 7 +- .../no-unsupported-features/node-builtins.js | 225 ++++++------------ tests/lib/rules/prefer-global/buffer.js | 9 +- tests/lib/rules/prefer-global/text-decoder.js | 9 +- tests/lib/rules/prefer-global/text-encoder.js | 9 +- .../rules/prefer-global/url-search-params.js | 9 +- 74 files changed, 356 insertions(+), 511 deletions(-) create mode 100644 .husky/.gitignore create mode 100755 .husky/pre-commit create mode 100644 .prettierrc diff --git a/.eslintrc.js b/.eslintrc.js index c415b1f2..4e8623da 100644 --- a/.eslintrc.js +++ b/.eslintrc.js @@ -8,11 +8,16 @@ // to make the ci passing. module.exports = { reportUnusedDisableDirectives: true, - extends: ["eslint:recommended", "plugin:n/recommended", "plugin:eslint-plugin/recommended"], + extends: [ + "eslint:recommended", + "plugin:n/recommended", + "plugin:eslint-plugin/recommended", + "prettier", + ], env: { mocha: true, - } -}; + }, +} // const version = require("./package.json").version diff --git a/.gitignore b/.gitignore index f9187bd4..826f9654 100644 --- a/.gitignore +++ b/.gitignore @@ -3,3 +3,4 @@ /npm-debug.log /node_modules /test.js +.eslintcache diff --git a/.husky/.gitignore b/.husky/.gitignore new file mode 100644 index 00000000..31354ec1 --- /dev/null +++ b/.husky/.gitignore @@ -0,0 +1 @@ +_ diff --git a/.husky/pre-commit b/.husky/pre-commit new file mode 100755 index 00000000..36af2198 --- /dev/null +++ b/.husky/pre-commit @@ -0,0 +1,4 @@ +#!/bin/sh +. "$(dirname "$0")/_/husky.sh" + +npx lint-staged diff --git a/.prettierrc b/.prettierrc new file mode 100644 index 00000000..84504c86 --- /dev/null +++ b/.prettierrc @@ -0,0 +1,16 @@ +{ + "useTabs": false, + "semi": false, + "tabWidth": 4, + "arrowParens": "avoid", + "overrides": [ + { + "files": "*.md", + "options": { + "printWidth": 70, + "trailingComma": "none", + "proseWrap": "never" + } + } + ] +} diff --git a/lib/index.js b/lib/index.js index fb0ebce3..b391396f 100644 --- a/lib/index.js +++ b/lib/index.js @@ -46,7 +46,7 @@ module.exports = { "prefer-promises/dns": require("./rules/prefer-promises/dns"), "prefer-promises/fs": require("./rules/prefer-promises/fs"), "process-exit-as-throw": require("./rules/process-exit-as-throw"), - "shebang": require("./rules/shebang"), + shebang: require("./rules/shebang"), // Deprecated rules. "no-hide-core-modules": require("./rules/no-hide-core-modules"), diff --git a/lib/rules/callback-return.js b/lib/rules/callback-return.js index 3358a5ac..d0644913 100644 --- a/lib/rules/callback-return.js +++ b/lib/rules/callback-return.js @@ -11,8 +11,7 @@ module.exports = { description: "require `return` statements after callbacks", category: "Stylistic Issues", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/callback-return.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/callback-return.md", }, schema: [ { diff --git a/lib/rules/exports-style.js b/lib/rules/exports-style.js index a8b665bf..f3de2e9a 100644 --- a/lib/rules/exports-style.js +++ b/lib/rules/exports-style.js @@ -145,8 +145,7 @@ module.exports = { description: "enforce either `module.exports` or `exports`", category: "Stylistic Issues", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/exports-style.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/exports-style.md", }, type: "suggestion", fixable: null, diff --git a/lib/rules/file-extension-in-import.js b/lib/rules/file-extension-in-import.js index b7f20ff6..66eae1ba 100644 --- a/lib/rules/file-extension-in-import.js +++ b/lib/rules/file-extension-in-import.js @@ -9,7 +9,8 @@ const fs = require("fs") const getTryExtensions = require("../util/get-try-extensions") const visitImport = require("../util/visit-import") const packageNamePattern = /^(?:@[^/\\]+[/\\])?[^/\\]+$/u -const corePackageOverridePattern = /^(?:assert|async_hooks|buffer|child_process|cluster|console|constants|crypto|dgram|dns|domain|events|fs|http|http2|https|inspector|module|net|os|path|perf_hooks|process|punycode|querystring|readline|repl|stream|string_decoder|sys|timers|tls|trace_events|tty|url|util|v8|vm|worker_threads|zlib)[/\\]$/u +const corePackageOverridePattern = + /^(?:assert|async_hooks|buffer|child_process|cluster|console|constants|crypto|dgram|dns|domain|events|fs|http|http2|https|inspector|module|net|os|path|perf_hooks|process|punycode|querystring|readline|repl|stream|string_decoder|sys|timers|tls|trace_events|tty|url|util|v8|vm|worker_threads|zlib)[/\\]$/u /** * Get all file extensions of the files which have the same basename. @@ -38,8 +39,7 @@ module.exports = { "enforce the style of file extensions in `import` declarations", category: "Stylistic Issues", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/file-extension-in-import.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/file-extension-in-import.md", }, fixable: "code", messages: { diff --git a/lib/rules/global-require.js b/lib/rules/global-require.js index 33db144a..c4142f47 100644 --- a/lib/rules/global-require.js +++ b/lib/rules/global-require.js @@ -55,8 +55,7 @@ module.exports = { "require `require()` calls to be placed at top-level module scope", category: "Stylistic Issues", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/global-require.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/global-require.md", }, fixable: null, schema: [], diff --git a/lib/rules/handle-callback-err.js b/lib/rules/handle-callback-err.js index 22467f8e..17f1f6b0 100644 --- a/lib/rules/handle-callback-err.js +++ b/lib/rules/handle-callback-err.js @@ -11,8 +11,7 @@ module.exports = { description: "require error handling in callbacks", category: "Possible Errors", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/handle-callback-err.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/handle-callback-err.md", }, fixable: null, schema: [ diff --git a/lib/rules/no-callback-literal.js b/lib/rules/no-callback-literal.js index 7244a529..d143ee24 100644 --- a/lib/rules/no-callback-literal.js +++ b/lib/rules/no-callback-literal.js @@ -11,8 +11,7 @@ module.exports = { "ensure Node.js-style error-first callback pattern is followed", category: "Possible Errors", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-callback-literal.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-callback-literal.md", }, type: "problem", fixable: null, diff --git a/lib/rules/no-deprecated-api.js b/lib/rules/no-deprecated-api.js index 015f5545..3db6c14d 100644 --- a/lib/rules/no-deprecated-api.js +++ b/lib/rules/no-deprecated-api.js @@ -13,11 +13,11 @@ const modules = { _linklist: { [READ]: { since: "5.0.0", replacedBy: null }, }, - + _stream_wrap: { [READ]: { since: "12.0.0", replacedBy: null }, }, - + async_hooks: { currentId: { [READ]: { @@ -659,8 +659,8 @@ function toName(type, path) { return type === ReferenceTracker.CALL ? `${baseName}()` : type === ReferenceTracker.CONSTRUCT - ? `new ${baseName}()` - : baseName + ? `new ${baseName}()` + : baseName } /** @@ -685,8 +685,7 @@ module.exports = { description: "disallow deprecated APIs", category: "Best Practices", recommended: true, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-deprecated-api.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-deprecated-api.md", }, type: "problem", fixable: null, @@ -722,11 +721,8 @@ module.exports = { ], }, create(context) { - const { - ignoredModuleItems, - ignoredGlobalItems, - version, - } = parseOptions(context) + const { ignoredModuleItems, ignoredGlobalItems, version } = + parseOptions(context) /** * Reports a use of a deprecated API. diff --git a/lib/rules/no-exports-assign.js b/lib/rules/no-exports-assign.js index b73b2dfb..d533f16c 100644 --- a/lib/rules/no-exports-assign.js +++ b/lib/rules/no-exports-assign.js @@ -40,8 +40,7 @@ module.exports = { description: "disallow the assignment to `exports`", category: "Possible Errors", recommended: true, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-exports-assign.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-exports-assign.md", }, fixable: null, messages: { diff --git a/lib/rules/no-extraneous-import.js b/lib/rules/no-extraneous-import.js index cdcd6a77..939e9ac3 100644 --- a/lib/rules/no-extraneous-import.js +++ b/lib/rules/no-extraneous-import.js @@ -18,8 +18,7 @@ module.exports = { "disallow `import` declarations which import extraneous modules", category: "Possible Errors", recommended: true, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-extraneous-import.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-extraneous-import.md", }, type: "problem", fixable: null, diff --git a/lib/rules/no-extraneous-require.js b/lib/rules/no-extraneous-require.js index 4f350d1c..e0da613d 100644 --- a/lib/rules/no-extraneous-require.js +++ b/lib/rules/no-extraneous-require.js @@ -18,8 +18,7 @@ module.exports = { "disallow `require()` expressions which import extraneous modules", category: "Possible Errors", recommended: true, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-extraneous-require.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-extraneous-require.md", }, type: "problem", fixable: null, diff --git a/lib/rules/no-hide-core-modules.js b/lib/rules/no-hide-core-modules.js index 5dadd06c..833e1ad9 100644 --- a/lib/rules/no-hide-core-modules.js +++ b/lib/rules/no-hide-core-modules.js @@ -55,8 +55,7 @@ module.exports = { "disallow third-party modules which are hiding core modules", category: "Possible Errors", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-hide-core-modules.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-hide-core-modules.md", }, type: "problem", deprecated: true, diff --git a/lib/rules/no-missing-import.js b/lib/rules/no-missing-import.js index 1b44cc4f..9e4c391e 100644 --- a/lib/rules/no-missing-import.js +++ b/lib/rules/no-missing-import.js @@ -17,8 +17,7 @@ module.exports = { "disallow `import` declarations which import non-existence modules", category: "Possible Errors", recommended: true, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-missing-import.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-missing-import.md", }, type: "problem", fixable: null, diff --git a/lib/rules/no-missing-require.js b/lib/rules/no-missing-require.js index 3269e540..e2781bb4 100644 --- a/lib/rules/no-missing-require.js +++ b/lib/rules/no-missing-require.js @@ -17,8 +17,7 @@ module.exports = { "disallow `require()` expressions which import non-existence modules", category: "Possible Errors", recommended: true, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-missing-require.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-missing-require.md", }, type: "problem", fixable: null, diff --git a/lib/rules/no-mixed-requires.js b/lib/rules/no-mixed-requires.js index fe80fc3c..52238297 100644 --- a/lib/rules/no-mixed-requires.js +++ b/lib/rules/no-mixed-requires.js @@ -73,8 +73,7 @@ module.exports = { "disallow `require` calls to be mixed with regular variable declarations", category: "Stylistic Issues", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-mixed-requires.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-mixed-requires.md", }, fixable: null, schema: [ diff --git a/lib/rules/no-new-require.js b/lib/rules/no-new-require.js index e1cde2b3..fc34efc3 100644 --- a/lib/rules/no-new-require.js +++ b/lib/rules/no-new-require.js @@ -11,8 +11,7 @@ module.exports = { description: "disallow `new` operators with calls to `require`", category: "Possible Errors", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-new-require.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-new-require.md", }, fixable: null, schema: [], diff --git a/lib/rules/no-path-concat.js b/lib/rules/no-path-concat.js index 61f968fe..99810d77 100644 --- a/lib/rules/no-path-concat.js +++ b/lib/rules/no-path-concat.js @@ -164,8 +164,7 @@ module.exports = { "disallow string concatenation with `__dirname` and `__filename`", category: "Possible Errors", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-path-concat.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-path-concat.md", }, fixable: null, schema: [], diff --git a/lib/rules/no-process-env.js b/lib/rules/no-process-env.js index 4b174652..b4ed0611 100644 --- a/lib/rules/no-process-env.js +++ b/lib/rules/no-process-env.js @@ -15,8 +15,7 @@ module.exports = { description: "disallow the use of `process.env`", category: "Stylistic Issues", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-process-env.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-process-env.md", }, fixable: null, schema: [], diff --git a/lib/rules/no-process-exit.js b/lib/rules/no-process-exit.js index 331c41aa..bcde3c65 100644 --- a/lib/rules/no-process-exit.js +++ b/lib/rules/no-process-exit.js @@ -11,8 +11,7 @@ module.exports = { description: "disallow the use of `process.exit()`", category: "Possible Errors", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-process-exit.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-process-exit.md", }, fixable: null, schema: [], diff --git a/lib/rules/no-restricted-import.js b/lib/rules/no-restricted-import.js index 596c38b7..28fa7b3a 100644 --- a/lib/rules/no-restricted-import.js +++ b/lib/rules/no-restricted-import.js @@ -15,8 +15,7 @@ module.exports = { "disallow specified modules when loaded by `import` declarations", category: "Stylistic Issues", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-restricted-import.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-restricted-import.md", }, fixable: null, schema: [ diff --git a/lib/rules/no-restricted-require.js b/lib/rules/no-restricted-require.js index 0d29c355..43b73b81 100644 --- a/lib/rules/no-restricted-require.js +++ b/lib/rules/no-restricted-require.js @@ -15,8 +15,7 @@ module.exports = { description: "disallow specified modules when loaded by `require`", category: "Stylistic Issues", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-restricted-require.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-restricted-require.md", }, fixable: null, schema: [ diff --git a/lib/rules/no-sync.js b/lib/rules/no-sync.js index 9b2d93a6..5a9997c9 100644 --- a/lib/rules/no-sync.js +++ b/lib/rules/no-sync.js @@ -11,8 +11,7 @@ module.exports = { description: "disallow synchronous methods", category: "Stylistic Issues", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-sync.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-sync.md", }, fixable: null, schema: [ diff --git a/lib/rules/no-unpublished-bin.js b/lib/rules/no-unpublished-bin.js index 3e02e6d5..d14e4d7a 100644 --- a/lib/rules/no-unpublished-bin.js +++ b/lib/rules/no-unpublished-bin.js @@ -35,8 +35,7 @@ module.exports = { description: "disallow `bin` files that npm ignores", category: "Possible Errors", recommended: true, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-unpublished-bin.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-unpublished-bin.md", }, type: "problem", fixable: null, diff --git a/lib/rules/no-unpublished-import.js b/lib/rules/no-unpublished-import.js index a63ca4e2..0e6dc908 100644 --- a/lib/rules/no-unpublished-import.js +++ b/lib/rules/no-unpublished-import.js @@ -18,8 +18,7 @@ module.exports = { "disallow `import` declarations which import private modules", category: "Possible Errors", recommended: true, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-unpublished-import.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-unpublished-import.md", }, type: "problem", fixable: null, diff --git a/lib/rules/no-unpublished-require.js b/lib/rules/no-unpublished-require.js index 0f58535b..fd402c8e 100644 --- a/lib/rules/no-unpublished-require.js +++ b/lib/rules/no-unpublished-require.js @@ -18,8 +18,7 @@ module.exports = { "disallow `require()` expressions which import private modules", category: "Possible Errors", recommended: true, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-unpublished-require.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-unpublished-require.md", }, type: "problem", fixable: null, diff --git a/lib/rules/no-unsupported-features.js b/lib/rules/no-unsupported-features.js index 104af319..456636cf 100644 --- a/lib/rules/no-unsupported-features.js +++ b/lib/rules/no-unsupported-features.js @@ -34,7 +34,8 @@ const VERSION_SCHEMA = { const DEFAULT_VERSION = "4.0.0" const FUNC_TYPE = /^(?:Arrow)?Function(?:Declaration|Expression)$/u const CLASS_TYPE = /^Class(?:Declaration|Expression)$/u -const DESTRUCTURING_PARENT_TYPE = /^(?:Function(?:Declaration|Expression)|ArrowFunctionExpression|AssignmentExpression|VariableDeclarator)$/u +const DESTRUCTURING_PARENT_TYPE = + /^(?:Function(?:Declaration|Expression)|ArrowFunctionExpression|AssignmentExpression|VariableDeclarator)$/u const TOPLEVEL_SCOPE_TYPE = /^(?:global|function|module)$/u const BINARY_NUMBER = /^0[bB]/u const OCTAL_NUMBER = /^0[oO]/u @@ -1050,8 +1051,7 @@ module.exports = { "n/no-unsupported-features/es-syntax", "n/no-unsupported-features/es-builtins", ], - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-unsupported-features.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-unsupported-features.md", }, type: "problem", deprecated: true, diff --git a/lib/rules/no-unsupported-features/es-builtins.js b/lib/rules/no-unsupported-features/es-builtins.js index 6663302f..3dc7cf28 100644 --- a/lib/rules/no-unsupported-features/es-builtins.js +++ b/lib/rules/no-unsupported-features/es-builtins.js @@ -141,8 +141,7 @@ module.exports = { "disallow unsupported ECMAScript built-ins on the specified version", category: "Possible Errors", recommended: true, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-unsupported-features/es-builtins.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-unsupported-features/es-builtins.md", }, type: "problem", fixable: null, diff --git a/lib/rules/no-unsupported-features/es-syntax.js b/lib/rules/no-unsupported-features/es-syntax.js index 6a4e12ce..a7ca0841 100644 --- a/lib/rules/no-unsupported-features/es-syntax.js +++ b/lib/rules/no-unsupported-features/es-syntax.js @@ -520,8 +520,7 @@ module.exports = { "disallow unsupported ECMAScript syntax on the specified version", category: "Possible Errors", recommended: true, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-unsupported-features/es-syntax.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-unsupported-features/es-syntax.md", }, type: "problem", fixable: null, diff --git a/lib/rules/no-unsupported-features/node-builtins.js b/lib/rules/no-unsupported-features/node-builtins.js index c1a916a2..f63cdb8d 100644 --- a/lib/rules/no-unsupported-features/node-builtins.js +++ b/lib/rules/no-unsupported-features/node-builtins.js @@ -8,7 +8,6 @@ const { READ } = require("eslint-utils") const checkUnsupportedBuiltins = require("../../util/check-unsupported-builtins") const enumeratePropertyNames = require("../../util/enumerate-property-names") - const trackMap = { globals: { queueMicrotask: { @@ -374,8 +373,7 @@ module.exports = { "disallow unsupported Node.js built-in APIs on the specified version", category: "Possible Errors", recommended: true, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-unsupported-features/node-builtins.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/no-unsupported-features/node-builtins.md", }, type: "problem", fixable: null, diff --git a/lib/rules/prefer-global/buffer.js b/lib/rules/prefer-global/buffer.js index c55a915c..f45bd1c3 100644 --- a/lib/rules/prefer-global/buffer.js +++ b/lib/rules/prefer-global/buffer.js @@ -25,8 +25,7 @@ module.exports = { 'enforce either `Buffer` or `require("buffer").Buffer`', category: "Stylistic Issues", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/prefer-global/buffer.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/prefer-global/buffer.md", }, type: "suggestion", fixable: null, diff --git a/lib/rules/prefer-global/console.js b/lib/rules/prefer-global/console.js index 4792f708..a78b6bdf 100644 --- a/lib/rules/prefer-global/console.js +++ b/lib/rules/prefer-global/console.js @@ -22,8 +22,7 @@ module.exports = { description: 'enforce either `console` or `require("console")`', category: "Stylistic Issues", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/prefer-global/console.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/prefer-global/console.md", }, type: "suggestion", fixable: null, diff --git a/lib/rules/prefer-global/process.js b/lib/rules/prefer-global/process.js index 2f0e78b8..be512ce1 100644 --- a/lib/rules/prefer-global/process.js +++ b/lib/rules/prefer-global/process.js @@ -22,8 +22,7 @@ module.exports = { description: 'enforce either `process` or `require("process")`', category: "Stylistic Issues", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/prefer-global/process.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/prefer-global/process.md", }, type: "suggestion", fixable: null, diff --git a/lib/rules/prefer-global/text-decoder.js b/lib/rules/prefer-global/text-decoder.js index ba4a606f..a1f6942d 100644 --- a/lib/rules/prefer-global/text-decoder.js +++ b/lib/rules/prefer-global/text-decoder.js @@ -25,8 +25,7 @@ module.exports = { 'enforce either `TextDecoder` or `require("util").TextDecoder`', category: "Stylistic Issues", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/prefer-global/text-decoder.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/prefer-global/text-decoder.md", }, type: "suggestion", fixable: null, diff --git a/lib/rules/prefer-global/text-encoder.js b/lib/rules/prefer-global/text-encoder.js index c58f2fc5..48c2b6ba 100644 --- a/lib/rules/prefer-global/text-encoder.js +++ b/lib/rules/prefer-global/text-encoder.js @@ -25,8 +25,7 @@ module.exports = { 'enforce either `TextEncoder` or `require("util").TextEncoder`', category: "Stylistic Issues", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/prefer-global/text-encoder.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/prefer-global/text-encoder.md", }, type: "suggestion", fixable: null, diff --git a/lib/rules/prefer-global/url-search-params.js b/lib/rules/prefer-global/url-search-params.js index 7502c9e8..998d321e 100644 --- a/lib/rules/prefer-global/url-search-params.js +++ b/lib/rules/prefer-global/url-search-params.js @@ -25,8 +25,7 @@ module.exports = { 'enforce either `URLSearchParams` or `require("url").URLSearchParams`', category: "Stylistic Issues", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/prefer-global/url-search-params.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/prefer-global/url-search-params.md", }, type: "suggestion", fixable: null, diff --git a/lib/rules/prefer-global/url.js b/lib/rules/prefer-global/url.js index 4ba445bc..70c8a5f2 100644 --- a/lib/rules/prefer-global/url.js +++ b/lib/rules/prefer-global/url.js @@ -24,8 +24,7 @@ module.exports = { description: 'enforce either `URL` or `require("url").URL`', category: "Stylistic Issues", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/prefer-global/url.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/prefer-global/url.md", }, type: "suggestion", fixable: null, diff --git a/lib/rules/prefer-promises/dns.js b/lib/rules/prefer-promises/dns.js index 38c4ac62..752025a7 100644 --- a/lib/rules/prefer-promises/dns.js +++ b/lib/rules/prefer-promises/dns.js @@ -35,8 +35,7 @@ module.exports = { description: 'enforce `require("dns").promises`', category: "Stylistic Issues", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/prefer-promises/dns.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/prefer-promises/dns.md", }, fixable: null, messages: { diff --git a/lib/rules/prefer-promises/fs.js b/lib/rules/prefer-promises/fs.js index 9d664783..96c88011 100644 --- a/lib/rules/prefer-promises/fs.js +++ b/lib/rules/prefer-promises/fs.js @@ -41,8 +41,7 @@ module.exports = { description: 'enforce `require("fs").promises`', category: "Stylistic Issues", recommended: false, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/prefer-promises/fs.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/prefer-promises/fs.md", }, fixable: null, messages: { diff --git a/lib/rules/process-exit-as-throw.js b/lib/rules/process-exit-as-throw.js index 718c58cc..0d982083 100644 --- a/lib/rules/process-exit-as-throw.js +++ b/lib/rules/process-exit-as-throw.js @@ -150,8 +150,7 @@ module.exports = { "make `process.exit()` expressions the same code path as `throw`", category: "Possible Errors", recommended: true, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/process-exit-as-throw.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/process-exit-as-throw.md", }, type: "problem", fixable: null, diff --git a/lib/rules/shebang.js b/lib/rules/shebang.js index f65d5cc9..4e4439a3 100644 --- a/lib/rules/shebang.js +++ b/lib/rules/shebang.js @@ -72,8 +72,7 @@ module.exports = { description: "suggest correct usage of shebang", category: "Possible Errors", recommended: true, - url: - "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/shebang.md", + url: "https://github.com/weiran-zsd/eslint-plugin-node/blob/HEAD/docs/rules/shebang.md", }, type: "problem", fixable: "code", diff --git a/lib/util/check-publish.js b/lib/util/check-publish.js index 4deb588b..940f7c22 100644 --- a/lib/util/check-publish.js +++ b/lib/util/check-publish.js @@ -29,7 +29,7 @@ module.exports = function checkForPublish(context, filePath, targets) { const allowed = new Set(getAllowModules(context)) const convertPath = getConvertPath(context) const basedir = path.dirname(packageInfo.filePath) - + const toRelative = fullPath => { const retv = path.relative(basedir, fullPath).replace(/\\/gu, "/") return convertPath(retv) diff --git a/lib/util/get-allow-modules.js b/lib/util/get-allow-modules.js index e8dc98cc..54efcef4 100644 --- a/lib/util/get-allow-modules.js +++ b/lib/util/get-allow-modules.js @@ -32,7 +32,9 @@ function get(option) { module.exports = function getAllowModules(context) { return ( get(context.options && context.options[0]) || - get(context.settings && (context.settings.n || context.settings.node)) || + get( + context.settings && (context.settings.n || context.settings.node) + ) || DEFAULT_VALUE ) } diff --git a/lib/util/get-convert-path.js b/lib/util/get-convert-path.js index 0da1ad4d..5d8f7754 100644 --- a/lib/util/get-convert-path.js +++ b/lib/util/get-convert-path.js @@ -109,7 +109,7 @@ function parse(option) { for (const pattern of normalizeValue(option.convertPath)) { const include = toStringArray(pattern.include) const exclude = toStringArray(pattern.exclude) - const fromRegexp = new RegExp(String(pattern.replace[0])) + const fromRegexp = new RegExp(String(pattern.replace[0])) const toStr = String(pattern.replace[1]) converters.push({ @@ -134,7 +134,9 @@ function parse(option) { module.exports = function getConvertPath(context) { return ( parse(context.options && context.options[0]) || - parse(context.settings && (context.settings.n || context.settings.node)) || + parse( + context.settings && (context.settings.n || context.settings.node) + ) || identity ) } diff --git a/lib/util/get-npmignore.js b/lib/util/get-npmignore.js index fd06f07a..a8180750 100644 --- a/lib/util/get-npmignore.js +++ b/lib/util/get-npmignore.js @@ -14,7 +14,8 @@ const getPackageJson = require("./get-package-json") const cache = new Cache() const SLASH_AT_BEGIN_AND_END = /^!?\/+|^!|\/+$/gu const PARENT_RELATIVE_PATH = /^\.\./u -const NEVER_IGNORED = /^(?:readme\.[^.]*|(?:licen[cs]e|changes|changelog|history)(?:\.[^.]*)?)$/iu +const NEVER_IGNORED = + /^(?:readme\.[^.]*|(?:licen[cs]e|changes|changelog|history)(?:\.[^.]*)?)$/iu /** * Checks whether or not a given file name is a relative path to a ancestor diff --git a/lib/util/get-resolve-paths.js b/lib/util/get-resolve-paths.js index 6f285f8e..d848cc64 100644 --- a/lib/util/get-resolve-paths.js +++ b/lib/util/get-resolve-paths.js @@ -32,7 +32,9 @@ function get(option) { module.exports = function getResolvePaths(context, optionIndex = 0) { return ( get(context.options && context.options[optionIndex]) || - get(context.settings && (context.settings.n || context.settings.node)) || + get( + context.settings && (context.settings.n || context.settings.node) + ) || DEFAULT_VALUE ) } diff --git a/lib/util/get-try-extensions.js b/lib/util/get-try-extensions.js index 35ea5bcc..1b7aa50a 100644 --- a/lib/util/get-try-extensions.js +++ b/lib/util/get-try-extensions.js @@ -32,7 +32,9 @@ function get(option) { module.exports = function getTryExtensions(context, optionIndex = 0) { return ( get(context.options && context.options[optionIndex]) || - get(context.settings && (context.settings.n || context.settings.node)) || + get( + context.settings && (context.settings.n || context.settings.node) + ) || DEFAULT_VALUE ) } diff --git a/package.json b/package.json index a4169230..6b8e0255 100644 --- a/package.json +++ b/package.json @@ -1,91 +1,102 @@ { - "name": "eslint-plugin-n", - "version": "14.0.0", - "description": "Additional ESLint's rules for Node.js", - "engines": { - "node": ">=12.22.0" - }, - "main": "lib/index.js", - "files": [ - "lib" - ], - "peerDependencies": { - "eslint": ">=7.0.0" - }, - "dependencies": { - "eslint-plugin-es": "^4.1.0", - "eslint-utils": "^3.0.0", - "ignore": "^5.1.1", - "is-core-module": "^2.3.0", - "minimatch": "^3.0.4", - "resolve": "^1.10.1", - "semver": "^6.1.0" - }, - "devDependencies": { - "@mysticatea/eslint-plugin": "^13.0.0", - "codecov": "^3.3.0", - "eslint": "^8.3.0", - "eslint-plugin-eslint-plugin": "^4.0.1", - "eslint-plugin-n": "file:.", - "fast-glob": "^2.2.6", - "globals": "^11.12.0", - "mocha": "^6.1.4", - "nyc": "^14.0.0", - "opener": "^1.5.1", - "punycode": "^2.1.1", - "release-it": "^14.11.6", - "rimraf": "^2.6.3" - }, - "scripts": { - "build": "node scripts/update", - "clean": "rimraf .nyc_output coverage", - "codecov": "nyc report --reporter text-lcov | codecov --pipe --disable=gcov -t $CODECOV_TOKEN", - "coverage": "opener ./coverage/lcov-report/index.html", - "lint": "eslint lib scripts tests/lib .eslintrc.js", - "new": "node scripts/new-rule", - "pretest": "npm run -s lint", - "test": "nyc npm run -s test:_mocha", - "test:ci": "nyc npm run -s test:_mocha", - "test:_mocha": "_mocha \"tests/lib/**/*.js\" --reporter progress --timeout 4000", - "preversion": "npm test", - "version": "npm run -s build && eslint lib/rules --fix && git add .", - "postversion": "git push && git push --tags", - "watch": "npm run test:_mocha -- --watch --growl" - }, - "repository": { - "type": "git", - "url": "git+https://github.com/weiran-zsd/eslint-plugin-node.git" - }, - "keywords": [ - "eslint", - "eslintplugin", - "eslint-plugin", - "node", - "nodejs", - "ecmascript", - "shebang", - "file", - "path", - "import", - "require" - ], - "author": "Toru Nagashima", - "license": "MIT", - "bugs": { - "url": "https://github.com/weiran-zsd/eslint-plugin-node/issues" - }, - "homepage": "https://github.com/weiran-zsd/eslint-plugin-node#readme", - "funding": "https://github.com/sponsors/mysticatea", - "publishConfig": { - "access": "public", - "registry": "https://registry.npmjs.org/" - }, - "release-it": { - "github": { - "release": true + "name": "eslint-plugin-n", + "version": "14.0.0", + "description": "Additional ESLint's rules for Node.js", + "engines": { + "node": ">=12.22.0" }, - "npm": { - "skipChecks": true + "main": "lib/index.js", + "files": [ + "lib" + ], + "peerDependencies": { + "eslint": ">=7.0.0" + }, + "dependencies": { + "eslint-plugin-es": "^4.1.0", + "eslint-utils": "^3.0.0", + "ignore": "^5.1.1", + "is-core-module": "^2.3.0", + "minimatch": "^3.0.4", + "resolve": "^1.10.1", + "semver": "^6.1.0" + }, + "devDependencies": { + "@mysticatea/eslint-plugin": "^13.0.0", + "codecov": "^3.3.0", + "eslint": "^8.3.0", + "eslint-config-prettier": "^8.3.0", + "eslint-plugin-eslint-plugin": "^4.0.1", + "eslint-plugin-n": "file:.", + "fast-glob": "^2.2.6", + "globals": "^11.12.0", + "husky": "^7.0.4", + "lint-staged": "^12.3.1", + "mocha": "^6.1.4", + "nyc": "^14.0.0", + "opener": "^1.5.1", + "prettier": "^2.5.1", + "punycode": "^2.1.1", + "release-it": "^14.11.6", + "rimraf": "^2.6.3" + }, + "scripts": { + "build": "node scripts/update", + "clean": "rimraf .nyc_output coverage", + "codecov": "nyc report --reporter text-lcov | codecov --pipe --disable=gcov -t $CODECOV_TOKEN", + "coverage": "opener ./coverage/lcov-report/index.html", + "lint": "eslint lib scripts tests/lib .eslintrc.js", + "new": "node scripts/new-rule", + "pretest": "npm run -s lint", + "test": "nyc npm run -s test:_mocha", + "posttest": "npm run format", + "test:ci": "nyc npm run -s test:_mocha", + "test:_mocha": "_mocha \"tests/lib/**/*.js\" --reporter progress --timeout 4000", + "preversion": "npm test", + "version": "npm run -s build && eslint lib/rules --fix && git add .", + "postversion": "git push && git push --tags", + "watch": "npm run test:_mocha -- --watch --growl", + "format": "prettier --loglevel warn --write \"**/*.{js,css,md}\"", + "prepare": "husky install" + }, + "repository": { + "type": "git", + "url": "git+https://github.com/weiran-zsd/eslint-plugin-node.git" + }, + "keywords": [ + "eslint", + "eslintplugin", + "eslint-plugin", + "node", + "nodejs", + "ecmascript", + "shebang", + "file", + "path", + "import", + "require" + ], + "author": "Toru Nagashima", + "license": "MIT", + "bugs": { + "url": "https://github.com/weiran-zsd/eslint-plugin-node/issues" + }, + "homepage": "https://github.com/weiran-zsd/eslint-plugin-node#readme", + "funding": "https://github.com/sponsors/mysticatea", + "publishConfig": { + "access": "public", + "registry": "https://registry.npmjs.org/" + }, + "release-it": { + "github": { + "release": true + }, + "npm": { + "skipChecks": true + } + }, + "lint-staged": { + "*.js": "eslint --cache --fix", + "*.{json,js}": "prettier --write --ignore-path .eslintignore" } - } } diff --git a/tests/lib/configs/recommended.js b/tests/lib/configs/recommended.js index 62798e1b..2f9ac503 100644 --- a/tests/lib/configs/recommended.js +++ b/tests/lib/configs/recommended.js @@ -25,11 +25,9 @@ describe("node/recommended config", () => { }) it("*.js files should be a script.", async () => { - const report = await linter.lintText( - "import 'foo'", - {filePath: path.join(root, "test.js")} - - ) + const report = await linter.lintText("import 'foo'", { + filePath: path.join(root, "test.js"), + }) assert.deepStrictEqual(report[0].messages, [ { @@ -45,10 +43,9 @@ describe("node/recommended config", () => { }) it("*.cjs files should be a script.", async () => { - const report = await linter.lintText( - "import 'foo'", - {filePath: path.join(root, "test.cjs")} - ) + const report = await linter.lintText("import 'foo'", { + filePath: path.join(root, "test.cjs"), + }) assert.deepStrictEqual(report[0].messages, [ { @@ -64,11 +61,9 @@ describe("node/recommended config", () => { }) it("*.mjs files should be a module.", async () => { - const report = await linter.lintText( - "import 'foo'", - {filePath: path.join(root, "test.mjs")} - - ) + const report = await linter.lintText("import 'foo'", { + filePath: path.join(root, "test.mjs"), + }) assert.deepStrictEqual(report[0].messages, [ { @@ -104,11 +99,9 @@ describe("node/recommended config", () => { }) it("*.js files should be a module.", async () => { - const report = await linter.lintText( - "import 'foo'", - {filePath: path.join(root, "test.js")} - - ) + const report = await linter.lintText("import 'foo'", { + filePath: path.join(root, "test.js"), + }) assert.deepStrictEqual(report[0].messages, [ { @@ -125,11 +118,9 @@ describe("node/recommended config", () => { }) it("*.cjs files should be a script.", async () => { - const report = await linter.lintText( - "import 'foo'", - {filePath: path.join(root, "test.cjs")} - - ) + const report = await linter.lintText("import 'foo'", { + filePath: path.join(root, "test.cjs"), + }) assert.deepStrictEqual(report[0].messages, [ { @@ -145,11 +136,9 @@ describe("node/recommended config", () => { }) it("*.mjs files should be a module.", async () => { - const report = await linter.lintText( - "import 'foo'", - {filePath: path.join(root, "test.mjs")} - - ) + const report = await linter.lintText("import 'foo'", { + filePath: path.join(root, "test.mjs"), + }) assert.deepStrictEqual(report[0].messages, [ { diff --git a/tests/lib/rules/callback-return.js b/tests/lib/rules/callback-return.js index aa764d7d..515760c6 100644 --- a/tests/lib/rules/callback-return.js +++ b/tests/lib/rules/callback-return.js @@ -57,8 +57,7 @@ new RuleTester().run("callback-return", rule, { parserOptions: { ecmaVersion: 6 }, }, { - code: - "class x { horse() { if (err) { return callback(); } callback(); } } ", + code: "class x { horse() { if (err) { return callback(); } callback(); } } ", parserOptions: { ecmaVersion: 6 }, }, @@ -72,8 +71,7 @@ new RuleTester().run("callback-return", rule, { options: [["cb", "next"]], }, { - code: - "function a(err) { if (err) { return next(err) } else { callback(); } }", + code: "function a(err) { if (err) { return next(err) } else { callback(); } }", options: [["cb", "next"]], }, @@ -83,13 +81,11 @@ new RuleTester().run("callback-return", rule, { options: [["obj.method"]], }, { - code: - "function a(err) { if (err) { return obj.prop.method(err); } }", + code: "function a(err) { if (err) { return obj.prop.method(err); } }", options: [["obj.prop.method"]], }, { - code: - "function a(err) { if (err) { return obj.prop.method(err); } otherObj.prop.method() }", + code: "function a(err) { if (err) { return obj.prop.method(err); } otherObj.prop.method() }", options: [["obj.prop.method", "otherObj.prop.method"]], }, { @@ -101,23 +97,19 @@ new RuleTester().run("callback-return", rule, { options: [["obj.method"]], }, { - code: - "function a(err) { if (err) { //comment\nreturn obj.method(err); } }", + code: "function a(err) { if (err) { //comment\nreturn obj.method(err); } }", options: [["obj.method"]], }, { - code: - "function a(err) { if (err) { /*comment*/return obj.method(err); } }", + code: "function a(err) { if (err) { /*comment*/return obj.method(err); } }", options: [["obj.method"]], }, { - code: - "function a(err) { if (err) { return obj.method(err); //comment\n } }", + code: "function a(err) { if (err) { return obj.method(err); //comment\n } }", options: [["obj.method"]], }, { - code: - "function a(err) { if (err) { return obj.method(err); /*comment*/ } }", + code: "function a(err) { if (err) { return obj.method(err); /*comment*/ } }", options: [["obj.method"]], }, @@ -141,8 +133,7 @@ new RuleTester().run("callback-return", rule, { options: [["obj.method"]], }, { - code: - "function a(err) { if (err) { obj().method(err); } obj.method(); }", + code: "function a(err) { if (err) { obj().method(err); } obj.method(); }", options: [["obj.method"]], }, @@ -163,8 +154,7 @@ new RuleTester().run("callback-return", rule, { ], }, { - code: - "function a(callback) { if (typeof callback !== 'undefined') { callback(); } }", + code: "function a(callback) { if (typeof callback !== 'undefined') { callback(); } }", errors: [ { messageId: "missingReturn", @@ -175,8 +165,7 @@ new RuleTester().run("callback-return", rule, { ], }, { - code: - "function a(callback) { if (typeof callback !== 'undefined') callback(); }", + code: "function a(callback) { if (typeof callback !== 'undefined') callback(); }", errors: [ { messageId: "missingReturn", @@ -187,8 +176,7 @@ new RuleTester().run("callback-return", rule, { ], }, { - code: - "function a(callback) { if (err) { callback(); horse && horse(); } }", + code: "function a(callback) { if (err) { callback(); horse && horse(); } }", errors: [ { messageId: "missingReturn", @@ -234,8 +222,7 @@ new RuleTester().run("callback-return", rule, { ], }, { - code: - "var x = { x(err) { if (err) { callback && callback (err); } } }", + code: "var x = { x(err) { if (err) { callback && callback (err); } } }", parserOptions: { ecmaVersion: 6 }, errors: [ { @@ -269,8 +256,7 @@ new RuleTester().run("callback-return", rule, { ], }, { - code: - "function a(err) { if (err) { callback (err); horse(); return; } }", + code: "function a(err) { if (err) { callback (err); horse(); return; } }", errors: [ { messageId: "missingReturn", @@ -293,8 +279,7 @@ new RuleTester().run("callback-return", rule, { ], }, { - code: - "function a(err) { if (err) { callback (err); } else if (x) { callback(err); return; } }", + code: "function a(err) { if (err) { callback (err); } else if (x) { callback(err); return; } }", errors: [ { messageId: "missingReturn", @@ -305,8 +290,7 @@ new RuleTester().run("callback-return", rule, { ], }, { - code: - "function x(err) { if (err) { return callback(); }\nelse if (abc) {\ncallback(); }\nelse {\nreturn callback(); } }", + code: "function x(err) { if (err) { return callback(); }\nelse if (abc) {\ncallback(); }\nelse {\nreturn callback(); } }", errors: [ { messageId: "missingReturn", @@ -317,8 +301,7 @@ new RuleTester().run("callback-return", rule, { ], }, { - code: - "class x { horse() { if (err) { callback(); } callback(); } } ", + code: "class x { horse() { if (err) { callback(); } callback(); } } ", parserOptions: { ecmaVersion: 6 }, errors: [ { @@ -332,8 +315,7 @@ new RuleTester().run("callback-return", rule, { // generally good behavior which we must not allow to keep the rule simple { - code: - "function x(err) { if (err) { callback() } else { callback() } }", + code: "function x(err) { if (err) { callback() } else { callback() } }", errors: [ { messageId: "missingReturn", @@ -350,8 +332,7 @@ new RuleTester().run("callback-return", rule, { ], }, { - code: - "function x(err) { if (err) return callback(); else callback(); }", + code: "function x(err) { if (err) return callback(); else callback(); }", errors: [ { messageId: "missingReturn", @@ -459,8 +440,7 @@ new RuleTester().run("callback-return", rule, { ], }, { - code: - "function a(err) { if (err) { obj.prop.method(err); } otherObj.prop.method() }", + code: "function a(err) { if (err) { obj.prop.method(err); } otherObj.prop.method() }", options: [["obj.prop.method", "otherObj.prop.method"]], errors: [ { @@ -472,8 +452,7 @@ new RuleTester().run("callback-return", rule, { ], }, { - code: - "function a(err) { if (err) { /*comment*/obj.method(err); } }", + code: "function a(err) { if (err) { /*comment*/obj.method(err); } }", options: [["obj.method"]], errors: [ { @@ -485,8 +464,7 @@ new RuleTester().run("callback-return", rule, { ], }, { - code: - "function a(err) { if (err) { //comment\nobj.method(err); } }", + code: "function a(err) { if (err) { //comment\nobj.method(err); } }", options: [["obj.method"]], errors: [ { @@ -498,8 +476,7 @@ new RuleTester().run("callback-return", rule, { ], }, { - code: - "function a(err) { if (err) { obj.method(err); /*comment*/ } }", + code: "function a(err) { if (err) { obj.method(err); /*comment*/ } }", options: [["obj.method"]], errors: [ { @@ -511,8 +488,7 @@ new RuleTester().run("callback-return", rule, { ], }, { - code: - "function a(err) { if (err) { obj.method(err); //comment\n } }", + code: "function a(err) { if (err) { obj.method(err); //comment\n } }", options: [["obj.method"]], errors: [ { diff --git a/tests/lib/rules/file-extension-in-import.js b/tests/lib/rules/file-extension-in-import.js index 1428cd20..ca7f9c61 100644 --- a/tests/lib/rules/file-extension-in-import.js +++ b/tests/lib/rules/file-extension-in-import.js @@ -15,7 +15,6 @@ const DynamicImportSupported = (() => { })() if (!DynamicImportSupported) { - console.warn( "[%s] Skip tests for 'import()'", path.basename(__filename, ".js") diff --git a/tests/lib/rules/global-require.js b/tests/lib/rules/global-require.js index bc4cc3a3..9f99b64e 100644 --- a/tests/lib/rules/global-require.js +++ b/tests/lib/rules/global-require.js @@ -28,8 +28,7 @@ new RuleTester().run("global-require", rule, { invalid: [ // block statements { - code: - "if (process.env.NODE_ENV === 'DEVELOPMENT') {\n\trequire('debug');\n}", + code: "if (process.env.NODE_ENV === 'DEVELOPMENT') {\n\trequire('debug');\n}", errors: [ERROR], }, { diff --git a/tests/lib/rules/handle-callback-err.js b/tests/lib/rules/handle-callback-err.js index f1f1361f..4956c693 100644 --- a/tests/lib/rules/handle-callback-err.js +++ b/tests/lib/rules/handle-callback-err.js @@ -50,8 +50,7 @@ new RuleTester().run("handle-callback-err", rule, { parserOptions: { ecmaVersion: 6 }, }, { - code: - "var test = function(error) {if(! error){doSomethingHere();}};", + code: "var test = function(error) {if(! error){doSomethingHere();}};", options: ["error"], }, { @@ -87,8 +86,7 @@ new RuleTester().run("handle-callback-err", rule, { errors: [EXPECTED_DECL_ERROR], }, { - code: - "function test(err, callback) { foo(function(err, callback) {}); }", + code: "function test(err, callback) { foo(function(err, callback) {}); }", errors: [EXPECTED_DECL_ERROR, EXPECTED_FUNC_ERROR], }, { @@ -106,8 +104,7 @@ new RuleTester().run("handle-callback-err", rule, { errors: [EXPECTED_FUNC_ERROR], }, { - code: - "function test(err) {doSomethingHere(function(err){console.log(err);})}", + code: "function test(err) {doSomethingHere(function(err){console.log(err);})}", errors: [EXPECTED_DECL_ERROR], }, { @@ -116,23 +113,19 @@ new RuleTester().run("handle-callback-err", rule, { errors: [EXPECTED_DECL_ERROR], }, { - code: - "getData(function(err, data) {getMoreDataWith(data, function(err, moreData) {if (err) {}getEvenMoreDataWith(moreData, function(err, allOfTheThings) {if (err) {}});}); });", + code: "getData(function(err, data) {getMoreDataWith(data, function(err, moreData) {if (err) {}getEvenMoreDataWith(moreData, function(err, allOfTheThings) {if (err) {}});}); });", errors: [EXPECTED_FUNC_ERROR], }, { - code: - "getData(function(err, data) {getMoreDataWith(data, function(err, moreData) {getEvenMoreDataWith(moreData, function(err, allOfTheThings) {if (err) {}});}); });", + code: "getData(function(err, data) {getMoreDataWith(data, function(err, moreData) {getEvenMoreDataWith(moreData, function(err, allOfTheThings) {if (err) {}});}); });", errors: [EXPECTED_FUNC_ERROR, EXPECTED_FUNC_ERROR], }, { - code: - "function userHandler(err) {logThisAction(function(err) {if (err) { console.log(err); } })}", + code: "function userHandler(err) {logThisAction(function(err) {if (err) { console.log(err); } })}", errors: [EXPECTED_DECL_ERROR], }, { - code: - "function help() { function userHandler(err) {function tester(err) { err; process.nextTick(function() { err; }); } } }", + code: "function help() { function userHandler(err) {function tester(err) { err; process.nextTick(function() { err; }); } } }", errors: [EXPECTED_DECL_ERROR], }, { diff --git a/tests/lib/rules/no-deprecated-api.js b/tests/lib/rules/no-deprecated-api.js index ddb3b0ce..b37bde71 100644 --- a/tests/lib/rules/no-deprecated-api.js +++ b/tests/lib/rules/no-deprecated-api.js @@ -230,8 +230,7 @@ ruleTester.run("no-deprecated-api", rule, { ], }, { - code: - "var b; new ((b = require('buffer')).Buffer)(); new b.Buffer()", + code: "var b; new ((b = require('buffer')).Buffer)(); new b.Buffer()", options: [{ version: "6.0.0" }], env: { node: true }, errors: [ diff --git a/tests/lib/rules/no-extraneous-import.js b/tests/lib/rules/no-extraneous-import.js index 73b52a0f..b99b004e 100644 --- a/tests/lib/rules/no-extraneous-import.js +++ b/tests/lib/rules/no-extraneous-import.js @@ -15,7 +15,6 @@ const DynamicImportSupported = (() => { })() if (!DynamicImportSupported) { - console.warn( "[%s] Skip tests for 'import()'", path.basename(__filename, ".js") diff --git a/tests/lib/rules/no-missing-import.js b/tests/lib/rules/no-missing-import.js index 8bb2236e..d0c42f46 100644 --- a/tests/lib/rules/no-missing-import.js +++ b/tests/lib/rules/no-missing-import.js @@ -15,7 +15,6 @@ const DynamicImportSupported = (() => { })() if (!DynamicImportSupported) { - console.warn( "[%s] Skip tests for 'import()'", path.basename(__filename, ".js") diff --git a/tests/lib/rules/no-missing-require.js b/tests/lib/rules/no-missing-require.js index 10d22939..7ca480e8 100644 --- a/tests/lib/rules/no-missing-require.js +++ b/tests/lib/rules/no-missing-require.js @@ -163,7 +163,7 @@ ruleTester.run("no-missing-require", rule, { }, { filename: fixture("test.js"), - code: "require(`foo${bar}`);", + code: "require(`foo${bar}`);", env: { node: true, es6: true }, }, diff --git a/tests/lib/rules/no-mixed-requires.js b/tests/lib/rules/no-mixed-requires.js index 69a090d9..2ee264cc 100644 --- a/tests/lib/rules/no-mixed-requires.js +++ b/tests/lib/rules/no-mixed-requires.js @@ -11,8 +11,7 @@ new RuleTester().run("no-mixed-requires", rule, { valid: [ { code: "var a, b = 42, c = doStuff()", options: [false] }, { - code: - "var a = require(42), b = require(), c = require('y'), d = require(doStuff())", + code: "var a = require(42), b = require(), c = require('y'), d = require(doStuff())", options: [false], }, { @@ -20,8 +19,7 @@ new RuleTester().run("no-mixed-requires", rule, { options: [false], }, { - code: - "var exec = require('child_process').exec, foo = require('foo')", + code: "var exec = require('child_process').exec, foo = require('foo')", options: [false], }, { @@ -33,8 +31,7 @@ new RuleTester().run("no-mixed-requires", rule, { options: [false], }, { - code: - "var emitter = require('events').EventEmitter, fs = require('fs')", + code: "var emitter = require('events').EventEmitter, fs = require('fs')", options: [false], }, { @@ -55,8 +52,7 @@ new RuleTester().run("no-mixed-requires", rule, { }, { code: "var a;", options: [true] }, { - code: - "var async = require('async'), debug = require('diagnostics')('my-module')", + code: "var async = require('async'), debug = require('diagnostics')('my-module')", options: [{ allowCall: true }], }, ], @@ -82,8 +78,7 @@ new RuleTester().run("no-mixed-requires", rule, { ], }, { - code: - "var a = require(42), b = require(), c = require('y'), d = require(doStuff())", + code: "var a = require(42), b = require(), c = require('y'), d = require(doStuff())", options: [true], errors: [ { @@ -113,8 +108,7 @@ new RuleTester().run("no-mixed-requires", rule, { ], }, { - code: - "var exec = require('child_process').exec, foo = require('foo')", + code: "var exec = require('child_process').exec, foo = require('foo')", options: [true], errors: [ { @@ -154,8 +148,7 @@ new RuleTester().run("no-mixed-requires", rule, { ], }, { - code: - "var async = require('async'), debug = require('diagnostics').someFun('my-module')", + code: "var async = require('async'), debug = require('diagnostics').someFun('my-module')", options: [{ allowCall: true }], errors: [ { diff --git a/tests/lib/rules/no-path-concat.js b/tests/lib/rules/no-path-concat.js index 6e90a7df..b335c804 100644 --- a/tests/lib/rules/no-path-concat.js +++ b/tests/lib/rules/no-path-concat.js @@ -4,8 +4,6 @@ */ "use strict" - - const path = require("path") const RuleTester = require("eslint").RuleTester const rule = require("../../../lib/rules/no-path-concat") @@ -71,8 +69,7 @@ new RuleTester({ ], }, { - code: - 'var path = require("path"); var fullPath = `${__dirname}${path.sep}foo.js`;', + code: 'var path = require("path"); var fullPath = `${__dirname}${path.sep}foo.js`;', errors: [ { messageId: "usePathFunctions", @@ -81,8 +78,7 @@ new RuleTester({ ], }, { - code: - 'var path = require("path"); var fullPath = `${__filename}${path.sep}foo.js`;', + code: 'var path = require("path"); var fullPath = `${__filename}${path.sep}foo.js`;', errors: [ { messageId: "usePathFunctions", @@ -91,8 +87,7 @@ new RuleTester({ ], }, { - code: - 'var path = require("path"); var fullPath = __dirname + path.sep + `foo.js`;', + code: 'var path = require("path"); var fullPath = __dirname + path.sep + `foo.js`;', errors: [ { messageId: "usePathFunctions", diff --git a/tests/lib/rules/no-restricted-import.js b/tests/lib/rules/no-restricted-import.js index cecb56f0..a5e6de13 100644 --- a/tests/lib/rules/no-restricted-import.js +++ b/tests/lib/rules/no-restricted-import.js @@ -15,7 +15,6 @@ const DynamicImportSupported = (() => { })() if (!DynamicImportSupported) { - console.warn( "[%s] Skip tests for 'import()'", path.basename(__filename, ".js") diff --git a/tests/lib/rules/no-unpublished-import.js b/tests/lib/rules/no-unpublished-import.js index b1092d09..9aa83e11 100644 --- a/tests/lib/rules/no-unpublished-import.js +++ b/tests/lib/rules/no-unpublished-import.js @@ -15,7 +15,6 @@ const DynamicImportSupported = (() => { })() if (!DynamicImportSupported) { - console.warn( "[%s] Skip tests for 'import()'", path.basename(__filename, ".js") diff --git a/tests/lib/rules/no-unpublished-require.js b/tests/lib/rules/no-unpublished-require.js index 7a62bfc7..37ddfffb 100644 --- a/tests/lib/rules/no-unpublished-require.js +++ b/tests/lib/rules/no-unpublished-require.js @@ -207,7 +207,7 @@ ruleTester.run("no-unpublished-require", rule, { }, { filename: fixture("1/test.js"), - code: "require(`foo${bar}`);", + code: "require(`foo${bar}`);", env: { node: true, es6: true }, }, diff --git a/tests/lib/rules/no-unsupported-features.js b/tests/lib/rules/no-unsupported-features.js index 8042de56..10959462 100644 --- a/tests/lib/rules/no-unsupported-features.js +++ b/tests/lib/rules/no-unsupported-features.js @@ -78,12 +78,10 @@ function convertPattern(retv, pattern) { }) } else { // If this is not supported, add to a valid pattern with a "ignores" option. - [].push.apply( + ;[].push.apply( retv.valid, pattern.keys.map(key => ({ - code: `/*${ - pattern.name - }: ${versionText}, ignores: ["${key}"]*/ ${pattern.code}`, + code: `/*${pattern.name}: ${versionText}, ignores: ["${key}"]*/ ${pattern.code}`, env: { es6: true }, globals: { SharedArrayBuffer: false, Atomics: false }, options: [{ version, ignores: [key] }], @@ -193,7 +191,7 @@ ruleTester.run( { keys: ["templateStrings", "syntax"], name: "Template strings", - code: "`hello, ${world}!`; foo`tagged`;", + code: "`hello, ${world}!`; foo`tagged`;", errors: 2, supported: 4, }, @@ -242,8 +240,7 @@ ruleTester.run( { keys: ["new.target", "syntax"], name: "'new.target'", - code: - "function Foo() { new.target; } ;(function() { new.target; })()", + code: "function Foo() { new.target; } ;(function() { new.target; })()", errors: 2, supported: 5, }, @@ -296,8 +293,7 @@ ruleTester.run( { keys: ["blockScopedFunctions", "syntax"], name: "Block-scoped functions", - code: - "'use strict'; { function foo() {} } if (a) { function foo() {} }", + code: "'use strict'; { function foo() {} } if (a) { function foo() {} }", errors: 2, supported: 4, }, @@ -357,8 +353,7 @@ ruleTester.run( { keys: ["modules", "syntax"], name: "Import and export declarations", - code: - "import foo from 'foo'; export default 0; export {foo}; export * from 'foo';", + code: "import foo from 'foo'; export default 0; export {foo}; export * from 'foo';", errors: 4, supported: NaN, modules: true, @@ -404,7 +399,6 @@ ruleTester.run( keys: ["templateLiteralRevision", "syntax"], name: "Illegal escape sequences in taggled templates", code: [ - "tag`\\01\\1\\xg\\xAg\\u0\\u0g\\u00g\\u000g\\u{g\\u{0\\u{110000}${0}\\0`", ].join("\n"), errors: 1, diff --git a/tests/lib/rules/no-unsupported-features/es-builtins.js b/tests/lib/rules/no-unsupported-features/es-builtins.js index 5653ffdc..ce90fd83 100644 --- a/tests/lib/rules/no-unsupported-features/es-builtins.js +++ b/tests/lib/rules/no-unsupported-features/es-builtins.js @@ -1022,8 +1022,7 @@ ruleTester.run( options: [{ version: "0.11.9" }], }, { - code: - "(function(Object) { Object.getOwnPropertySymbols(a) }(b))", + code: "(function(Object) { Object.getOwnPropertySymbols(a) }(b))", options: [{ version: "0.11.9" }], }, { @@ -1528,8 +1527,7 @@ ruleTester.run( keyword: "Uint8ClampedArray", valid: [ { - code: - "(function(Uint8ClampedArray) { Uint8ClampedArray }(a))", + code: "(function(Uint8ClampedArray) { Uint8ClampedArray }(a))", options: [{ version: "0.9.9" }], }, { @@ -2158,8 +2156,7 @@ ruleTester.run( options: [{ version: "6.9.9" }], }, { - code: - "(function(Object) { Object.getOwnPropertyDescriptors(a) }(b))", + code: "(function(Object) { Object.getOwnPropertyDescriptors(a) }(b))", options: [{ version: "6.9.9" }], }, { @@ -2188,8 +2185,7 @@ ruleTester.run( keyword: "SharedArrayBuffer", valid: [ { - code: - "(function(SharedArrayBuffer) { SharedArrayBuffer }(a))", + code: "(function(SharedArrayBuffer) { SharedArrayBuffer }(a))", options: [{ version: "8.9.9" }], }, { diff --git a/tests/lib/rules/no-unsupported-features/es-syntax.js b/tests/lib/rules/no-unsupported-features/es-syntax.js index 0667a03e..d32f4a9d 100644 --- a/tests/lib/rules/no-unsupported-features/es-syntax.js +++ b/tests/lib/rules/no-unsupported-features/es-syntax.js @@ -172,13 +172,11 @@ ruleTester.run( options: [{ version: "4.0.0" }], }, { - code: - "'use strict'; function wrap() { if (a) { function f() {} } }", + code: "'use strict'; function wrap() { if (a) { function f() {} } }", options: [{ version: "4.0.0" }], }, { - code: - "function wrap() { 'use strict'; if (a) { function f() {} } }", + code: "function wrap() { 'use strict'; if (a) { function f() {} } }", options: [{ version: "4.0.0" }], }, { @@ -1479,7 +1477,6 @@ ruleTester.run( ], }, { - keyword: "templateLiterals", valid: [ { diff --git a/tests/lib/rules/no-unsupported-features/node-builtins.js b/tests/lib/rules/no-unsupported-features/node-builtins.js index 802a9afc..605c2c57 100644 --- a/tests/lib/rules/no-unsupported-features/node-builtins.js +++ b/tests/lib/rules/no-unsupported-features/node-builtins.js @@ -53,8 +53,7 @@ new RuleTester({ options: [{ version: "0.12.0" }], }, { - code: - "var assert = require('assert'); assert(); assert.strictEqual()", + code: "var assert = require('assert'); assert(); assert.strictEqual()", options: [{ version: "0.12.0" }], }, { @@ -62,23 +61,19 @@ new RuleTester({ options: [{ version: "4.0.0" }], }, { - code: - "var assert = require('assert'); assert.deepStrictEqual()", + code: "var assert = require('assert'); assert.deepStrictEqual()", options: [{ version: "4.0.0" }], }, { - code: - "var { deepStrictEqual } = require('assert'); deepStrictEqual()", + code: "var { deepStrictEqual } = require('assert'); deepStrictEqual()", options: [{ version: "4.0.0" }], }, { - code: - "import assert from 'assert'; assert.deepStrictEqual()", + code: "import assert from 'assert'; assert.deepStrictEqual()", options: [{ version: "4.0.0" }], }, { - code: - "import { deepStrictEqual } from 'assert'; deepStrictEqual()", + code: "import { deepStrictEqual } from 'assert'; deepStrictEqual()", options: [{ version: "4.0.0" }], }, { @@ -106,8 +101,7 @@ new RuleTester({ options: [{ version: "9.9.0" }], }, { - code: - "var {strict: assert} = require('assert'); assert.rejects()", + code: "var {strict: assert} = require('assert'); assert.rejects()", options: [{ version: "10.0.0" }], }, { @@ -120,8 +114,7 @@ new RuleTester({ ], }, { - code: - "var assert = require('assert'); assert.deepStrictEqual()", + code: "var assert = require('assert'); assert.deepStrictEqual()", options: [ { version: "3.9.9", @@ -130,8 +123,7 @@ new RuleTester({ ], }, { - code: - "var { deepStrictEqual } = require('assert'); deepStrictEqual()", + code: "var { deepStrictEqual } = require('assert'); deepStrictEqual()", options: [ { version: "3.9.9", @@ -140,8 +132,7 @@ new RuleTester({ ], }, { - code: - "import assert from 'assert'; assert.deepStrictEqual()", + code: "import assert from 'assert'; assert.deepStrictEqual()", options: [ { version: "3.9.9", @@ -150,8 +141,7 @@ new RuleTester({ ], }, { - code: - "import { deepStrictEqual } from 'assert'; deepStrictEqual()", + code: "import { deepStrictEqual } from 'assert'; deepStrictEqual()", options: [ { version: "3.9.9", @@ -203,8 +193,7 @@ new RuleTester({ options: [{ version: "9.8.9", ignores: ["assert.strict"] }], }, { - code: - "var {strict: assert} = require('assert'); assert.rejects()", + code: "var {strict: assert} = require('assert'); assert.rejects()", options: [ { version: "9.8.9", @@ -213,15 +202,13 @@ new RuleTester({ ], }, { - code: - "const { CallTracker } = require('assert'); new CallTracker();", + code: "const { CallTracker } = require('assert'); new CallTracker();", options: [ { version: "14.2.0", ignores: ["assert.CallTracker"] }, ], }, { - code: - "import { CallTracker } from 'assert'; new CallTracker();", + code: "import { CallTracker } from 'assert'; new CallTracker();", options: [ { version: "14.2.0", ignores: ["assert.CallTracker"] }, ], @@ -243,8 +230,7 @@ new RuleTester({ ], }, { - code: - "var assert = require('assert'); assert.deepStrictEqual()", + code: "var assert = require('assert'); assert.deepStrictEqual()", options: [{ version: "3.9.9" }], errors: [ { @@ -258,8 +244,7 @@ new RuleTester({ ], }, { - code: - "var { deepStrictEqual } = require('assert'); deepStrictEqual()", + code: "var { deepStrictEqual } = require('assert'); deepStrictEqual()", options: [{ version: "3.9.9" }], errors: [ { @@ -273,8 +258,7 @@ new RuleTester({ ], }, { - code: - "import assert from 'assert'; assert.deepStrictEqual()", + code: "import assert from 'assert'; assert.deepStrictEqual()", options: [{ version: "3.9.9" }], errors: [ { @@ -288,8 +272,7 @@ new RuleTester({ ], }, { - code: - "import { deepStrictEqual } from 'assert'; deepStrictEqual()", + code: "import { deepStrictEqual } from 'assert'; deepStrictEqual()", options: [{ version: "3.9.9" }], errors: [ { @@ -387,8 +370,7 @@ new RuleTester({ ], }, { - code: - "var {strict: assert} = require('assert'); assert.rejects()", + code: "var {strict: assert} = require('assert'); assert.rejects()", options: [{ version: "9.8.9" }], errors: [ { @@ -410,8 +392,7 @@ new RuleTester({ ], }, { - code: - "const { CallTracker } = require('assert'); new CallTracker();", + code: "const { CallTracker } = require('assert'); new CallTracker();", options: [{ version: "14.2.0" }], errors: [ { @@ -425,8 +406,7 @@ new RuleTester({ ], }, { - code: - "import { CallTracker } from 'assert'; new CallTracker();", + code: "import { CallTracker } from 'assert'; new CallTracker();", options: [{ version: "14.2.0" }], errors: [ { @@ -460,13 +440,11 @@ new RuleTester({ options: [{ version: "8.1.0" }], }, { - code: - "var hooks = require('async_hooks'); hooks.createHook()", + code: "var hooks = require('async_hooks'); hooks.createHook()", options: [{ version: "8.1.0" }], }, { - code: - "var { createHook } = require('async_hooks'); createHook()", + code: "var { createHook } = require('async_hooks'); createHook()", options: [{ version: "8.1.0" }], }, { @@ -474,28 +452,23 @@ new RuleTester({ options: [{ version: "8.1.0" }], }, { - code: - "import { createHook } from 'async_hooks'; createHook()", + code: "import { createHook } from 'async_hooks'; createHook()", options: [{ version: "8.1.0" }], }, { - code: - "const { AsyncLocalStorage } = require('async_hooks'); new AsyncLocalStorage();", + code: "const { AsyncLocalStorage } = require('async_hooks'); new AsyncLocalStorage();", options: [{ version: "13.10.0" }], }, { - code: - "import hooks from 'async_hooks'; new hooks.AsyncLocalStorage();", + code: "import hooks from 'async_hooks'; new hooks.AsyncLocalStorage();", options: [{ version: "13.10.0" }], }, { - code: - "const { AsyncLocalStorage } = require('async_hooks'); new AsyncLocalStorage();", + code: "const { AsyncLocalStorage } = require('async_hooks'); new AsyncLocalStorage();", options: [{ version: "12.17.0" }], }, { - code: - "import hooks from 'async_hooks'; new hooks.AsyncLocalStorage();", + code: "import hooks from 'async_hooks'; new hooks.AsyncLocalStorage();", options: [{ version: "12.17.0" }], }, @@ -527,8 +500,7 @@ new RuleTester({ ], }, { - code: - "var hooks = require('async_hooks'); hooks.createHook()", + code: "var hooks = require('async_hooks'); hooks.createHook()", options: [ { version: "8.0.9", @@ -537,8 +509,7 @@ new RuleTester({ ], }, { - code: - "var { createHook } = require('async_hooks'); createHook()", + code: "var { createHook } = require('async_hooks'); createHook()", options: [ { version: "8.0.9", @@ -547,8 +518,7 @@ new RuleTester({ ], }, { - code: - "import async_hooks from 'async_hooks'; async_hooks.createHook()", + code: "import async_hooks from 'async_hooks'; async_hooks.createHook()", options: [ { version: "8.0.9", @@ -557,8 +527,7 @@ new RuleTester({ ], }, { - code: - "import { createHook } from 'async_hooks'; createHook()", + code: "import { createHook } from 'async_hooks'; createHook()", options: [ { version: "8.0.9", @@ -567,8 +536,7 @@ new RuleTester({ ], }, { - code: - "const { AsyncLocalStorage } = require('async_hooks'); new AsyncLocalStorage();", + code: "const { AsyncLocalStorage } = require('async_hooks'); new AsyncLocalStorage();", options: [ { version: "13.9.0", @@ -577,8 +545,7 @@ new RuleTester({ ], }, { - code: - "import hooks from 'async_hooks'; new hooks.AsyncLocalStorage();", + code: "import hooks from 'async_hooks'; new hooks.AsyncLocalStorage();", options: [ { version: "13.9.0", @@ -587,8 +554,7 @@ new RuleTester({ ], }, { - code: - "const { AsyncLocalStorage } = require('async_hooks'); new AsyncLocalStorage();", + code: "const { AsyncLocalStorage } = require('async_hooks'); new AsyncLocalStorage();", options: [ { version: "12.16.0", @@ -597,8 +563,7 @@ new RuleTester({ ], }, { - code: - "import hooks from 'async_hooks'; new hooks.AsyncLocalStorage();", + code: "import hooks from 'async_hooks'; new hooks.AsyncLocalStorage();", options: [ { version: "12.16.0", @@ -673,8 +638,7 @@ new RuleTester({ ], }, { - code: - "var hooks = require('async_hooks'); hooks.createHook()", + code: "var hooks = require('async_hooks'); hooks.createHook()", options: [{ version: "8.0.9" }], errors: [ { @@ -688,8 +652,7 @@ new RuleTester({ ], }, { - code: - "var { createHook } = require('async_hooks'); createHook()", + code: "var { createHook } = require('async_hooks'); createHook()", options: [{ version: "8.0.9" }], errors: [ { @@ -703,8 +666,7 @@ new RuleTester({ ], }, { - code: - "import async_hooks from 'async_hooks'; async_hooks.createHook()", + code: "import async_hooks from 'async_hooks'; async_hooks.createHook()", options: [{ version: "8.0.9" }], errors: [ { @@ -718,8 +680,7 @@ new RuleTester({ ], }, { - code: - "import { createHook } from 'async_hooks'; createHook()", + code: "import { createHook } from 'async_hooks'; createHook()", options: [{ version: "8.0.9" }], errors: [ { @@ -733,8 +694,7 @@ new RuleTester({ ], }, { - code: - "const { AsyncLocalStorage } = require('async_hooks'); new AsyncLocalStorage();", + code: "const { AsyncLocalStorage } = require('async_hooks'); new AsyncLocalStorage();", options: [{ version: "13.9.0" }], errors: [ { @@ -748,8 +708,7 @@ new RuleTester({ ], }, { - code: - "import hooks from 'async_hooks'; new hooks.AsyncLocalStorage();", + code: "import hooks from 'async_hooks'; new hooks.AsyncLocalStorage();", options: [{ version: "13.9.0" }], errors: [ { @@ -763,8 +722,7 @@ new RuleTester({ ], }, { - code: - "const { AsyncLocalStorage } = require('async_hooks'); new AsyncLocalStorage();", + code: "const { AsyncLocalStorage } = require('async_hooks'); new AsyncLocalStorage();", options: [{ version: "12.16.0" }], errors: [ { @@ -778,8 +736,7 @@ new RuleTester({ ], }, { - code: - "import hooks from 'async_hooks'; new hooks.AsyncLocalStorage();", + code: "import hooks from 'async_hooks'; new hooks.AsyncLocalStorage();", options: [{ version: "12.16.0" }], errors: [ { @@ -845,8 +802,7 @@ new RuleTester({ options: [{ version: "4.5.0" }], }, { - code: - "var {Buffer: b} = require('buffer'); b.allocUnsafeSlow", + code: "var {Buffer: b} = require('buffer'); b.allocUnsafeSlow", options: [{ version: "4.5.0" }], }, { @@ -932,8 +888,7 @@ new RuleTester({ ], }, { - code: - "var {Buffer: b} = require('buffer'); b.allocUnsafeSlow", + code: "var {Buffer: b} = require('buffer'); b.allocUnsafeSlow", options: [ { version: "4.4.9", @@ -1124,8 +1079,7 @@ new RuleTester({ ], }, { - code: - "var {Buffer: b} = require('buffer'); b.allocUnsafeSlow", + code: "var {Buffer: b} = require('buffer'); b.allocUnsafeSlow", options: [{ version: "4.4.9" }], errors: [ { @@ -1225,8 +1179,7 @@ new RuleTester({ options: [{ version: "2.2.0" }], }, { - code: - "var { ChildProcess } = require('child_process'); ChildProcess", + code: "var { ChildProcess } = require('child_process'); ChildProcess", options: [{ version: "2.2.0" }], }, { @@ -1258,8 +1211,7 @@ new RuleTester({ ], }, { - code: - "var { ChildProcess } = require('child_process'); ChildProcess", + code: "var { ChildProcess } = require('child_process'); ChildProcess", options: [ { version: "2.1.9", @@ -1316,8 +1268,7 @@ new RuleTester({ ], }, { - code: - "var { ChildProcess } = require('child_process'); ChildProcess", + code: "var { ChildProcess } = require('child_process'); ChildProcess", options: [{ version: "2.1.9" }], errors: [ { @@ -1844,18 +1795,15 @@ new RuleTester({ options: [{ version: "9.0.0" }], }, { - code: - "var { Certificate: c } = require('crypto'); c.exportChallenge()", + code: "var { Certificate: c } = require('crypto'); c.exportChallenge()", options: [{ version: "9.0.0" }], }, { - code: - "var { Certificate: c } = require('crypto'); c.exportPublicKey()", + code: "var { Certificate: c } = require('crypto'); c.exportPublicKey()", options: [{ version: "9.0.0" }], }, { - code: - "var { Certificate: c } = require('crypto'); c.verifySpkac()", + code: "var { Certificate: c } = require('crypto'); c.verifySpkac()", options: [{ version: "9.0.0" }], }, { @@ -1944,8 +1892,7 @@ new RuleTester({ ], }, { - code: - "var { Certificate: c } = require('crypto'); c.exportChallenge()", + code: "var { Certificate: c } = require('crypto'); c.exportChallenge()", options: [ { version: "8.9.9", @@ -1954,8 +1901,7 @@ new RuleTester({ ], }, { - code: - "var { Certificate: c } = require('crypto'); c.exportPublicKey()", + code: "var { Certificate: c } = require('crypto'); c.exportPublicKey()", options: [ { version: "8.9.9", @@ -1964,8 +1910,7 @@ new RuleTester({ ], }, { - code: - "var { Certificate: c } = require('crypto'); c.verifySpkac()", + code: "var { Certificate: c } = require('crypto'); c.verifySpkac()", options: [ { version: "8.9.9", @@ -2133,8 +2078,7 @@ new RuleTester({ ], }, { - code: - "var { Certificate: c } = require('crypto'); c.exportChallenge()", + code: "var { Certificate: c } = require('crypto'); c.exportChallenge()", options: [{ version: "8.9.9" }], errors: [ { @@ -2148,8 +2092,7 @@ new RuleTester({ ], }, { - code: - "var { Certificate: c } = require('crypto'); c.exportPublicKey()", + code: "var { Certificate: c } = require('crypto'); c.exportPublicKey()", options: [{ version: "8.9.9" }], errors: [ { @@ -2163,8 +2106,7 @@ new RuleTester({ ], }, { - code: - "var { Certificate: c } = require('crypto'); c.verifySpkac()", + code: "var { Certificate: c } = require('crypto'); c.verifySpkac()", options: [{ version: "8.9.9" }], errors: [ { @@ -3568,8 +3510,7 @@ new RuleTester({ options: [{ version: "9.0.0" }], }, { - code: - "var { toNamespacedPath } = require('path'); toNamespacedPath()", + code: "var { toNamespacedPath } = require('path'); toNamespacedPath()", options: [{ version: "9.0.0" }], }, { @@ -3577,8 +3518,7 @@ new RuleTester({ options: [{ version: "9.0.0" }], }, { - code: - "import { toNamespacedPath } from 'path'; toNamespacedPath()", + code: "import { toNamespacedPath } from 'path'; toNamespacedPath()", options: [{ version: "9.0.0" }], }, @@ -3602,8 +3542,7 @@ new RuleTester({ ], }, { - code: - "var { toNamespacedPath } = require('path'); toNamespacedPath()", + code: "var { toNamespacedPath } = require('path'); toNamespacedPath()", options: [ { version: "8.9.9", @@ -3621,8 +3560,7 @@ new RuleTester({ ], }, { - code: - "import { toNamespacedPath } from 'path'; toNamespacedPath()", + code: "import { toNamespacedPath } from 'path'; toNamespacedPath()", options: [ { version: "8.9.9", @@ -3661,8 +3599,7 @@ new RuleTester({ ], }, { - code: - "var { toNamespacedPath } = require('path'); toNamespacedPath()", + code: "var { toNamespacedPath } = require('path'); toNamespacedPath()", options: [{ version: "8.9.9" }], errors: [ { @@ -3690,8 +3627,7 @@ new RuleTester({ ], }, { - code: - "import { toNamespacedPath } from 'path'; toNamespacedPath()", + code: "import { toNamespacedPath } from 'path'; toNamespacedPath()", options: [{ version: "8.9.9" }], errors: [ { @@ -4089,8 +4025,7 @@ new RuleTester({ { messageId: "unsupported", data: { - name: - "process.hasUncaughtExceptionCaptureCallback", + name: "process.hasUncaughtExceptionCaptureCallback", supported: "9.3.0", version: "9.2.9", }, @@ -4161,8 +4096,7 @@ new RuleTester({ { messageId: "unsupported", data: { - name: - "process.setUncaughtExceptionCaptureCallback", + name: "process.setUncaughtExceptionCaptureCallback", supported: "9.3.0", version: "9.2.9", }, @@ -5020,13 +4954,11 @@ new RuleTester({ options: [{ version: "8.0.0" }], }, { - code: - "var hooks = require('v8'); hooks.cachedDataVersionTag()", + code: "var hooks = require('v8'); hooks.cachedDataVersionTag()", options: [{ version: "8.0.0" }], }, { - code: - "var { cachedDataVersionTag } = require('v8'); cachedDataVersionTag()", + code: "var { cachedDataVersionTag } = require('v8'); cachedDataVersionTag()", options: [{ version: "8.0.0" }], }, { @@ -5034,8 +4966,7 @@ new RuleTester({ options: [{ version: "8.0.0" }], }, { - code: - "import { cachedDataVersionTag } from 'v8'; cachedDataVersionTag()", + code: "import { cachedDataVersionTag } from 'v8'; cachedDataVersionTag()", options: [{ version: "8.0.0" }], }, { @@ -5095,8 +5026,7 @@ new RuleTester({ ], }, { - code: - "var hooks = require('v8'); hooks.cachedDataVersionTag()", + code: "var hooks = require('v8'); hooks.cachedDataVersionTag()", options: [ { version: "7.9.9", @@ -5105,8 +5035,7 @@ new RuleTester({ ], }, { - code: - "var { cachedDataVersionTag } = require('v8'); cachedDataVersionTag()", + code: "var { cachedDataVersionTag } = require('v8'); cachedDataVersionTag()", options: [ { version: "7.9.9", @@ -5124,8 +5053,7 @@ new RuleTester({ ], }, { - code: - "import { cachedDataVersionTag } from 'v8'; cachedDataVersionTag()", + code: "import { cachedDataVersionTag } from 'v8'; cachedDataVersionTag()", options: [ { version: "7.9.9", @@ -5244,8 +5172,7 @@ new RuleTester({ ], }, { - code: - "var hooks = require('v8'); hooks.cachedDataVersionTag()", + code: "var hooks = require('v8'); hooks.cachedDataVersionTag()", options: [{ version: "7.9.9" }], errors: [ { @@ -5259,8 +5186,7 @@ new RuleTester({ ], }, { - code: - "var { cachedDataVersionTag } = require('v8'); cachedDataVersionTag()", + code: "var { cachedDataVersionTag } = require('v8'); cachedDataVersionTag()", options: [{ version: "7.9.9" }], errors: [ { @@ -5288,8 +5214,7 @@ new RuleTester({ ], }, { - code: - "import { cachedDataVersionTag } from 'v8'; cachedDataVersionTag()", + code: "import { cachedDataVersionTag } from 'v8'; cachedDataVersionTag()", options: [{ version: "7.9.9" }], errors: [ { diff --git a/tests/lib/rules/prefer-global/buffer.js b/tests/lib/rules/prefer-global/buffer.js index 529c0dee..bc1e29d8 100644 --- a/tests/lib/rules/prefer-global/buffer.js +++ b/tests/lib/rules/prefer-global/buffer.js @@ -23,20 +23,17 @@ new RuleTester({ options: ["always"], }, { - code: - "var { Buffer } = require('buffer'); var b = Buffer.alloc(10)", + code: "var { Buffer } = require('buffer'); var b = Buffer.alloc(10)", options: ["never"], }, ], invalid: [ { - code: - "var { Buffer } = require('buffer'); var b = Buffer.alloc(10)", + code: "var { Buffer } = require('buffer'); var b = Buffer.alloc(10)", errors: [{ messageId: "preferGlobal" }], }, { - code: - "var { Buffer } = require('buffer'); var b = Buffer.alloc(10)", + code: "var { Buffer } = require('buffer'); var b = Buffer.alloc(10)", options: ["always"], errors: [{ messageId: "preferGlobal" }], }, diff --git a/tests/lib/rules/prefer-global/text-decoder.js b/tests/lib/rules/prefer-global/text-decoder.js index 668a4c81..fad92671 100644 --- a/tests/lib/rules/prefer-global/text-decoder.js +++ b/tests/lib/rules/prefer-global/text-decoder.js @@ -23,20 +23,17 @@ new RuleTester({ options: ["always"], }, { - code: - "var { TextDecoder } = require('util'); var b = new TextDecoder(s)", + code: "var { TextDecoder } = require('util'); var b = new TextDecoder(s)", options: ["never"], }, ], invalid: [ { - code: - "var { TextDecoder } = require('util'); var b = new TextDecoder(s)", + code: "var { TextDecoder } = require('util'); var b = new TextDecoder(s)", errors: [{ messageId: "preferGlobal" }], }, { - code: - "var { TextDecoder } = require('util'); var b = new TextDecoder(s)", + code: "var { TextDecoder } = require('util'); var b = new TextDecoder(s)", options: ["always"], errors: [{ messageId: "preferGlobal" }], }, diff --git a/tests/lib/rules/prefer-global/text-encoder.js b/tests/lib/rules/prefer-global/text-encoder.js index 58d25671..5f5bfd62 100644 --- a/tests/lib/rules/prefer-global/text-encoder.js +++ b/tests/lib/rules/prefer-global/text-encoder.js @@ -23,20 +23,17 @@ new RuleTester({ options: ["always"], }, { - code: - "var { TextEncoder } = require('util'); var b = new TextEncoder(s)", + code: "var { TextEncoder } = require('util'); var b = new TextEncoder(s)", options: ["never"], }, ], invalid: [ { - code: - "var { TextEncoder } = require('util'); var b = new TextEncoder(s)", + code: "var { TextEncoder } = require('util'); var b = new TextEncoder(s)", errors: [{ messageId: "preferGlobal" }], }, { - code: - "var { TextEncoder } = require('util'); var b = new TextEncoder(s)", + code: "var { TextEncoder } = require('util'); var b = new TextEncoder(s)", options: ["always"], errors: [{ messageId: "preferGlobal" }], }, diff --git a/tests/lib/rules/prefer-global/url-search-params.js b/tests/lib/rules/prefer-global/url-search-params.js index 1bcca9b0..1952e67e 100644 --- a/tests/lib/rules/prefer-global/url-search-params.js +++ b/tests/lib/rules/prefer-global/url-search-params.js @@ -23,20 +23,17 @@ new RuleTester({ options: ["always"], }, { - code: - "var { URLSearchParams } = require('url'); var b = new URLSearchParams(s)", + code: "var { URLSearchParams } = require('url'); var b = new URLSearchParams(s)", options: ["never"], }, ], invalid: [ { - code: - "var { URLSearchParams } = require('url'); var b = new URLSearchParams(s)", + code: "var { URLSearchParams } = require('url'); var b = new URLSearchParams(s)", errors: [{ messageId: "preferGlobal" }], }, { - code: - "var { URLSearchParams } = require('url'); var b = new URLSearchParams(s)", + code: "var { URLSearchParams } = require('url'); var b = new URLSearchParams(s)", options: ["always"], errors: [{ messageId: "preferGlobal" }], },