Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Very slow performance while calling setModel on Firefox compare to Chrome #106

Open
hirenvadalia opened this issue Feb 1, 2019 · 7 comments

Comments

@hirenvadalia
Copy link

Thanks for the wonderful component! 🥇

But there is very slow performance while calling setModel (since data prop is not reactive) on Firefox compare to Chrome with the same number of items in the tree.

To reproduce run below code sandbox in chrome and firefox and see the time it reports to call setModel on tree:
https://codesandbox.io/embed/n5xp7999yj

@hirenvadalia
Copy link
Author

@amsik Any update on a fix for this or any workaround as this is really affecting me?

@hirenvadalia
Copy link
Author

@amsik any update on this?

@hirenvadalia
Copy link
Author

@amsik This issue is really affecting me. Do you have any plan to look into this and fix it?

@amsik
Copy link
Owner

amsik commented Aug 29, 2019

Hi. I will check it on weekends.

@hirenvadalia
Copy link
Author

@amsik Any update on this? did you get a chance to look into this?

@amsik
Copy link
Owner

amsik commented Sep 24, 2019

Hi. It is VueJS specific issue. It adds Observable objects to each property. But my fix might help. Please check a new version.

@hirenvadalia
Copy link
Author

@amsik thanks will test and update you on the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants