Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pre-commit plugins to work with python>3.11 #371

Open
bkreider opened this issue Jan 9, 2025 · 0 comments
Open

Fix pre-commit plugins to work with python>3.11 #371

bkreider opened this issue Jan 9, 2025 · 0 comments

Comments

@bkreider
Copy link
Contributor

bkreider commented Jan 9, 2025

I had to limit the environment.yaml to <3.12 because of pre-commit failures. See discussion here:
https://github.com/anaconda/anaconda-linter/pull/369/files/38afd56f38143fd61b8f7ae545e37e935c3f2d09#diff-0ff3348ae0de662ef053d7de057a7a92c091a09fc3d245c8da02bec028ca3d0b

Also, it looks like the CI action manually patches the environment.yaml here: https://github.com/anaconda/anaconda-linter/blob/main/.github/actions/setup-env/action.yaml#L32

sed -i 's/- python >=3.*$/- python ${{ inputs.python-version }}.*/' environment.yaml

So a few fixes needed here:

  1. Fix pre-commit plugins to work with python 3.12. I think they are hard coded for python 3.11.
  2. Update the environment.yaml to use python>=3.11
  3. Update the CI (action.yaml) to not patch it back to 3.11.
  4. Update the setup.py to show that only python 3.11+ is supported. Note: Percy is a hard dependency and only works for 3.11+.
@bkreider bkreider mentioned this issue Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant