Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve install.sh error messages if we get an error from GitHub #2460

Open
morsisko opened this issue Dec 30, 2023 · 3 comments
Open

Improve install.sh error messages if we get an error from GitHub #2460

morsisko opened this issue Dec 30, 2023 · 3 comments
Labels
bug Something isn't working

Comments

@morsisko
Copy link

What happened:
An error during installation occurred:

[error] unable to find tag='' 
[error] do not specify a version or select a valid version from https://github.com/anchore/syft/releases

What you expected to happen:
The syft to be installed

Steps to reproduce the issue:
Type curl -sSfL https://raw.githubusercontent.com/anchore/syft/main/install.sh | sh -s -- -b /usr/local/bin in your terminal

Anything else we need to know?:
I have seen similar issues posted there, but the bugfix was not implemented as github reverted their changes to the api endpoint, it looks like this time they implemented it again.

Environment:

PRETTY_NAME="Ubuntu 23.04"
NAME="Ubuntu"
VERSION_ID="23.04"
VERSION="23.04 (Lunar Lobster)"
VERSION_CODENAME=lunar
ID=ubuntu
ID_LIKE=debian
HOME_URL="https://www.ubuntu.com/"
SUPPORT_URL="https://help.ubuntu.com/"
BUG_REPORT_URL="https://bugs.launchpad.net/ubuntu/"
PRIVACY_POLICY_URL="https://www.ubuntu.com/legal/terms-and-policies/privacy-policy"
UBUNTU_CODENAME=lunar
LOGO=ubuntu-logo
@morsisko morsisko added the bug Something isn't working label Dec 30, 2023
@tgerla
Copy link
Contributor

tgerla commented Dec 31, 2023

Hi @morsisko, I tried this locally and couldn't reproduce the problem. I wonder if it was a transient GitHub outage? Do you mind trying again? It might be the case we need some better error handling here. Thanks!

@tgerla tgerla moved this to Awaiting Response in OSS Dec 31, 2023
@tgerla
Copy link
Contributor

tgerla commented Jan 4, 2024

This is probably due to a transient outage at github. We should probably improve the error message in the install script to mention that possible cause: https://github.com/anchore/syft/blob/bf39456fbcf9105895cfabcc445f8c313e9aa01b/install.sh#L650C1-L650C1

We'll put this in the backlog for a fix.

@tgerla tgerla moved this from Awaiting Response to Backlog in OSS Jan 4, 2024
@tgerla tgerla changed the title Error during installation - unable to find tag= Improve install.sh error messages if we get an error from GitHub Jan 4, 2024
@morsisko
Copy link
Author

morsisko commented Jan 6, 2024

Hello, sorry for the delay. It works fine now. But I'm pretty sure this is no related to github outage, as I could access the repo and download the release manually without any problem

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Backlog
Development

No branches or pull requests

2 participants