Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"syft config" output swaps comments for search-indexed-archives / search-unindexed-archives #3624

Closed
e4711s opened this issue Jan 28, 2025 · 1 comment · Fixed by #3630
Closed
Labels
bug Something isn't working

Comments

@e4711s
Copy link

e4711s commented Jan 28, 2025

What happened:
syft config prints the following section:

package:
# search within archives that do contain a file index to search against (zip)
# note: for now this only applies to the java package cataloger (env: SYFT_PACKAGE_SEARCH_UNINDEXED_ARCHIVES)
search-unindexed-archives: false

# search within archives that do not contain a file index to search against (tar, tar.gz, tar.bz2, etc)
# note: enabling this may result in a performance impact since all discovered compressed tars will be decompressed
# note: for now this only applies to the java package cataloger (env: SYFT_PACKAGE_SEARCH_INDEXED_ARCHIVES)
search-indexed-archives: true

What you expected to happen:

the following section instead:

package:
# search within archives that do not contain a file index to search against (tar, tar.gz, tar.bz2, etc)
# note: enabling this may result in a performance impact since all discovered compressed tars will be decompressed
# note: for now this only applies to the java package cataloger (env: SYFT_PACKAGE_SEARCH_INDEXED_ARCHIVES)
search-unindexed-archives: false

# search within archives that do contain a file index to search against (zip)
# note: for now this only applies to the java package cataloger (env: SYFT_PACKAGE_SEARCH_UNINDEXED_ARCHIVES)
search-indexed-archives: true

Steps to reproduce the issue:

run syft config

Anything else we need to know?:
see also anchore/grype#2409

Environment:

  • Output of syft version:
    Application: syft
    Version: 1.19.0
    BuildDate: 2025-01-22T19:57:08Z
    GitCommit: 222e654
    GitDescription: v1.19.0
    Platform: linux/amd64
    GoVersion: go1.23.4
    Compiler: gc
  • OS (e.g: cat /etc/os-release or similar):
    Ubuntu 24.04
@e4711s e4711s added the bug Something isn't working label Jan 28, 2025
@e4711s e4711s changed the title syft config output swaps comments for search-indexed-archives / search-unindexed-archives "syft config" output swaps comments for search-indexed-archives / search-unindexed-archives Jan 28, 2025
@spiffcs spiffcs linked a pull request Jan 29, 2025 that will close this issue
@spiffcs spiffcs moved this to In Progress in OSS Jan 29, 2025
@github-project-automation github-project-automation bot moved this from In Progress to Done in OSS Jan 29, 2025
@spiffcs
Copy link
Contributor

spiffcs commented Jan 29, 2025

Thanks @e4711s

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants