Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New keywords are not recognized #46

Open
the42 opened this issue Dec 20, 2023 · 2 comments
Open

New keywords are not recognized #46

the42 opened this issue Dec 20, 2023 · 2 comments
Assignees
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@the42
Copy link

the42 commented Dec 20, 2023

d2 on it's way to 1.0 underwent some significant overhauls which are not reflected in the package. Globs come to mind.

@andorsk
Copy link
Owner

andorsk commented Dec 27, 2023

got it. thanks for bringing to my attention. Agreed this needs to be updated. Will see when I can get around to it

@andorsk andorsk self-assigned this Dec 27, 2023
@andorsk andorsk added enhancement New feature or request help wanted Extra attention is needed labels Dec 27, 2023
@andorsk
Copy link
Owner

andorsk commented Jan 7, 2024

Looking at this, probably the best way to handle this is to compile a list of unsupported keywords. Is there a list of changes that can be easily diffed?

I see globs, https://d2lang.com/tour/globs/. It would be great to draw more explicit differences between current behavior and what should be expected. Syntax highlighting is done here: https://github.com/andorsk/d2-mode/blob/main/d2-mode.el#L92.

Here's a start with glob. I'm sure there are others, probably makes sense to batch them into a single effort

*.mini.height: 300 <- height and * should be both one color face, mini should be another. 300 another. Will need to play around with types, it's been a while since I've looked into this.

Can we please this ticket to document the deltas between the old and newer version of keywords, and then we can create an actual PR to address the changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants