Memory issue? Pomo not notifying end of sessions

[agent4tea7]

Lately, Calcifer starts a session but forgets to end it and notify user that it has ended.

The frequency of this happening is random.

[sjBao]

not sure if this is related but here is an unexpected behavior that I also encountered:

c: pom pom >>> created timer for 50 minutes
c: cancel >>> received a cancellation message
c: pom >>> received a message for new 25 minute pom

-- 25 minutes after first pom, never received a pom completion message --

c: pom >>> received message that I'm already working

-- 50 minutes after first pom, received pom completion message for first pom.

[andreidimaano]

This may have a possible fix - moving everything the isStudying functionality to the database.

Tradeoffs:

1. O(logn) search time for all users in a server vs O(n) search time for all users currently studying
2. A user may still be studying when the bot turns off, this means that a user may be marked as isStudying when the bot restarts when in fact, the bot just restarted and never removed from isStudying
3. More data - every user now has an isStudying datatype but this should be O(1) added space. However, we are adding O(n) space when considering the new collection of isStudying members and isOnBreak Members.

Tradeoff 2 may be fixed by creating a collection in the database called "users currently studying" and when the bot restarts (due to Heroku) I will check if any users are still currently studying, and clear them (and maybe award them points).

[han-codes]

Just leaving a comment that I noticed this issue a couple times today of not being notified when pom ends :)
Edit: Pom persists until it's cancelled with c: cancel

[agent4tea7]

Second this issue, it's not ending sessions for some users. It's increasingly difficult to work with, as you have to manually end the sessions, kind of defeats the purpose of a timer-bot. Does kicking the bot off and inviting back on fix this issue? Has anyone tried?

[andreidimaano]

Second this issue, it's not ending sessions for some users. It's increasingly difficult to work with, as you have to manually end the sessions, kind of defeats the purpose of a timer-bot. Does kicking the bot off and inviting back on fix this issue? Has anyone tried?

It says the bot is missing permissions

The other issue is that guild is sometimes null so people are starting pomodoros through DM Channels

[andreidimaano]

Does kicking the bot off and inviting back on fix this issue? Has anyone tried?

Kicking the bot and then adding it back won't work.

[agent4tea7]

Second this issue, it's not ending sessions for some users. It's increasingly difficult to work with, as you have to manually end the sessions, kind of defeats the purpose of a timer-bot. Does kicking the bot off and inviting back on fix this issue? Has anyone tried?

It says the bot is missing permissions

The other issue is that guild is sometimes null so people are starting pomodoros through DM Channels

If the bot is missing permissions, how is it able to start and end timers for some users and not for others? - I don't think these users are starting timers from DM channels. There's dedicated channel for this bot.

Does the bot need admin rights? Wouldn't think so..but Idk.