Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make compatible with Middleman v3 and v4 #26

Open
manuelmeurer opened this issue May 5, 2016 · 2 comments
Open

Make compatible with Middleman v3 and v4 #26

manuelmeurer opened this issue May 5, 2016 · 2 comments

Comments

@manuelmeurer
Copy link
Collaborator

manuelmeurer commented May 5, 2016

After merging #23 (and doing some cleanup), the master branch currently only works with Middleman v4. I would like it to work with Middleman v3 and v4 and then release 1.0. 😄
It shouldn't be too hard, we probably only need to make sure to use the v3 syntax for loading the Extension and Invalidate classes (see lib/middleman-bootstrap-navbar/extension.rb here)
First I would like to add Appraisal to test different Middleman versions and started to do so in the appraisals branch.
Since I'm no good at Cucumber, I'm having a hard time writing the cukes though. 😄
If someone could help me out here, that would be fantastic.
@andrusha do you have time?

@monfresh
Copy link

monfresh commented Jun 5, 2016

I had been using both middleman-s3_sync and this gem, but with the after_sync being removed in Middleman v4, and out of curiosity, I started looking for alternatives. I came across a gem that does not have any dependency on any specific static site generator. This means you can use it with any version of Middleman or Jekyll or any other generator. Check it out, it's really cool:

https://github.com/laurilehmijoki/s3_website

It supports S3 sync, CF invalidation, redirects, and a lot more.

@manuelmeurer
Copy link
Collaborator Author

@monfresh Looks interesting, thanks for the hint! 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants