Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

It must not be possible to delete IONMedia items which are used in published pages (also consider usage via StreamField / IonMediaBlock) #12

Open
rollacting opened this issue Mar 1, 2021 · 2 comments
Open

It must not be possible to delete IONMedia items which are used in published pages (also consider usage via StreamField / IonMediaBlock) #12

rollacting opened this issue Mar 1, 2021 · 2 comments
Assignees
@ferdinand-hoffmann
Labels
Bug Something isn't working Priority: !!! Important issue Status: To Test Pull request merged, needs testing

Comments

@rollacting
Copy link
Contributor

limiting this to published pages would be enough imho, since the validation is triggered when trying to publish drafts with missing video files
@rollacting rollacting added Bug Something isn't working Priority: !!! Important issue labels Mar 1, 2021
@rollacting rollacting added the Status: To Do Should be worked on in this milestone label Mar 5, 2021
@rollacting
Copy link
Contributor Author

also, can we add audit-log logic to our ION media / image models?
https://docs.wagtail.io/en/stable/advanced_topics/audit_log.html

ferdinand-hoffmann pushed a commit that referenced this issue Mar 9, 2021
Implement get_object_block_usage
51de278 
Works similar to `wagtail.admin.models.get_object_usage` but inspects
pages to find blocks linked to the object

Re #12
ferdinand-hoffmann pushed a commit that referenced this issue Mar 9, 2021
Handle media file deletion in post_delete signal handler
63115d5 
Re #12
ferdinand-hoffmann pushed a commit that referenced this issue Mar 9, 2021
Extend get_usage() of file based models to include get_object_block_u…
dac2cff 
…sage()

Re #12
ferdinand-hoffmann pushed a commit that referenced this issue Mar 9, 2021
Intercept delete views of file based models to prevent deletion on ob…
a19aa46 
…ject usage

Re #12
ferdinand-hoffmann pushed a commit that referenced this issue Mar 9, 2021
Extend django admin of file based models to prevent deletion on objec…
f70d689 
…t usage

Re #12
ferdinand-hoffmann pushed a commit that referenced this issue Mar 9, 2021
Refactor: move IonMediaBlock to blocks module
c6cc8c0 
Re #12
ferdinand-hoffmann pushed a commit that referenced this issue Mar 9, 2021
Refactor: move block types to check on get_usage() to dedicated attri…
412b2db 
…bute

Re #12
ferdinand-hoffmann pushed a commit that referenced this issue Mar 9, 2021
Prevent deletion of file based models on usage
e6549d8 
Re #12
@ferdinand-hoffmann ferdinand-hoffmann mentioned this issue Mar 9, 2021
Merged
ferdinand-hoffmann pushed a commit that referenced this issue Mar 9, 2021
Prevent deletion of file based models on usage
0ac22f7 
Re #12
ferdinand-hoffmann pushed a commit that referenced this issue Mar 10, 2021
Intercept delete views of file based models to prevent deletion if re…
df6ba1c 
…ferenced in blocks

Re #12
ferdinand-hoffmann pushed a commit that referenced this issue Mar 10, 2021
Extend django admin of file based models to prevent deletion if refer…
6419152 
…enced in blocks

Re #12
ferdinand-hoffmann pushed a commit that referenced this issue Mar 10, 2021
Refactor: move IonMediaBlock to blocks module
2254627 
Re #12
ferdinand-hoffmann pushed a commit that referenced this issue Mar 10, 2021
Refactor: move block types to check on get_usage() to dedicated attri…
c1dd485 
…bute

Re #12
ferdinand-hoffmann pushed a commit that referenced this issue Mar 10, 2021
Prevent deletion of file based models if referenced in blocks
95fb373 
Re #12
@ferdinand-hoffmann
Copy link

also, can we add audit-log logic to our ION media / image models?
https://docs.wagtail.io/en/stable/advanced_topics/audit_log.html

Re #16

@rollacting rollacting added Status: To Test Pull request merged, needs testing and removed Status: To Do Should be worked on in this milestone labels Mar 15, 2021
ferdinand-hoffmann pushed a commit that referenced this issue Mar 16, 2021
Return bound block in get_stream_value_blocks() instead of block & value
f7a37a9 
Re #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ferdinand-hoffmann ferdinand-hoffmann

Labels
Bug Something isn't working Priority: !!! Important issue Status: To Test Pull request merged, needs testing
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dunkelstern @rollacting @ferdinand-hoffmann