From 0c974d553cf63ce32472c76dd83a7ce670c37ea9 Mon Sep 17 00:00:00 2001
From: Michael <20623991+heueristik@users.noreply.github.com>
Date: Tue, 27 Aug 2024 18:50:48 +0200
Subject: [PATCH] refactor: wrong comparator in assert and maybe asserts (#11)

* fix: wrong comparator

* feat: more tests

* feat: improve api
---
 Example.juvix        | 24 +++++++++++++++++-------
 Test/JuvixUnit.juvix | 26 ++++++++++++++++----------
 2 files changed, 33 insertions(+), 17 deletions(-)

diff --git a/Example.juvix b/Example.juvix
index 8dd84be..910a663 100644
--- a/Example.juvix
+++ b/Example.juvix
@@ -6,13 +6,23 @@ import Test.JuvixUnit open;
 headMay {A} : List A -> Maybe A := map just >> head nothing;
 
 tests : List Test :=
-  [ testCase "1 == 1" (assertEqual "1 /= 1" 1 1)
-  ; testCase "[1] == [1]" (assertEqual "[1] /= [1]" [1] [1])
-  ; testCase "length [1] == 1" (assertTrue "length [1] /= 1" (length [1] == 1))
-  ; testCase
-    "headMay [] is nothing"
-    (assertNothing λ {xs := "expected nothing, got: " ++str Show.show xs} (headMay {Nat} []))
-  ; testCase "headMay [1] is just" (assertJust "expected just, got nothing" (headMay [1]))
+  [ testCase "1 == 1" (expectEqual 1 1)
+  ; testCase "2 > 1" (expectGreater 2 1)
+  ; testCase "2 >= 1" (expectGreaterEqual 2 1)
+  ; testCase "1 >= 1" (expectGreaterEqual 1 1)
+  ; testCase "1 < 2" (expectLess 1 2)
+  ; testCase "1 <= 2" (expectLessEqual 1 2)
+  ; testCase "1 <= 1" (expectLessEqual 1 1)
+  ; testCase "[1] == [1]" (expectEqual [1] [1])
+  ; testCase "[2] > [1]" (expectGreater [2] [1])
+  ; testCase "[2] >= [1]" (expectGreaterEqual [2] [1])
+  ; testCase "[1] >= [1]" (expectGreaterEqual [1] [1])
+  ; testCase "[1] < [2]" (expectLess [1] [2])
+  ; testCase "[1] <= [2]" (expectLessEqual [1] [2])
+  ; testCase "[1] <= [1]" (expectLessEqual [1] [1])
+  ; testCase "length [1] == 1" (expectTrue (length [1] == 1))
+  ; testCase "headMay [] is nothing" (expectNothing (headMay {Nat} []))
+  ; testCase "headMay [1] is just 1" (expectJust 1 (headMay [1]))
   ];
 
 main : IO := runTestSuite (testSuite "Example" tests);
diff --git a/Test/JuvixUnit.juvix b/Test/JuvixUnit.juvix
index 98320ef..d0c6970 100644
--- a/Test/JuvixUnit.juvix
+++ b/Test/JuvixUnit.juvix
@@ -54,7 +54,7 @@ assertNothing {A} (mkMsg : A -> String) : Maybe A -> Assertion := maybe pass (mk
 
 assertEqual {A} {{Eq A}} (msg : String) (a1 a2 : A) : Assertion := failUnless msg (a1 == a2);
 
-assertGreater {A} {{Ord A}} (msg : String) (a1 a2 : A) : Assertion := failUnless msg (a1 >= a2);
+assertGreater {A} {{Ord A}} (msg : String) (a1 a2 : A) : Assertion := failUnless msg (a1 > a2);
 
 assertGreaterEqual {A} {{Ord A}} (msg : String) (a1 a2 : A) : Assertion :=
   failUnless msg (a1 >= a2);
@@ -63,24 +63,30 @@ assertLess {A} {{Ord A}} (msg : String) (a1 a2 : A) : Assertion := failUnless ms
 
 assertLessEqual {A} {{Ord A}} (msg : String) (a1 a2 : A) : Assertion := failUnless msg (a1 <= a2);
 
-mkExpectMsg {A} {{Show A}} (expected actual : A) (msg : String) : String :=
-  "\nExpected " ++str Show.show expected ++str "\nto be " ++str msg ++str Show.show actual;
+mkExpectMsg {A} {{Show A}} (actual : A) (msg : String) (expected : A) : String :=
+  "Expected " ++str Show.show actual ++str msg ++str Show.show expected;
 
-expectTrue (actual : Bool) : Assertion := assertTrue (mkExpectMsg true actual "") actual;
+expectTrue (actual : Bool) : Assertion := assertTrue (mkExpectMsg actual " to be " true) actual;
 
-expectFalse (actual : Bool) : Assertion := assertFalse (mkExpectMsg false actual "") actual;
+expectFalse (actual : Bool) : Assertion := assertFalse (mkExpectMsg actual " to be " false) actual;
 
 expectEqual {A} {{Eq A}} {{Show A}} (expected actual : A) : Assertion :=
-  assertEqual (mkExpectMsg expected actual "equal to ") expected actual;
+  assertEqual (mkExpectMsg actual " == " expected) expected actual;
 
 expectGreater {A} {{Ord A}} {{Show A}} (expected actual : A) : Assertion :=
-  assertGreater (mkExpectMsg expected actual "greater than ") expected actual;
+  assertGreater (mkExpectMsg actual " > " expected) expected actual;
 
 expectGreaterEqual {A} {{Ord A}} {{Show A}} (expected actual : A) : Assertion :=
-  assertGreaterEqual (mkExpectMsg expected actual "greater than or equal to ") expected actual;
+  assertGreaterEqual (mkExpectMsg actual " >= " expected) expected actual;
 
 expectLess {A} {{Ord A}} {{Show A}} (expected actual : A) : Assertion :=
-  assertLess (mkExpectMsg expected actual "less than ") expected actual;
+  assertLess (mkExpectMsg actual " < " expected) expected actual;
 
 expectLessEqual {A} {{Ord A}} {{Show A}} (expected actual : A) : Assertion :=
-  assertLessEqual (mkExpectMsg expected actual "less than or equal to ") expected actual;
+  assertLessEqual (mkExpectMsg actual " <= " expected) expected actual;
+
+expectJust {A} {{Show A}} (expected : A) (actual : Maybe A) : Assertion :=
+  assertJust (mkExpectMsg "nothing" " to be " ("just " ++str Show.show expected)) actual;
+
+expectNothing {A} {{Show A}} (actual : Maybe A) : Assertion :=
+  assertNothing λ {x := mkExpectMsg ("just " ++str Show.show x) " to be " "nothing"} actual;