You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the Compiler/Pipeline/Driver.hs file, when processing the imports we should change the _entryPointPackage field of the EntryPoint to the package of the imported module. We don't do that, which results in wrong package information being associated with the moduleId. This can lead to a name clash when there are two modules with the same name in two different packages, or in two different versions of the same package used as dependencies in the project.
fixes this for the recursive pipelines (for HTML and Isabelle/HOL generation) by modifying processRecursiveUpTo. The solution is a hack, because it reads the global package from disk every time a module in this package is processed. The problem is that for the global package, Package is not available in PackageInfo. The extra disk reads is why I didn't implement this solution in general. The Package should be read only once and information about the Package, not only PackageLike, should be available in PackageInfo.
The text was updated successfully, but these errors were encountered:
#3215)
- Fixes#2985
- Fixes#3154
This pr fixes the above issues by appending the hash of all project
files in the package version. In particular, it appends the hash to the
pre-release tag.
Also, when recursing in an import, we properly update the PackageId in
the Entrypoint.
---------
Co-authored-by: Lukasz Czajka <[email protected]>
In the
Compiler/Pipeline/Driver.hs
file, when processing the imports we should change the_entryPointPackage
field of theEntryPoint
to the package of the imported module. We don't do that, which results in wrong package information being associated with themoduleId
. This can lead to a name clash when there are two modules with the same name in two different packages, or in two different versions of the same package used as dependencies in the project.The PR
fixes this for the recursive pipelines (for HTML and Isabelle/HOL generation) by modifying
processRecursiveUpTo
. The solution is a hack, because it reads the global package from disk every time a module in this package is processed. The problem is that for the global package,Package
is not available inPackageInfo
. The extra disk reads is why I didn't implement this solution in general. ThePackage
should be read only once and information about thePackage
, not onlyPackageLike
, should be available inPackageInfo
.The text was updated successfully, but these errors were encountered: