feat: listen for the transfer success event #1490
Open
+104
−71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
euharrison
changed the title
euharrison
commented
Jan 9, 2025
| }; | ||
| }, deps); | ||
| }, [event]); |
There was a problem hiding this comment.
I lost many hours debugging until realizing this dependencies was the issue 😢
Maybe we should enable the "react-hooks/exhaustive-deps": "warn" and, if you don't want to use, at least you need to add the lint ignore comment
What do you think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Listen for the transfer
Successevent and apply it to the notifications and transaction pageAlso, enable the watcher for cases where the transaction delays and the user closes the browser
Closes #1428
Screen.Recording.2025-01-09.at.15.27.14.mov