From 08386d3703e04adb4775d716795f1d2c70a58c9f Mon Sep 17 00:00:00 2001 From: Massimo Capodiferro <77293250+maxcapodi78@users.noreply.github.com> Date: Wed, 3 Jul 2024 10:02:08 +0200 Subject: [PATCH] REFACTOR: Angle property getter in aedt 2023.2 and below is broken in GRPC and has to be bypassed. (#4867) Co-authored-by: maxcapodi78 --- _unittest/test_21_Circuit.py | 2 +- pyaedt/modeler/circuits/object3dcircuit.py | 8 +++++++- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/_unittest/test_21_Circuit.py b/_unittest/test_21_Circuit.py index f342e63d75d..48127cd7b72 100644 --- a/_unittest/test_21_Circuit.py +++ b/_unittest/test_21_Circuit.py @@ -518,7 +518,7 @@ def test_38_browse_log_file(self): for i in range(10): f.write("L{} net_{} net_{} 1e-9\n".format(i, i, i + 1)) f.write("C{} net_{} 0 5e-12\n".format(i, i + 1)) - self.aedtapp.modeler.components.create_interface_port("net_0", (0, 0)) + self.aedtapp.modeler.components.create_interface_port("net_0", (0, 0), angle=90) self.aedtapp.modeler.components.create_interface_port("net_10", (0.01, 0)) lna = self.aedtapp.create_setup("mylna", self.aedtapp.SETUPS.NexximLNA) lna.props["SweepDefinition"]["Data"] = "LINC 0Hz 1GHz 101" diff --git a/pyaedt/modeler/circuits/object3dcircuit.py b/pyaedt/modeler/circuits/object3dcircuit.py index ac3bb1c2888..93fe04f51df 100644 --- a/pyaedt/modeler/circuits/object3dcircuit.py +++ b/pyaedt/modeler/circuits/object3dcircuit.py @@ -33,6 +33,7 @@ from pyaedt.generic.general_methods import _arg2dict from pyaedt.generic.general_methods import _dim_arg from pyaedt.generic.general_methods import pyaedt_function_handler +from pyaedt.generic.settings import settings from pyaedt.modeler.cad.elements3d import _dict2arg from pyaedt.modeler.geometry_operators import GeometryOperators as go @@ -681,12 +682,17 @@ def angle(self): if "Angle=" in info: self._angle = float(info[6:]) break - else: + elif settings.aedt_version > "2023.2": self._angle = float( self._oeditor.GetPropertyValue("BaseElementTab", self.composed_name, "Component Angle").replace( "deg", "" ) ) + else: # pragma: no cover + self._circuit_components._app.logger.warning( + "Angles are not supported by gRPC in AEDT versions lower than 2024 R1." + ) + return self._angle @angle.setter