From c22f5721572706b58960449f4f69802e4ed4d4cb Mon Sep 17 00:00:00 2001 From: ring630 <@gmail.com> Date: Fri, 27 Oct 2023 15:51:18 +0200 Subject: [PATCH 1/3] fix --- pyaedt/edb_core/edb_data/padstacks_data.py | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/pyaedt/edb_core/edb_data/padstacks_data.py b/pyaedt/edb_core/edb_data/padstacks_data.py index a37d2b2987a..0cbcfb66510 100644 --- a/pyaedt/edb_core/edb_data/padstacks_data.py +++ b/pyaedt/edb_core/edb_data/padstacks_data.py @@ -1455,13 +1455,8 @@ def rotation(self): @property def name(self): - """Padstack Instance Name. If it is a pin, the syntax will be like in AEDT ComponentName-PinName.""" - if self.is_pin: - comp_name = self._edb_padstackinstance.GetComponent().GetName() - pin_name = self._edb_padstackinstance.GetName() - return "-".join([comp_name, pin_name]) - else: - return self._edb_padstackinstance.GetName() + """Padstack Instance Name.""" + return self._edb_padstackinstance.GetName() @name.setter def name(self, value): @@ -1504,6 +1499,7 @@ def metal_volume(self): @property def pin_number(self): """Get pin number.""" + warnings.warn("`pin_number` is deprecated. Use `name` property instead.", DeprecationWarning) return self._edb_padstackinstance.GetName() @property From 0b0163fd623ecc581394f17fadfce438a28dd4af Mon Sep 17 00:00:00 2001 From: ring630 <@gmail.com> Date: Fri, 27 Oct 2023 16:27:58 +0200 Subject: [PATCH 2/3] fix --- _unittest/test_00_EDB.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/_unittest/test_00_EDB.py b/_unittest/test_00_EDB.py index 717b7d2b97d..83e586aab40 100644 --- a/_unittest/test_00_EDB.py +++ b/_unittest/test_00_EDB.py @@ -302,6 +302,8 @@ def test_020_components(self): assert self.edbapp.components.components["R1"].pinlist assert self.edbapp.components.components["R1"].pins assert self.edbapp.components.components["R1"].pins["1"].pin_number + assert self.edbapp.components.components["R1"].pins["1"].name + self.edbapp.components.components["R1"].pins["1"].name = "1a" assert self.edbapp.components.components["R1"].pins["1"].component assert ( self.edbapp.components.components["R1"].pins["1"].lower_elevation From b830887181d3c80bad1ab698207ca7fb86fccc55 Mon Sep 17 00:00:00 2001 From: Hui Zhou Date: Fri, 27 Oct 2023 16:28:18 +0200 Subject: [PATCH 3/3] Update pyaedt/edb_core/edb_data/padstacks_data.py Co-authored-by: Kathy Pippert <84872299+PipKat@users.noreply.github.com> --- pyaedt/edb_core/edb_data/padstacks_data.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pyaedt/edb_core/edb_data/padstacks_data.py b/pyaedt/edb_core/edb_data/padstacks_data.py index 0cbcfb66510..70915aa58ba 100644 --- a/pyaedt/edb_core/edb_data/padstacks_data.py +++ b/pyaedt/edb_core/edb_data/padstacks_data.py @@ -1455,7 +1455,7 @@ def rotation(self): @property def name(self): - """Padstack Instance Name.""" + """Padstack instance name.""" return self._edb_padstackinstance.GetName() @name.setter