Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement(arbiter-core): allow for error bubble up Environment::run #718

Open
Alexangelj opened this issue Nov 18, 2023 · 1 comment
Open
Labels
✨ enhancement new feature, upgrade, or change in modularity 🔧 error handling errors and controlling their flow

Comments

@Alexangelj
Copy link
Contributor

Alexangelj commented Nov 18, 2023

https://github.com/primitivefinance/arbiter/blob/a321af174c2e7ef7520f3c3fcf05dc66bfe97831/arbiter-core/src/environment/mod.rs#L249

I triggered the above while loop to exit, with no message or information, by triggering the following code in middleware's send_transaction method:
https://github.com/primitivefinance/arbiter/blob/a321af174c2e7ef7520f3c3fcf05dc66bfe97831/arbiter-core/src/middleware/mod.rs#L406

Expected behavior is to have these errors propagated. In my case the while loop ended silently.

@Autoparallel Autoparallel changed the title Gracefully handle errors thrown during main environment run while loop enhancement(arbiter-core): allow for error bubble up Environment::run Jan 23, 2024
@Autoparallel Autoparallel added ✨ enhancement new feature, upgrade, or change in modularity 🔧 error handling errors and controlling their flow labels Jan 23, 2024
@Autoparallel
Copy link
Collaborator

@ts0yu this is what I mean when I'm mentioning we should refactor the Environment::run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ enhancement new feature, upgrade, or change in modularity 🔧 error handling errors and controlling their flow
Projects
None yet
Development

No branches or pull requests

2 participants