Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(arbiter-core): simplify Environment::run() #777

Open
Autoparallel opened this issue Jan 5, 2024 · 0 comments
Open

refactor(arbiter-core): simplify Environment::run() #777

Autoparallel opened this issue Jan 5, 2024 · 0 comments
Assignees
@ts0yu
Labels
📦 structural changes refactoring, reorganization, or file structure

Comments

@Autoparallel
Copy link
Collaborator

Autoparallel commented Jan 5, 2024 •
edited
Loading

Idea

The Environment::run() method is really long and hard to work with. It would be better to have the match cases call helper functions and to also consolidate some into cheatcodes where possible.

Solution

Break the logic in the run function match statements into separate functions.
@Autoparallel Autoparallel changed the title refactor(arbiter-core): simplify Environment::run() and event broadcaster refactor(arbiter-core): simplify Environment::run() Jan 23, 2024
@Autoparallel Autoparallel added the 📦 structural changes refactoring, reorganization, or file structure label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ts0yu ts0yu

Labels
📦 structural changes refactoring, reorganization, or file structure
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Autoparallel @ts0yu