Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples broken with last nodeJS canvas versions #46

Open
adadgio opened this issue Jan 9, 2019 · 0 comments
Open

Examples broken with last nodeJS canvas versions #46

adadgio opened this issue Jan 9, 2019 · 0 comments

Comments

@adadgio
Copy link

adadgio commented Jan 9, 2019

I'm just trying the examples here and noticed too problems:

  1. node canvas is not listed as a dependency in the project, i am not sure it should be but it seemed to me that it should (seeing the examples and how the library works).

  2. With latest canvas version (ex. 2.2.0 and above), new Canvas(...blah) is not a constructor and should be used this way: const canvas = Canvas.createCanvas(...blah). Maybe the examples should be updated.

Cheers !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant