Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Field.try_merge should have optional metadata merge #6971

Open
ion-elgreco opened this issue Jan 13, 2025 · 1 comment
Open

Field.try_merge should have optional metadata merge #6971

ion-elgreco opened this issue Jan 13, 2025 · 1 comment
Labels
enhancement Any new improvement worthy of a entry in the changelog

Comments

@ion-elgreco
Copy link

Is your feature request related to a problem or challenge? Please describe what you are trying to do.
Merging fields is useful but the implicit merge of metadata is something that should be opt-in. At the moment we have to undo this to get the required effect.

@ion-elgreco ion-elgreco added the enhancement Any new improvement worthy of a entry in the changelog label Jan 13, 2025
@tustvold
Copy link
Contributor

I wonder if we really just need to provide a visitor API to allow people to define what schema merging logic they desire... We can then implement try_merge using this, and if people want something different they can implement their own visitor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Any new improvement worthy of a entry in the changelog
Projects
None yet
Development

No branches or pull requests

2 participants