Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cmp in fullvalue_test.go #20154

Open
damccorm opened this issue Jun 4, 2022 · 5 comments · May be fixed by #33922
Open

Use cmp in fullvalue_test.go #20154

damccorm opened this issue Jun 4, 2022 · 5 comments · May be fixed by #33922

Comments

@damccorm
Copy link
Contributor

damccorm commented Jun 4, 2022

We could probably update the comparison helpers in fullvalue_test.go to use cmp options and Transformers instead which would make things much clearer.

Imported from Jira BEAM-9753. Original Jira may contain additional context.
Reported by: danoliveira.

@zhenglin-charlie-li
Copy link
Contributor

Hi, I am new to this project and willing to contribute.

Could you tell me more about the details? For example, what are comparison helper, cmp options, and transformers?

I looked up the original Jira but couldn't find any information about what they are. 

@damccorm
Copy link
Contributor Author

The goal here would be to replace or refactor our helpers (for example

func equal(a, b FullValue) bool {
) to use the cmp package rather than traversing the whole object and doing reflection equality checks to compare them.

@thinh2
Copy link

thinh2 commented Aug 15, 2023

Hi, does this issue still open for contribution?

@damccorm
Copy link
Contributor Author

@thinh2 yes, it is!

@mohamedawnallah
Copy link
Contributor

.take-issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants