Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: StateBackedIterable should support lazy observing of element size by extending ElementByteSizeObservableIterable #27283

Closed
1 of 15 tasks
scwhittle opened this issue Jun 28, 2023 · 2 comments · Fixed by #29517

Comments

@scwhittle
Copy link
Contributor

What would you like to happen?

As it does not, Iterables.registerByteObserver triggers element iteration and prefetching/reading. Otherwise byte observing would occur lazily during iteration.

Issue Priority

Priority: 2 (default / most feature requests should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
@scwhittle
Copy link
Contributor Author

.take-issue

@scwhittle scwhittle changed the title [Feature Request]: PrefetchableIterables.Default should support lazy observing of element size via ElementByteSizeObservableIterable [Feature Request]: StateBackedIterable should support lazy observing of element size by extending ElementByteSizeObservableIterable Nov 17, 2023
@scwhittle
Copy link
Contributor Author

Renaming to reflect the end goal. I was looking into doing this at the Prefetchables level but it was difficult given overridden methods having colliding types for ElementByteSizeObservableIterable and PrefectIterable.

Planning instead of just fixing up StateBackedIterable and possibly exposing a generic way to wrap an iterable to make it cheap to byte size observe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment