Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Missing Type Implementations in parseDefaultExpression for ClickHouseIO #33692

Open
1 of 17 tasks
BentsiLeviav opened this issue Jan 21, 2025 · 0 comments
Open
1 of 17 tasks

Comments

@BentsiLeviav
Copy link

What happened?

The parseDefaultExpression function is missing implementations for the following ClickHouse types:

  • DateTime
  • Array
  • Tuple
  • Float32
  • Float64
    This omission results in errors or unhandled cases when attempting to parse default expressions for these types.

Suggested Improvement:

Generalize the parseDefaultExpression function to handle any string-based conversion into the appropriate Java representation that ClickHouse expects. This would make the function more robust and capable of supporting future type additions without requiring frequent updates.

Steps to Reproduce:

Call the parseDefaultExpression function with a value and a column type that matches any of the unsupported types listed above.
Observe that the function either fails or returns an incorrect result.

Issue Priority

Priority: 2 (default / most bugs should be filed as P2)

Issue Components

  • Component: Python SDK
  • Component: Java SDK
  • Component: Go SDK
  • Component: Typescript SDK
  • Component: IO connector
  • Component: Beam YAML
  • Component: Beam examples
  • Component: Beam playground
  • Component: Beam katas
  • Component: Website
  • Component: Infrastructure
  • Component: Spark Runner
  • Component: Flink Runner
  • Component: Samza Runner
  • Component: Twister2 Runner
  • Component: Hazelcast Jet Runner
  • Component: Google Cloud Dataflow Runner
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant