-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Go SDK] Add missing type inspection case for Alias types. #34039
Conversation
R: @jrmccluskey |
Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks! Will merge once the checks are done. |
Hi Robert,
I am a developer who use Apache beam to develop data flow based on GCP, I meet a issue related with beam Python SDK, I am not sure you are right person or not.
Unable to perform SDK-split for work-id: 7799826652429916392 due to error: INTERNAL: Empty split returned. [type.googleapis.com/util.MessageSetPayload='[dist_proc.dax.internal.TrailProto] { trail_point { source_file_loc { filepath: "dist_proc/dax/workflow/worker/fnapi_operators.cc" line: 2948 } } }'] === Source Location Trace: === dist_proc/dax/internal/status_utils.cc:235 And could not Checkpoint reader due to error: OUT_OF_RANGE: Cannot checkpoint when range tracker is finished. [type.googleapis.com/util.MessageSetPayload='[dist_proc.dax.internal.TrailProto] { trail_point { source_file_loc { filepath: "dist_proc/dax/workflow/worker/operator.cc" line: 336 } } }'] === Source Location Trace: === dist_proc/dax/io/dax_reader_driver.cc:259 dist_proc/dax/workflow/worker/operator.cc:336
If you have this kind of experience, could you please help me, thanks.
Best Regards,
LL
C1 - Internal use
…________________________________
From: Robert Burke ***@***.***>
Sent: 21 February 2025 01:53
To: apache/beam ***@***.***>
Cc: Subscribed ***@***.***>
Subject: [apache/beam] [Go SDK] Add missing type inspection case for Alias types. (PR #34039)
EXTERNAL EMAIL: BE VIGILANT
Adds a missing line when handling alias types. It's important to also register types and imports even if that type is an alias, so, the generated files won't drop the types. Necessary for support on Go 1.24+, when the register package isn't being used.
________________________________
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
* Mention the appropriate issue in your description (for example: addresses #123), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment fixes #<ISSUE NUMBER> instead.
* Update CHANGES.md with noteworthy changes.
* If this contribution is large, please file an Apache Individual Contributor License Agreement<https://urldefense.com/v3/__https://www.apache.org/licenses/icla.pdf__;!!IY5JXqZAIQ!9719sieagK4u2Jy3grr6aoslFTcDCialHIXd3JDS52cz06_8tb9frGpXZUgPXPWtQ86_K4AxQ9EbtXXyoPbXTo2j1iKdWA$>.
See the Contributor Guide<https://urldefense.com/v3/__https://beam.apache.org/contribute__;!!IY5JXqZAIQ!9719sieagK4u2Jy3grr6aoslFTcDCialHIXd3JDS52cz06_8tb9frGpXZUgPXPWtQ86_K4AxQ9EbtXXyoPbXTo1sPWvG2Q$> for more tips on how to make review process smoother<https://urldefense.com/v3/__https://github.com/apache/beam/blob/master/CONTRIBUTING.md*make-the-reviewers-job-easier__;Iw!!IY5JXqZAIQ!9719sieagK4u2Jy3grr6aoslFTcDCialHIXd3JDS52cz06_8tb9frGpXZUgPXPWtQ86_K4AxQ9EbtXXyoPbXTo2IECmQ_Q$>.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md<https://urldefense.com/v3/__https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md__;!!IY5JXqZAIQ!9719sieagK4u2Jy3grr6aoslFTcDCialHIXd3JDS52cz06_8tb9frGpXZUgPXPWtQ86_K4AxQ9EbtXXyoPbXTo37mERnMw$>
GitHub Actions Tests Status (on master branch)
[Build python source distribution and wheels]<https://urldefense.com/v3/__https://github.com/apache/beam/actions?query=workflow*3A*22Build*python*source*distribution*and*wheels*22*branch*3Amaster*event*3Aschedule__;JSUrKysrKyUrJSsl!!IY5JXqZAIQ!9719sieagK4u2Jy3grr6aoslFTcDCialHIXd3JDS52cz06_8tb9frGpXZUgPXPWtQ86_K4AxQ9EbtXXyoPbXTo2oEGcx5w$>
[Python tests]<https://urldefense.com/v3/__https://github.com/apache/beam/actions?query=workflow*3A*22Python*Tests*22*branch*3Amaster*event*3Aschedule__;JSUrJSslKyU!!IY5JXqZAIQ!9719sieagK4u2Jy3grr6aoslFTcDCialHIXd3JDS52cz06_8tb9frGpXZUgPXPWtQ86_K4AxQ9EbtXXyoPbXTo2wW9vHnA$>
[Java tests]<https://urldefense.com/v3/__https://github.com/apache/beam/actions?query=workflow*3A*22Java*Tests*22*branch*3Amaster*event*3Aschedule__;JSUrJSslKyU!!IY5JXqZAIQ!9719sieagK4u2Jy3grr6aoslFTcDCialHIXd3JDS52cz06_8tb9frGpXZUgPXPWtQ86_K4AxQ9EbtXXyoPbXTo3v7gQUTA$>
[Go tests]<https://urldefense.com/v3/__https://github.com/apache/beam/actions?query=workflow*3A*22Go*tests*22*branch*3Amaster*event*3Aschedule__;JSUrJSslKyU!!IY5JXqZAIQ!9719sieagK4u2Jy3grr6aoslFTcDCialHIXd3JDS52cz06_8tb9frGpXZUgPXPWtQ86_K4AxQ9EbtXXyoPbXTo0N9RL1pg$>
See CI.md<https://urldefense.com/v3/__https://github.com/apache/beam/blob/master/CI.md__;!!IY5JXqZAIQ!9719sieagK4u2Jy3grr6aoslFTcDCialHIXd3JDS52cz06_8tb9frGpXZUgPXPWtQ86_K4AxQ9EbtXXyoPbXTo24MxEJdA$> for more information about GitHub Actions CI or the workflows README<https://urldefense.com/v3/__https://github.com/apache/beam/blob/master/.github/workflows/README.md__;!!IY5JXqZAIQ!9719sieagK4u2Jy3grr6aoslFTcDCialHIXd3JDS52cz06_8tb9frGpXZUgPXPWtQ86_K4AxQ9EbtXXyoPbXTo2GRGSCog$> to see a list of phrases to trigger workflows.
________________________________
You can view, comment on, or merge this pull request online at:
#34039<https://urldefense.com/v3/__https://github.com/apache/beam/pull/34039__;!!IY5JXqZAIQ!9719sieagK4u2Jy3grr6aoslFTcDCialHIXd3JDS52cz06_8tb9frGpXZUgPXPWtQ86_K4AxQ9EbtXXyoPbXTo1MWaTcMw$>
Commit Summary
* c825537<https://urldefense.com/v3/__https://github.com/apache/beam/pull/34039/commits/c825537095b2bc31bb67b7dff0398330990b7693__;!!IY5JXqZAIQ!9719sieagK4u2Jy3grr6aoslFTcDCialHIXd3JDS52cz06_8tb9frGpXZUgPXPWtQ86_K4AxQ9EbtXXyoPbXTo16C4uM1g$> Add missing type inspection case for Alias types.
File Changes
(1 file<https://urldefense.com/v3/__https://github.com/apache/beam/pull/34039/files__;!!IY5JXqZAIQ!9719sieagK4u2Jy3grr6aoslFTcDCialHIXd3JDS52cz06_8tb9frGpXZUgPXPWtQ86_K4AxQ9EbtXXyoPbXTo3n1aLHXQ$>)
* M sdks/go/pkg/beam/util/starcgenx/starcgenx.go<https://urldefense.com/v3/__https://github.com/apache/beam/pull/34039/files*diff-7f5af5fef5f88600063bd47cfb204eb0d85cec16e640068529656e9be37ef4e9__;Iw!!IY5JXqZAIQ!9719sieagK4u2Jy3grr6aoslFTcDCialHIXd3JDS52cz06_8tb9frGpXZUgPXPWtQ86_K4AxQ9EbtXXyoPbXTo23e4g96Q$> (1)
Patch Links:
* #34039.patch<https://urldefense.com/v3/__https://github.com/apache/beam/pull/34039.patch__;!!IY5JXqZAIQ!9719sieagK4u2Jy3grr6aoslFTcDCialHIXd3JDS52cz06_8tb9frGpXZUgPXPWtQ86_K4AxQ9EbtXXyoPbXTo3y294PGw$>
* #34039.diff<https://urldefense.com/v3/__https://github.com/apache/beam/pull/34039.diff__;!!IY5JXqZAIQ!9719sieagK4u2Jy3grr6aoslFTcDCialHIXd3JDS52cz06_8tb9frGpXZUgPXPWtQ86_K4AxQ9EbtXXyoPbXTo1qu_p1Ow$>
—
Reply to this email directly, view it on GitHub<https://urldefense.com/v3/__https://github.com/apache/beam/pull/34039__;!!IY5JXqZAIQ!9719sieagK4u2Jy3grr6aoslFTcDCialHIXd3JDS52cz06_8tb9frGpXZUgPXPWtQ86_K4AxQ9EbtXXyoPbXTo1MWaTcMw$>, or unsubscribe<https://urldefense.com/v3/__https://github.com/notifications/unsubscribe-auth/BCGVMWIFI7PLOFUQ764EZBL2QYJDHAVCNFSM6AAAAABXRMC5CKVHI2DSMVQWIX3LMV43ASLTON2WKOZSHA3DMOBYG4ZDAMI__;!!IY5JXqZAIQ!9719sieagK4u2Jy3grr6aoslFTcDCialHIXd3JDS52cz06_8tb9frGpXZUgPXPWtQ86_K4AxQ9EbtXXyoPbXTo1Ki1fGfw$>.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
This message and any attachments are confidential and intended solely for the addressees.
If you receive this message in error, please delete it and immediately notify the sender. If the reader of this message is not the intended recipient, you are hereby notified that any unauthorized use, copying or dissemination is prohibited. E-mails are susceptible to alteration. Neither LOREAL nor any of its subsidiaries or affiliates shall be liable for the message if altered, changed or falsified.
|
@lianliangzhang I'm not the right person for this these days. You should either file a support issue with Google Cloud Dataflow (which is where those messages are coming from), or email [email protected] to get the right people's attention. In the absolute last case, you should file a GitHub issue here. Generally do not jump on unrelated PRs. |
Adds a missing line when handling alias types. It's important to also register types and imports even if that type is an alias, so, the generated files won't drop the types. Necessary for support on Go 1.24+, when the
register
package isn't being used.Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
addresses #123
), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, commentfixes #<ISSUE NUMBER>
instead.CHANGES.md
with noteworthy changes.See the Contributor Guide for more tips on how to make review process smoother.
To check the build health, please visit https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md
GitHub Actions Tests Status (on master branch)
See CI.md for more information about GitHub Actions CI or the workflows README to see a list of phrases to trigger workflows.