Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] preparestmt not support sql_cache #46008

Open
3 tasks done
justfortaste opened this issue Dec 26, 2024 · 1 comment · May be fixed by #46011
Open
3 tasks done

[Bug] preparestmt not support sql_cache #46008

justfortaste opened this issue Dec 26, 2024 · 1 comment · May be fixed by #46011

Comments

@justfortaste
Copy link
Contributor

justfortaste commented Dec 26, 2024

Search before asking

  • I had searched in the issues and found no similar issues.

Version

2.1

What's Wrong?

perpare stmt support sql_cache in 2.0

after these pr in 2.1, perpare stmt not support sql_cache
#45640
#33262

What You Expected?

perpare stmt support sql_cache in 2.1+

How to Reproduce?

run prepare_stmt_with_sql_cache.groovy in debug mode and check "hit cache" if exist in fe.log

Anything Else?

No response

Are you willing to submit PR?

  • Yes I am willing to submit a PR!

Code of Conduct

@justfortaste justfortaste linked a pull request Dec 26, 2024 that will close this issue
16 tasks
@924060929
Copy link
Contributor

924060929 commented Jan 3, 2025

This feature requires more consideration, the prepareStatement should set the originStatement after replace the placeholder to literal, and then use NereidsSqlCacheManager.tryParseSql to fetch the cache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants