diff --git a/.asf.yaml b/.asf.yaml index 734b2b573867..25daa6337c91 100644 --- a/.asf.yaml +++ b/.asf.yaml @@ -37,9 +37,6 @@ github: strict: false # contexts are the names of checks that must pass contexts: - - concourse-ci/api-check-test-openjdk11 - - concourse-ci/build - - concourse-ci/unit-test-openjdk11 - "Analyze (java)" - "Analyze (javascript)" - "Analyze (python)" @@ -48,7 +45,7 @@ github: required_pull_request_reviews: dismiss_stale_reviews: false - require_code_owner_reviews: true + require_code_owner_reviews: false required_approving_review_count: 1 required_signatures: false diff --git a/CODEOWNERS b/CODEOWNERS deleted file mode 100644 index 092d63324731..000000000000 --- a/CODEOWNERS +++ /dev/null @@ -1,317 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - -#----------------------------------------------------------------- -# CODEOWNERS and .asf.yml - ownerless so everyone "owns" it -#----------------------------------------------------------------- -#CODEOWNERS -#.asf.yaml - -#----------------------------------------------------------------- -# Serialization -#----------------------------------------------------------------- -geode-serialization/** @echobravopapa @Bill @kirklund @kamilla1201 @jchen21 @pivotal-jbarrett -geode-serialization/**/internal/serialization/filter/* @kirklund @jchen21 -geode-core/**/org/apache/geode/pdx/** @upthewaterspout @dschneider-pivotal @agingade @pivotal-jbarrett -geode-core/**/org/apache/geode/codeAnalysis/** @upthewaterspout @dschneider-pivotal @agingade @kirklund -geode-core/**/org/apache/geode/internal/* @echobravopapa @Bill @kirklund @kamilla1201 @pivotal-jbarrett -geode-core/**/META-INF/**/*SanctionedSerializablesService @kirklund @jchen21 - -#----------------------------------------------------------------- -# Membership -#----------------------------------------------------------------- -geode-membership/** @echobravopapa @Bill @kamilla1201 @pivotal-jbarrett -geode-old-client-support/** @echobravopapa @Bill @kamilla1201 @pivotal-jbarrett -geode-tcp-server/** @echobravopapa @Bill @kamilla1201 @pivotal-jbarrett -geode-core/**/org/apache/geode/distributed/internal/membership/** @echobravopapa @Bill @kamilla1201 @pivotal-jbarrett - -#----------------------------------------------------------------- -# P2P Messaging -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/internal/tcp/** @echobravopapa @Bill @kamilla1201 @pivotal-jbarrett -geode-core/**/org/apache/geode/distributed/internal/direct/** @echobravopapa @Bill @kamilla1201 @pivotal-jbarrett -geode-core/**/org/apache/geode/internal/net/** @echobravopapa @Bill @kamilla1201 @pivotal-jbarrett -geode-core/**/org/apache/geode/net/** @Bill @mivanac @kamilla1201 @pivotal-jbarrett -geode-core/**/org/apache/geode/distributed/* @echobravopapa @Bill @kirklund @kamilla1201 @pivotal-jbarrett -geode-core/**/org/apache/geode/distributed/internal/* @echobravopapa @Bill @kirklund @kamilla1201 @pivotal-jbarrett - -#----------------------------------------------------------------- -# Client/server messaging and cache operations -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/cache/client/** @echobravopapa @Bill @kamilla1201 @pivotal-jbarrett -geode-core/**/org/apache/geode/cache/server/** @echobravopapa @Bill @kamilla1201 @pivotal-jbarrett -geode-core/**/org/apache/geode/cache/client/internal/** @Bill @echobravopapa @kamilla1201 @pivotal-jbarrett -geode-core/**/org/apache/geode/internal/cache/tier/** @Bill @echobravopapa @agingade @kamilla1201 @pivotal-jbarrett -geode-assembly/**/apache/geode/client/sni/** @Bill @echobravopapa @kamilla1201 @pivotal-jbarrett - -#----------------------------------------------------------------- -# Client Queues -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/internal/cache/ha/** @agingade @boglesby @nabarunnag -geode-core/**/org/apache/geode/internal/cache/**/CacheClient* @agingade @boglesby @nabarunnag - -#----------------------------------------------------------------- -# Core Public API packages - Cache, Region, etc. -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/* @dschneider-pivotal @boglesby @nabarunnag @pivotal-jbarrett -geode-core/**/org/apache/geode/cache/* @dschneider-pivotal @boglesby @nabarunnag @pivotal-jbarrett -geode-core/**/org/apache/geode/cache/util/** @dschneider-pivotal @boglesby @nabarunnag @pivotal-jbarrett - -#----------------------------------------------------------------- -# Distributed Locks -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/distributed/internal/locks/** @dschneider-pivotal @pivotal-eshu @kirklund -geode-core/**/org/apache/geode/distributed/internal/deadlock/** @dschneider-pivotal @pivotal-eshu @kirklund - -#----------------------------------------------------------------- -# Core region implementations and plumbing -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/internal/cache/* @nabarunnag @DonalEvans @jchen21 - -#----------------------------------------------------------------- -# Region entry management -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/internal/cache/entries/** @dschneider-pivotal @upthewaterspout -geode-core/**/org/apache/geode/internal/cache/region/entry/** @dschneider-pivotal @upthewaterspout -geode-core/**/org/apache/geode/internal/cache/map/** @dschneider-pivotal @upthewaterspout -geode-core/**/org/apache/geode/compression/** @dschneider-pivotal @kirklund -geode-core/**/org/apache/geode/internal/cache/compression/** @dschneider-pivotal @kirklund - -#----------------------------------------------------------------- -# Partitioned Regions -#----------------------------------------------------------------- -geode-rebalancer/** @boglesby @BenjaminPerryRoss @nabarunnag -geode-core/**/org/apache/geode/internal/cache/partitioned/** @boglesby @BenjaminPerryRoss @nabarunnag -geode-core/**/org/apache/geode/cache/partition/** @boglesby @BenjaminPerryRoss @nabarunnag - -#----------------------------------------------------------------- -# Event tracking -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/internal/cache/event/** @agingade @nabarunnag @gesterzhou - -#----------------------------------------------------------------- -# Eviction -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/internal/cache/eviction/** @agingade @dschneider-pivotal -geode-core/**/org/apache/geode/internal/size/** @agingade @dschneider-pivotal @kirklund - -#----------------------------------------------------------------- -# Offheap -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/internal/offheap/** @pivotal-eshu @dschneider-pivotal @kirklund - -#----------------------------------------------------------------- -# Transactions -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/internal/cache/tx/** @pivotal-eshu @gesterzhou -geode-core/**/org/apache/geode/internal/jta/** @pivotal-eshu @gesterzhou -geode-core/**/org/apache/geode/internal/cache/locks/** @pivotal-eshu @gesterzhou - -#----------------------------------------------------------------- -# Function Execution -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/internal/cache/execute/** @boglesby @nabarunnag @pivotal-jbarrett -geode-core/**/org/apache/geode/cache/execute/** @boglesby @nabarunnag @pivotal-jbarrett - -#----------------------------------------------------------------- -# Querying -#----------------------------------------------------------------- -geode-cq/** @nabarunnag @DonalEvans @agingade -geode-core/**/org/apache/geode/cache/query/** @nabarunnag @DonalEvans @agingade - -#----------------------------------------------------------------- -# Session State: -#----------------------------------------------------------------- -extensions/** @jdeppe-pivotal @BenjaminPerryRoss @pivotal-jbarrett -geode-core/**/org/apache/geode/internal/modules/util/** @jdeppe-pivotal @BenjaminPerryRoss @pivotal-jbarrett -geode-assembly/**/org/apache/geode/session/** @jdeppe-pivotal @BenjaminPerryRoss @pivotal-jbarrett - -#----------------------------------------------------------------- -# DEV rest API -#----------------------------------------------------------------- -geode-web-api/** @jdeppe-pivotal @jinmeiliao -geode-assembly/**/org/apache/geode/rest/** @jdeppe-pivotal @jinmeiliao - -#----------------------------------------------------------------- -# Lucene integration -#----------------------------------------------------------------- -geode-lucene/** @nabarunnag @DonalEvans - -#----------------------------------------------------------------- -# Memcached integration -#----------------------------------------------------------------- -geode-memcached/** @nabarunnag @DonalEvans - -#----------------------------------------------------------------- -# Misc Utilities -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/internal/util/** @nabarunnag @boglesby @kirklund @pivotal-jbarrett -geode-core/**/org/apache/geode/internal/util/concurrent/** @nabarunnag @boglesby @kirklund @pivotal-jbarrett -geode-core/**/org/apache/geode/internal/shared/** @nabarunnag @boglesby @kirklund @pivotal-jbarrett -geode-core/**/org/apache/geode/internal/sequencelog/** @nabarunnag @boglesby @pivotal-jbarrett -geode-core/**/org/apache/geode/internal/concurrent/** @nabarunnag @boglesby @pivotal-jbarrett -geode-core/**/org/apache/geode/distributed/internal/unsafe/** @nabarunnag @boglesby @pivotal-jbarrett -geode-core/**/org/apache/geode/internal/lang/** @nabarunnag @boglesby @kirklund @pivotal-jbarrett -geode-core/**/org/apache/geode/internal/monitoring/** @nabarunnag @boglesby @pivotal-jbarrett -geode-core/**/org/apache/geode/internal/exception/** @nabarunnag @boglesby @pivotal-jbarrett -geode-core/**/org/apache/geode/lang/** @nabarunnag @boglesby @kirklund @pivotal-jbarrett -geode-core/**/org/apache/geode/ra/** @nabarunnag @boglesby @pivotal-jbarrett -geode-core/**/org/apache/geode/internal/cache/vmotion/** @nabarunnag @boglesby @pivotal-jbarrett -geode-core/**/org/apache/geode/internal/jndi/** @nabarunnag @boglesby @pivotal-jbarrett -geode-common/** @nabarunnag @boglesby @kirklund @pivotal-jbarrett -geode-unsafe/** @nabarunnag @boglesby @kirklund @pivotal-jbarrett - -#----------------------------------------------------------------- -# Persistence -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/cache/persistence/** @dschneider-pivotal @jchen21 @upthewaterspout @gesterzhou -geode-core/**/org/apache/geode/internal/cache/persistence/** @dschneider-pivotal @jchen21 @upthewaterspout @gesterzhou -geode-core/**/org/apache/geode/internal/cache/backup/** @dschneider-pivotal @agingade @jchen21 @upthewaterspout @gesterzhou -geode-assembly/**/org/apache/geode/cache/persistence/** @dschneider-pivotal @jchen21 @upthewaterspout @gesterzhou - -#----------------------------------------------------------------- -# Region Version Vectors - used for sychronization on -# member failures and persistent recovery -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/internal/cache/versions/** @dschneider-pivotal @gesterzhou - -#----------------------------------------------------------------- -# WAN messaging and queues -#----------------------------------------------------------------- -geode-wan/** @gesterzhou @boglesby @nabarunnag @pivotal-jbarrett -geode-core/**/org/apache/geode/cache/asyncqueue/** @gesterzhou @boglesby @nabarunnag @pivotal-jbarrett -geode-core/**/org/apache/geode/cache/wan/** @gesterzhou @boglesby @nabarunnag @pivotal-jbarrett -geode-core/**/org/apache/geode/internal/cache/wan/** @gesterzhou @boglesby @nabarunnag @pivotal-jbarrett -geode-assembly/**/apache/geode/cache/wan/** @gesterzhou @boglesby @nabarunnag @pivotal-jbarrett - -#----------------------------------------------------------------- -# Management -#----------------------------------------------------------------- -geode-management/** @jdeppe-pivotal @jinmeiliao -geode-assembly/**/org/apache/geode/management/** @jdeppe-pivotal @jinmeiliao -geode-assembly/**/org/apache/geode/tools/pulse/** @jdeppe-pivotal @jinmeiliao -geode-web-management/** @jdeppe-pivotal @jinmeiliao -geode-gfsh/** @jdeppe-pivotal @jinmeiliao -geode-assembly/**/bin/** @jdeppe-pivotal @jinmeiliao @kirklund -geode-pulse/** @jdeppe-pivotal @jinmeiliao -geode-http-service/** @jdeppe-pivotal @jinmeiliao -geode-web/** @jdeppe-pivotal @jinmeiliao -geode-core/**/org/apache/geode/admin/** @jdeppe-pivotal @jinmeiliao @kirklund -geode-core/**/org/apache/geode/alerting/** @jdeppe-pivotal @jinmeiliao @kirklund -geode-core/**/org/apache/geode/management/** @jdeppe-pivotal @jinmeiliao -geode-core/**/org/apache/geode/cache/configuration/** @jdeppe-pivotal @jinmeiliao -geode-core/**/org/apache/geode/internal/admin/** @jdeppe-pivotal @jinmeiliao @kirklund -geode-core/**/org/apache/geode/internal/cache/xmlcache/** @jdeppe-pivotal @jinmeiliao -geode-core/**/org/apache/geode/internal/cache/extension/** @jdeppe-pivotal @jinmeiliao -geode-core/**/org/apache/geode/internal/config/** @jdeppe-pivotal @jinmeiliao -geode-core/**/org/apache/geode/internal/process/** @jdeppe-pivotal @jinmeiliao @kirklund -geode-core/**/org/apache/geode/cache/internal/* @jdeppe-pivotal @jinmeiliao - -#----------------------------------------------------------------- -# Security -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/examples/** @jdeppe-pivotal @jinmeiliao @pivotal-jbarrett -geode-core/**/org/apache/geode/examples/security/** @jdeppe-pivotal @jinmeiliao @pivotal-jbarrett -geode-core/**/org/apache/geode/security/** @jdeppe-pivotal @jinmeiliao @kirklund @pivotal-jbarrett -geode-core/**/org/apache/geode/internal/security/** @jdeppe-pivotal @jinmeiliao @kirklund @pivotal-jbarrett -geode-core/**/org/apache/geode/cache/operations/** @jdeppe-pivotal @jinmeiliao @pivotal-jbarrett -geode-core/**/org/apache/geode/internal/cache/operations/** @jdeppe-pivotal @jinmeiliao @pivotal-jbarrett -geode-assembly/**/apache/geode/ssl/** @jdeppe-pivotal @jinmeiliao @pivotal-jbarrett - -#----------------------------------------------------------------- -# Logging -#----------------------------------------------------------------- -geode-log4j/** @kirklund @gesterzhou -geode-logging/** @kirklund @gesterzhou -geode-core/**/org/apache/geode/logging/** @kirklund @gesterzhou -geode-core/**/org/apache/geode/internal/logging/** @kirklund @gesterzhou -geode-core/**/org/apache/geode/i18n/** @agingade @kirklund -geode-core/**/org/apache/geode/internal/i18n/** @agingade @kirklund -geode-core/**/org/apache/geode/internal/io/** @agingade @kirklund -geode-assembly/**/org/apache/geode/logging/** @agingade @kirklund - -#----------------------------------------------------------------- -# Metrics & Statistics -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/internal/statistics/** @kirklund @pivotal-jbarrett -geode-core/**/org/apache/geode/internal/stats50/** @kirklund @pivotal-jbarrett -geode-core/**/org/apache/geode/metrics/** @kirklund @pivotal-jbarrett -geode-assembly/**/org/apache/geode/metrics/** @kirklund @pivotal-jbarrett - -#----------------------------------------------------------------- -# Region Snapshots -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/cache/snapshot/** @agingade @jchen21 -geode-core/**/org/apache/geode/internal/cache/snapshot/** @agingade @jchen21 - -#----------------------------------------------------------------- -# JDBC connector -#----------------------------------------------------------------- -geode-connectors/** @agingade @jchen21 -geode-core/**/org/apache/geode/datasource/** @agingade @BenjaminPerryRoss @jchen21 -geode-core/**/org/apache/geode/internal/datasource/** @agingade @BenjaminPerryRoss @jchen21 - -#----------------------------------------------------------------- -# Resource manager -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/cache/control/** @kirklund @DonalEvans -geode-core/**/org/apache/geode/internal/cache/control/** @kirklund @DonalEvans - -#----------------------------------------------------------------- -# Testing utilities -#----------------------------------------------------------------- -#geode-concurrency-test/** -geode-dunit/** @kirklund @demery-pivotal @dschneider-pivotal -geode-junit/** @kirklund @demery-pivotal @dschneider-pivotal -geode-jmh/** @pivotal-jbarrett -geode-junit/**/org/apache/geode/test/util/** @jdeppe-pivotal @kirklund -geode-assembly/**/org/apache/geode/test/junit/** @jdeppe-pivotal @jinmeiliao -geode-assembly/**/org/apache/geode/rules/** @jdeppe-pivotal @jinmeiliao -geode-assembly/**/org/apache/geode/launchers/** @dschneider-pivotal @boglesby @nabarunnag -geode-assembly/**/resources/** @boglesby @nabarunnag @jdeppe-pivotal @jinmeiliao - -#----------------------------------------------------------------- -# Build and tooling -#----------------------------------------------------------------- -#etc/** -*gradle* @rhoughton-pivot @upthewaterspout -build-tools/** @rhoughton-pivot @jdeppe-pivotal -DependencyConstraints.groovy @dickcav @rhoughton-pivot -ci/** @dickcav @rhoughton-pivot @smgoller -ci/scripts/** @dickcav @rhoughton-pivot @smgoller -ci/scripts/repeat-new-tests.sh @dickcav @rhoughton-pivot @smgoller @upthewaterspout @jdeppe-pivotal -dev-tools/dependencies/** @dickcav @onichols-pivotal -dev-tools/release/** @dickcav @onichols-pivotal -docker/** @dickcav @smgoller -geode-management/src/test/script/update-management-wiki.sh @dickcav @onichols-pivotal -#boms/** -static-analysis/** @rhoughton-pivot @upthewaterspout -geode-old-versions/** @dickcav @rhoughton-pivot -KEYS @dickcav @upthewaterspout @pivotal-amurmann -assembly_content.txt @dickcav @rhoughton-pivot -dependency_classpath.txt @dickcav @rhoughton-pivot -expected-pom.xml @dickcav @rhoughton-pivot - -#----------------------------------------------------------------- -# Documentation -#----------------------------------------------------------------- -apache-copyright-notice.txt @upthewaterspout @pivotal-amurmann -BUILDING.md @rhoughton-pivot @upthewaterspout -CODE_OF_CONDUCT.md @upthewaterspout @pivotal-amurmann @nonbinaryprogrammer -LICENSE @dickcav @onichols-pivotal -NOTICE @dickcav @onichols-pivotal -/README.md @upthewaterspout @pivotal-amurmann @kirklund -#TESTING.md diff --git a/CODEWATCHERS b/CODEWATCHERS deleted file mode 100644 index ae1c8fc6962e..000000000000 --- a/CODEWATCHERS +++ /dev/null @@ -1,83 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - - -# This file follows the same format as CODEOWNERS, but adds you as -# an optional reviewer rather than a required code owner reviewer. -# Draft PRs are ignored until ~15 minutes after Ready For Review. -# CODEWATCHERS is a bot; the bot owner will appear as the requestor. -# You must be a Geode committer to use CODEWATCHERS. - - -#----------------------------------------------------------------- -# CODEOWNERS and .asf.yml -#----------------------------------------------------------------- -CODEOWNERS @onichols-pivotal @rhoughton-pivot -CODEWATCHERS @onichols-pivotal @rhoughton-pivot -COMMITWATCHERS @onichols-pivotal -.asf.yaml @onichols-pivotal @rhoughton-pivot - - -#----------------------------------------------------------------- -# Documentation -#----------------------------------------------------------------- -geode-book/** @davebarnes97 -geode-docs/** @davebarnes97 -geode-book/config.yml @onichols-pivotal -geode-book/redirects.rb @onichols-pivotal -LICENSE @metatype -NOTICE @metatype - -#----------------------------------------------------------------- -# Jar Deployment -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/**/classloader/** @kohlmu-pivotal -geode-core/**/org/apache/geode/**/deployment/** @kohlmu-pivotal -geode-deployment/** @kohlmu-pivotal -geode-core/**/org/apache/geode/cache/internal/execute/* @kohlmu-pivotal - -#----------------------------------------------------------------- -# Client/server messaging and cache operations -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/cache/client/** @albertogpz -geode-core/**/org/apache/geode/cache/server/** @albertogpz -geode-core/**/org/apache/geode/internal/cache/tier/** @albertogpz - -#----------------------------------------------------------------- -# WAN messaging and queues -#----------------------------------------------------------------- -geode-wan/** @albertogpz -geode-core/**/org/apache/geode/cache/asyncqueue/** @albertogpz -geode-core/**/org/apache/geode/cache/wan/** @albertogpz -geode-core/**/org/apache/geode/internal/cache/wan/** @albertogpz - -#----------------------------------------------------------------- -# Metrics & Statistics -#----------------------------------------------------------------- -geode-core/**/org/apache/geode/internal/statistics/** @mkevo -geode-core/**/org/apache/geode/internal/stats50/** @mkevo -geode-core/**/org/apache/geode/metrics/** @mkevo - -#----------------------------------------------------------------- -# Querying -#----------------------------------------------------------------- -geode-cq/** @mkevo -geode-core/**/org/apache/geode/cache/query/** @mkevo - -#----------------------------------------------------------------- -# Build and tooling -#----------------------------------------------------------------- -dev-tools/progress/** @demery-pivotal diff --git a/COMMITWATCHERS b/COMMITWATCHERS deleted file mode 100644 index 1dc898c2ac5c..000000000000 --- a/COMMITWATCHERS +++ /dev/null @@ -1,66 +0,0 @@ -# Licensed to the Apache Software Foundation (ASF) under one -# or more contributor license agreements. See the NOTICE file -# distributed with this work for additional information -# regarding copyright ownership. The ASF licenses this file -# to you under the Apache License, Version 2.0 (the -# "License"); you may not use this file except in compliance -# with the License. You may obtain a copy of the License at -# -# http://www.apache.org/licenses/LICENSE-2.0 -# -# Unless required by applicable law or agreed to in writing, software -# distributed under the License is distributed on an "AS IS" BASIS, -# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. -# See the License for the specific language governing permissions and -# limitations under the License. - - -# Add your github username to one or both sections below to opt-in for -# automated feedback on your commit message. - -[Draft] -ezoerner - -[Non-Draft] -kirklund -ezoerner -kohlmu-pivotal - - -# By opting-in, the commit message of the first commit in your PR will -# be compared to the guidelines in -# https://cwiki.apache.org/confluence/display/GEODE/Commit+Message+Format -# and a comment will be added to your PR if improvements are recommended. -# -# Please note that these guidelines are totally optional. What matters -# most is not formatting, but including enough detail for future -# contributors to understand what you changed and why. -# -# Q. Why is this opt-in? Wouldn't this be good feedback for all PRs? -# A. The Geode community embraces diversity of opinions. Rather than -# rules, "we like to work on trust, not unnecessary restrictions". -# -# Q. Why is only my first commit message inspected? -# A. Because it is most likely to be used as the actual commit message -# or the start of the squash commit message when your PR is merged. -# -# Q. Isn't this redundant with the PR title and description in github? -# A. It can be; some contributors copy&paste their commit message -# there as well. Or you can use that space for notes to reviewers, -# such as how you tested or specific feedback you'd like. -# -# Q. How do I push changes to my commit message? -# A. Using interactive rebase (git rebase -i HEAD~n, where n is the -# number of commits in your PR so far), change "pick" to "r" to -# reword the first commit, then git push --force. -# -# Q. Will a force push mess up reviews I've already received? -# A. Yes. Opt-in your draft PRs too to get feedback (and have a chance -# to make fixes) prior to marking your PR as ready for review. -# -# Q. Can I just write or fix my commit message when I merge my PR? -# A. If you're a committer and if you remember to, sure, although this -# will deprive you of review feedback on your actual commit message. -# -# Q. Can I update my commit message after my PR is merged? -# A. No, Geode's branch protection disallows force push on develop.