Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move docker-specific tests to integrationTest configuration #12236

Open
3 tasks
nastra opened this issue Feb 12, 2025 · 2 comments · May be fixed by #12274
Open
3 tasks

Move docker-specific tests to integrationTest configuration #12236

nastra opened this issue Feb 12, 2025 · 2 comments · May be fixed by #12274
Labels
good first issue Good for newcomers improvement PR that improves existing functionality

Comments

@nastra
Copy link
Contributor

nastra commented Feb 12, 2025

Feature Request / Improvement

Currently, docker-specific tests run under the test configuration and we'd like to move those to integrationTest. Examples of such tests use the @Testcontainers annotation

Query engine

None

Willingness to contribute

  • I can contribute this improvement/feature independently
  • I would be willing to contribute this improvement/feature with guidance from the Iceberg community
  • I cannot contribute this improvement/feature at this time
@nastra nastra added good first issue Good for newcomers improvement PR that improves existing functionality labels Feb 12, 2025
@anuragmantri
Copy link
Contributor

anuragmantri commented Feb 14, 2025

I have seen similar issues on Azure tests on some of my environments. I will submit a PR to move these tests to integration tests source sets. Thanks for creating the issue.

@kevinjqliu
Copy link
Contributor

BTW, i ran ./gradlew test --continue without the docker daemon and these are the 9 tests that failed and requires docker.

> Task :iceberg-azure:test
ADLSFileIOTest > initializationError FAILED
ADLSInputStreamTest > initializationError FAILED
ADLSOutputStreamTest > initializationError FAILED

> Task :iceberg-aws:test
TestFlakyS3InputStream > initializationError FAILED
TestMinioUtil > initializationError FAILED
TestS3FileIO > initializationError FAILED
TestS3InputStream > initializationError FAILED
TestS3OutputStream > initializationError FAILED
TestS3RestSigner > initializationError FAILED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers improvement PR that improves existing functionality
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants