Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve] flink job submit improvement #3818

Merged
merged 4 commits into from
Jun 30, 2024
Merged

Conversation

wolfboys
Copy link
Member

@wolfboys wolfboys commented Jun 28, 2024

[Improve] flink job submit improvement

What changes were proposed in this pull request

  1. sync flink-submit-job code from 2.1.4
  2. e2e-test code style improvement

Brief change log

Verifying this change

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

Does this pull request potentially affect one of the following parts

  • Dependencies (does it add or upgrade a dependency): (yes / no)

Copy link
Member

@wangsizhu0504 wangsizhu0504 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wolfboys wolfboys merged commit cb57d06 into apache:dev Jun 30, 2024
30 of 31 checks passed
@wolfboys wolfboys deleted the test-case branch June 30, 2024 04:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants