Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improve][DataProxy] Optimize the related configuration settings in the CommonConfigHolder.java file #10066

Closed
3 tasks done
Tracked by #10080
gosonzhang opened this issue Apr 24, 2024 · 0 comments · Fixed by #10079
Closed
3 tasks done
Tracked by #10080

Comments

@gosonzhang
Copy link
Contributor

gosonzhang commented Apr 24, 2024

Description

After using DataProxy for a while, I found that the definition of configuration-related keys in CommonConfigHolder.java is not very reasonable. Some names are mixed with upper and lower case, some are in camel case, and some keys belong to the same type of operation but are not categorized by name, etc. In terms of configuration settings, some configurations are too complex, making it inconvenient for users.

These issues are not user-friendly and hinder the user experience. I plan to optimize the configuration definition based on my usage experience, adjusting it according to the categories and themes of usage, such as unifying lowercase, separating key names with ".", allowing users to quickly understand which type of configuration definition it is based on the name.

However, I also noticed that some of the configuration definitions and usage in this class are not settings of the DataProxy node itself but are defined by common components. These parts should not be modified but should be adjusted at a higher level.

InLong Component

InLong DataProxy

Are you willing to submit PR?

  • Yes, I am willing to submit a PR!

Code of Conduct

The sub-issues are as follows:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant