Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[INLONG-11709][SDK] Delete redundant default case in the discoverer of Golang SDK #11710

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[INLONG-11709][SDK] Delete redundant default case in the discoverer of Golang SDK #11710

wants to merge 1 commit into from

Conversation

gunli
Copy link
Contributor

@gunli gunli commented Jan 23, 2025

Fixes #11709

Motivation

Modifications

Verifying this change

(Please pick either of the following options)

  • This change is a trivial rework/code cleanup without any test coverage.

  • This change is already covered by existing tests, such as:
    (please describe tests)

  • This change added tests and can be verified as follows:

    (example:)

    • Added integration tests for end-to-end deployment with large payloads (10MB)
    • Extended integration test for recovery after broker failure

Documentation

  • Does this pull request introduce a new feature? (no)
  • If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
  • If a feature is not applicable for documentation, explain why?
  • If a feature is not documented yet in this PR, please create a follow-up issue for adding the documentation

luchunliang
luchunliang reviewed Jan 23, 2025
View reviewed changes
inlong-sdk/dataproxy-sdk-twins/dataproxy-sdk-golang/dataproxy/discoverer.go
@@ -180,8 +180,6 @@ func (d *dataProxyDiscoverer) update() {
d.lookup()
case <-stopCh:
return
default:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If performance is affected by sleep, would it be better to simply use default: return?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luchunliang luchunliang luchunliang left review comments

@vernedeng vernedeng vernedeng approved these changes

@justinwwhuang justinwwhuang justinwwhuang approved these changes

Assignees
No one assigned
Labels
component/sdk
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Improve][SDK] Delete redundant default case in the discoverer of Golang SDK
4 participants
@gunli @luchunliang @justinwwhuang @vernedeng