From 72e71503394dbf1269560cf373f5ea6186d134db Mon Sep 17 00:00:00 2001
From: WenjunMin <aitozi@apache.org>
Date: Sun, 15 Dec 2024 22:33:17 +0800
Subject: [PATCH] [core] Tolerate the NoSuchObjectException when report the
 partition statistic (#4708)

---
 .../paimon/metastore/MetastoreClient.java     |  3 ++-
 .../flink/sink/partition/HmsReporter.java     |  2 +-
 .../partition/AddDonePartitionActionTest.java |  3 ++-
 .../flink/sink/partition/HmsReporterTest.java |  3 ++-
 .../paimon/hive/HiveMetastoreClient.java      | 27 +++++++++++++------
 5 files changed, 26 insertions(+), 12 deletions(-)

diff --git a/paimon-core/src/main/java/org/apache/paimon/metastore/MetastoreClient.java b/paimon-core/src/main/java/org/apache/paimon/metastore/MetastoreClient.java
index 60e28c59f45d..75f7af5abbdc 100644
--- a/paimon-core/src/main/java/org/apache/paimon/metastore/MetastoreClient.java
+++ b/paimon-core/src/main/java/org/apache/paimon/metastore/MetastoreClient.java
@@ -55,7 +55,8 @@ default void addPartitionsSpec(List<LinkedHashMap<String, String>> partitionSpec
     default void alterPartition(
             LinkedHashMap<String, String> partitionSpec,
             Map<String, String> parameters,
-            long modifyTime)
+            long modifyTime,
+            boolean ignoreIfNotExist)
             throws Exception {
         throw new UnsupportedOperationException();
     }
diff --git a/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/partition/HmsReporter.java b/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/partition/HmsReporter.java
index eb965aa3a318..853dc52c20bf 100644
--- a/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/partition/HmsReporter.java
+++ b/paimon-flink/paimon-flink-common/src/main/java/org/apache/paimon/flink/sink/partition/HmsReporter.java
@@ -93,7 +93,7 @@ public void report(String partition, long modifyTime) throws Exception {
             statistic.put(HIVE_LAST_UPDATE_TIME_PROP, String.valueOf(modifyTime / 1000));
 
             LOG.info("alter partition {} with statistic {}.", partitionSpec, statistic);
-            metastoreClient.alterPartition(partitionSpec, statistic, modifyTime);
+            metastoreClient.alterPartition(partitionSpec, statistic, modifyTime, true);
         }
     }
 
diff --git a/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/sink/partition/AddDonePartitionActionTest.java b/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/sink/partition/AddDonePartitionActionTest.java
index 19c22d137c7f..fca5dcf0ed69 100644
--- a/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/sink/partition/AddDonePartitionActionTest.java
+++ b/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/sink/partition/AddDonePartitionActionTest.java
@@ -66,7 +66,8 @@ public void markDone(LinkedHashMap<String, String> partitionSpec)
                     public void alterPartition(
                             LinkedHashMap<String, String> partitionSpec,
                             Map<String, String> parameters,
-                            long modifyTime)
+                            long modifyTime,
+                            boolean ignoreIfNotExist)
                             throws Exception {
                         throw new UnsupportedOperationException();
                     }
diff --git a/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/sink/partition/HmsReporterTest.java b/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/sink/partition/HmsReporterTest.java
index 0050f3083a8e..f245940da57d 100644
--- a/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/sink/partition/HmsReporterTest.java
+++ b/paimon-flink/paimon-flink-common/src/test/java/org/apache/paimon/flink/sink/partition/HmsReporterTest.java
@@ -117,7 +117,8 @@ public void markDone(LinkedHashMap<String, String> partitionSpec)
                     public void alterPartition(
                             LinkedHashMap<String, String> partitionSpec,
                             Map<String, String> parameters,
-                            long modifyTime)
+                            long modifyTime,
+                            boolean ignoreIfNotExist)
                             throws Exception {
                         partitionParams.put(
                                 PartitionPathUtils.generatePartitionPath(partitionSpec),
diff --git a/paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveMetastoreClient.java b/paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveMetastoreClient.java
index 3793c86f8269..885fa463e5a7 100644
--- a/paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveMetastoreClient.java
+++ b/paimon-hive/paimon-hive-catalog/src/main/java/org/apache/paimon/hive/HiveMetastoreClient.java
@@ -119,17 +119,28 @@ public void addPartitionsSpec(List<LinkedHashMap<String, String>> partitionSpecs
     public void alterPartition(
             LinkedHashMap<String, String> partitionSpec,
             Map<String, String> parameters,
-            long modifyTime)
+            long modifyTime,
+            boolean ignoreIfNotExist)
             throws Exception {
         List<String> partitionValues = new ArrayList<>(partitionSpec.values());
         int currentTime = (int) (modifyTime / 1000);
-        Partition hivePartition =
-                clients.run(
-                        client ->
-                                client.getPartition(
-                                        identifier.getDatabaseName(),
-                                        identifier.getObjectName(),
-                                        partitionValues));
+        Partition hivePartition;
+        try {
+            hivePartition =
+                    clients.run(
+                            client ->
+                                    client.getPartition(
+                                            identifier.getDatabaseName(),
+                                            identifier.getObjectName(),
+                                            partitionValues));
+        } catch (NoSuchObjectException e) {
+            if (ignoreIfNotExist) {
+                return;
+            } else {
+                throw e;
+            }
+        }
+
         hivePartition.setValues(partitionValues);
         hivePartition.setLastAccessTime(currentTime);
         hivePartition.getParameters().putAll(parameters);