[flink] Support the creation of tags based on the latest snapshot #2533
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JingsongLi
reviewed
Dec 20, 2023
|
|
||
| Tuple3<String, String, String> tablePath = getTablePath(params); | ||
| Map<String, String> catalogConfig = optionalConfigMap(params, CATALOG_CONF); | ||
| String tagName = params.get(TAG_NAME); | ||
| long snapshot = Long.parseLong(params.get(SNAPSHOT)); | ||
|
|
||
| long snapshot = -1; |
| @@ -108,7 +108,7 @@ You can create a tag with given name (cannot be number) and snapshot ID. | |||
| --database <database-name> \ | |||
| --table <table-name> \ | |||
| --tag_name <tag-name> \ | |||
| --snapshot <snapshot-id> \ | |||
| [--snapshot <snapshot_id>] \ | |||
There was a problem hiding this comment.
You need to modify Flink and Spark procedure too.
MonsterChenzhuo
force-pushed
the
sp2
branch
4 times, most recently
from
92e19b0 to
051eb89
Compare
|
@JingsongLi PTAL,thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Support the creation of tags based on the latest snapshot.
Tests
API and Format
Documentation