Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

There's no difference between the implementation for the two count functions of GroupedStreamImpl #299

Open
elenacliu opened this issue Jun 26, 2023 · 2 comments
Open

There's no difference between the implementation for the two count functions of GroupedStreamImpl #299

elenacliu opened this issue Jun 26, 2023 · 2 comments

Comments

@elenacliu
Copy link
Contributor

Maybe the second count function of which declaration is public <OUT> GroupedStream<K, Integer> count(SelectAction<OUT, V> selectAction) may do count operation based on whether the key exists or not?
@elenacliu elenacliu changed the title There's no difference between the implementation for the two count function of GroupedStreamImpl There's no difference between the implementation for the two count functions of GroupedStreamImpl Jun 26, 2023
@ni-ze
Copy link
Contributor

ni-ze commented Jun 27, 2023

count(SelectAction<OUT, V> selectAction) is plan to calculate the count of the special key. But the implementation is be forgotten.

can you submit a pr to make it correct?

@elenacliu
Copy link
Contributor Author

count(SelectAction<OUT, V> selectAction) is plan to calculate the count of the special key. But the implementation is be forgotten.

can you submit a pr to make it correct?

sure, I'll do it in the following days.

@ni-ze ni-ze mentioned this issue Aug 11, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ni-ze @elenacliu