-
Notifications
You must be signed in to change notification settings - Fork 814
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Inconsistency in records.yaml IP fields (ipv6 parsing) #11900
Comments
This is not ATS but rather how YAML works. if we use special characters like the colon(which is an indicator character) inside a value, then it may need quotes, otherwise the YAML parser will fail as per specs. I think we should wrap the string if we use special characters in it. Not sure if you have any other ideas? |
well I get that but thats why I found the inconsistency odd. Because the outgoing_ip_to_bind field ats/yamlcpp did not complain when that field was set with ip_to_bind: ipv4_addr ipv6_addr That is what led me to believe there is inconsistent parsing behavior going on. I have no issues quote wrapping and it makes sense, but the inconsistent behavior between 2 fields with ipv6 addresses in them had me wondering |
it's the same, no inconsistency I think. You can assign the same ipv6 to Do you have an example where the behave diffently? |
so here's my example (just using IP's for one of my VMs running 10):
Error: Error: Error parsing /opt/ats10/etc/trafficserver/records.yaml. yaml-cpp: error at line 217, column 17: bad conversion Like 217 is just the local_ipv6 field. Now if I wrap the local_ipv6 address in quotes it will no longer error out. However that does not explain how the outgoing_ip_to_bind is apparently parsed correctly having a non-quoted ipv6 string. Thats the inconsistency I'm talking about, how it appears to need to be quoted in one field, but not another. |
The value is read as an array because of the brackets. You cannot have a string that has the format without quoting. I think you'd get a similar error on |
We noticed here that when using dns.local_ipv6 ATS will complain while parsing, Im assuming due to all the extra colons in the ipv6 address so that is resolved by just wrapping in quotes. However it does not complain when having both an ipv4 and a 6 in outgoing_ip_to_bind. So wondering if there is a way to make ATS act consistently. Right now we just quote wrap all of them which seems to work
The text was updated successfully, but these errors were encountered: