Unable to build the ext anymore

[raja-jamwal]

The readme instructions seem outdated,

npm run build is throwing following error:

[webpack-cli] Error: Must set a `TARGET`
    at default (file:///Users/dev/code/apollo-client-devtools/webpack.config.mjs:26:11)
    at loadConfigByPath (/Users/dev/code/apollo-client-devtools/node_modules/webpack-cli/lib/webpack-cli.js:1445:37)
    at async WebpackCLI.loadConfig (/Users/dev/code/apollo-client-devtools/node_modules/webpack-cli/lib/webpack-cli.js:1515:38)
    at async WebpackCLI.createCompiler (/Users/dev/code/apollo-client-devtools/node_modules/webpack-cli/lib/webpack-cli.js:1781:22)
    at async WebpackCLI.runWebpack (/Users/dev/code/apollo-client-devtools/node_modules/webpack-cli/lib/webpack-cli.js:1877:20)
    at async Command.<anonymous> (/Users/dev/code/apollo-client-devtools/node_modules/webpack-cli/lib/webpack-cli.js:944:21)
    at async Command.parseAsync (/Users/dev/code/apollo-client-devtools/node_modules/webpack-cli/node_modules/commander/lib/command.js:935:5)
    at async Command.<anonymous> (/Users/dev/code/apollo-client-devtools/node_modules/webpack-cli/lib/webpack-cli.js:1356:13)
    at async Command.parseAsync (/Users/dev/code/apollo-client-devtools/node_modules/webpack-cli/node_modules/commander/lib/command.js:935:5)
    at async WebpackCLI.run (/Users/dev/code/apollo-client-devtools/node_modules/webpack-cli/lib/webpack-cli.js:1360:9)

I was able to build version 4.4.3

[phryneas]

Good point!

You'd now do npm run build -- --env TARGET=chrome or npm run build -- --env TARGET=firefox.

I'll update the README.

[phryneas]

See #1234

[jerelmiller]

This has been resolved with #1234, so I'll go ahead and close this 🙂