Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

app-registry plugin for Helm 3 #102

Open
pho-enix opened this issue Nov 15, 2019 · 12 comments
Open

app-registry plugin for Helm 3 #102

pho-enix opened this issue Nov 15, 2019 · 12 comments

Comments

@pho-enix
Copy link

These days Helm v3 was released. The plugin does not work there. After installing to the plugin directory, helm plugin list does not list it and the command can also not be called.

Furthermore with the OCI support of Helm v3 the helm registry subcommand will already be in use by Helm itself (see: https://v3.helm.sh/docs/topics/registries/). Thus a rename of the plugin might be required.

@pho-enix
Copy link
Author

I forked the plugin:
https://github.com/pho-enix/helm-quay

@ant31
Copy link
Contributor

ant31 commented Feb 27, 2020

would you be able to do a PR ?

@pho-enix
Copy link
Author

Is this project still active?

@ant31
Copy link
Contributor

ant31 commented Mar 6, 2020

Not very active but still used

@ogruene
Copy link

ogruene commented Mar 9, 2020

Hi @ant31, @pho-enix,
we are currently also evaluating possibilities on how we can use/modify the existing helm Quay plugin with Helm v3. We might also create a PR in plugin repo if it's necessary. Is there a realistic chance that the PR will be approved and merged? We are aware that this a breaking change as the helm registry will then no longer be available for use with Helm v2 and must be replaced with helm quay. We would highly appreciate any feedback on this.
Thanks.

Oliver Grüneberg <[email protected]>, Daimler TSS GmbH
Legal Imprint

@ant31
Copy link
Contributor

ant31 commented Mar 9, 2020

Hi,

I have only few overview of HelmV3, also I know they integrate directly an OCI registry and eventually would become compatible nativily at some point (cc @jzelinskie)

I'll create a separate repo: appr-helmV3-plugin, so there is no issue with compatibility. I'll merge any PR submitted to it.

Thank you.

@ogruene
Copy link

ogruene commented Mar 9, 2020

Sounds good for us although the new Helm plugin should still work with Helm v2 with helm quay instead of helm registry, so the repo name might be misleading ;-)

Thank you.

@ant31
Copy link
Contributor

ant31 commented Mar 9, 2020

@pho-enix
Copy link
Author

@ant31 You can simply fork (which is a fork of your repo):
https://github.com/pho-enix/helm-quay

The change to helm quay is included plus some fixes and improvements for plugin installation.

What do you think?

@ogruene any additional functionality that you need?

@ogruene
Copy link

ogruene commented Mar 11, 2020

Hi @pho-enix, @ant31,
I don't think that we need additional functionality. I'm preparing right now a PR for the new v3 repository. It is also OK for us if @ant31 takes your repository as base for the new repo. If we need changes we can still do a PR. Our problem is that we need a quick solution ;-)
So I will go further on preparing the PR ...

@pho-enix: As far as I see your repo is not a fork but furthermore a copy/clone, is it?

@pho-enix
Copy link
Author

@pho-enix: As far as I see your repo is not a fork but furthermore a copy/clone, is it?

Yeah. Sorry for that. So you'd have to manually apply my changes again. But it's acually not a lot of diff.

@ogruene
Copy link

ogruene commented Mar 16, 2020

Hi @ant31,
the PR was opened last week. I would highly appreciate if you can review and merge the PR ;-)

Thank you very much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants