Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible Regex mismatch #91

Open
lakowske opened this issue Oct 10, 2017 · 1 comment
Open

Possible Regex mismatch #91

lakowske opened this issue Oct 10, 2017 · 1 comment

Comments

@lakowske
Copy link

I'm curious if this regex is to restrictive:

PACKAGE_REGEXP = r"^(.*?\/)([a-z0-9_-]+\/[a-z0-9_-]+)([:@][a-z0-9._+-]+|@sha256:[a-z0-9]+)?$"

in utils.py

I was able to push a chart up to a quay-enterprise server with the name:

my-server.com/my-org/[email protected]

But then couldn't pull it down with appr because the above regex does not allow upper case. Should the server have not let the chart into the registry or should the client's regex be less restrictive and allow upper case characters?

@ant31
Copy link
Contributor

ant31 commented Oct 21, 2017

Thanks to report, it should allow uppercase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants