Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pyramid-Admin is overriding the default translation domain #11

Open
mlhamel opened this issue Sep 5, 2014 · 0 comments
Open

Pyramid-Admin is overriding the default translation domain #11

mlhamel opened this issue Sep 5, 2014 · 0 comments

Comments

@mlhamel
Copy link

mlhamel commented Sep 5, 2014

In the following:

https://github.com/appetito/pyramid_admin/blob/master/src/pyramid_admin/__init__.py

You are replacing the gettext and ngettext template's callable by your own version. But those callable are then also overriding the default ones. Which mean that automatically all the translations of your project will try to find strings in the pyramid_admin domain.

That's wrong cause it means that the translation will work on the admin side using your domain, but an hypothetical project will loose the possibility to be translated itself with his domain...

Basically, it seems there's a conflicting domain and you should probably not forcing it to be pyramid_admin as it is currently done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant