Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate Newspaper's Article-states #84

Open
jecarr opened this issue Nov 2, 2023 · 0 comments
Open

Investigate Newspaper's Article-states #84

jecarr opened this issue Nov 2, 2023 · 0 comments
Labels
good first issue Good for newcomers testing Software testing, test cases, and compatibility

Comments

@jecarr
Copy link
Member

jecarr commented Nov 2, 2023

Newspaper has 3 internal states when it is processing a URL

  • Not-started (default)
  • Success
  • Failure

In this line, we stop-&-error a report-URL from processing if Newspaper's ArticleDownloadState is not a success.

In a previous version, bulk URLs each threw an exception ArticleException('You must download() an article first!') (because we tried to do a.parse() where the article-state was the default of not-started). We fixed this in 75f71c2.

It would be good to:

  • Test Thread with this change reverted
  • Submit bulk URLs (submit CSV)
  • See if we can replicate the exception
  • Determine why the previous a.download() call before the if-statement on ArticleDownloadState would leave the article-object with its default state

The URLs that caused these errors are producing 404s; we cannot tell if they were 404s at the time of this error or at the time of me writing this Issue. A test could include URLs which knowingly will lead to 404s.

@KadeMorton KadeMorton added good first issue Good for newcomers testing Software testing, test cases, and compatibility labels Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers testing Software testing, test cases, and compatibility
Projects
None yet
Development

No branches or pull requests

2 participants