Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fail Google Chrome validation #287

Open
ThomasSousa96 opened this issue May 22, 2018 · 3 comments
Open

Fail Google Chrome validation #287

ThomasSousa96 opened this issue May 22, 2018 · 3 comments
Labels

Comments

@ThomasSousa96
Copy link

  • The function is.Chrome() returns true on the Microsoft Edge of the Android
  • The function is.Chrome() returns false on the Google Chrome of the IPhone
@ironmaniiith
Copy link
Collaborator

@ThomasSousa96 , thanks for reporting.
Could you please specify the versions as well?

@FA65
Copy link

FA65 commented Oct 3, 2019

For information on the problem
is.chrome() returns false for Google Chrome on Apple mobile devices because the regexp used in the function, it is testing navigator.vendor and it returns 'Apple Computer, Inc.' instead of the expected 'google inc'

line 628

    // is current browser chrome?
    // parameter is optional
    is.chrome = function(range) {
        var match = /google inc/.test(vendor) ? userAgent.match(/(?:chrome|crios)\/(\d+)/) : null;
        return match !== null && is.not.opera() && compareVersion(match[1], range);
    };

@jdesherlia
Copy link

Is this library still being actively maintained? I just started using it and would really benefit from this issue being fixed, but looking at the issues, it seems like there is very little activity from the developers in the past couple of years.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants