Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix type wrapper maybe uninitialized #32

Merged
merged 1 commit into from
Oct 13, 2024
Merged

Fix type wrapper maybe uninitialized #32

merged 1 commit into from
Oct 13, 2024

Conversation

jxy-s
Copy link
Collaborator

@jxy-s jxy-s commented Oct 13, 2024

Converts type wrapper of a reference to use a pointer. This resolves GCC maybe uninitialized problems. It also optimizes since (I believe) the construction on assignment was strictly unnecessary given the known reference type, a simple pointer assignment should suffice.

Copy link

codecov bot commented Oct 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.84%. Comparing base (b478350) to head (79314b5).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   89.79%   89.84%   +0.05%     
==========================================
  Files          17       17              
  Lines        1989     1989              
  Branches      263      263              
==========================================
+ Hits         1786     1787       +1     
  Misses         13       13              
+ Partials      190      189       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jxy-s jxy-s merged commit 6d0fb9f into main Oct 13, 2024
11 checks passed
@jxy-s jxy-s deleted the type-wrapper-fix branch October 13, 2024 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant