Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MD] Striker: flickering lines on the field #626

Closed
BiZkViT96 opened this issue Jun 25, 2022 · 4 comments · Fixed by #1739
Closed

[MD] Striker: flickering lines on the field #626

BiZkViT96 opened this issue Jun 25, 2022 · 4 comments · Fixed by #1739
Labels
core-md Mega Drive / Genesis, Mega CD, 32X

Comments

@BiZkViT96
Copy link

As it turned out, sound is not the only problem in this game.

There is flickering lines on the field. Look at the left side, where one shade of green changes into another.

Striker-2-61f439fe98

Real hardware https://youtu.be/D-HfGgy5D9o

Kega doesn't have this bug.
BlastEm have this bug.

Striker (Europe)
SHA1 9917c35a263cc9bd922d55bf59d01bc2733b4e24

Tested on ares nightly 2022-06-22
@LukeUsher LukeUsher added the core-md Mega Drive / Genesis, Mega CD, 32X label Jul 21, 2022
@rcaridade145
Copy link

Have you tested on Genesis Plus GX?
Looking at the code it mentions Striker as one of the games where CRAM can change on hblank

https://github.com/ekeeke/Genesis-Plus-GX/blob/e5f77f14b90fdf1353ee5c65bec6d1676c0551a9/core/vdp_ctrl.c#L1352

https://github.com/ekeeke/Genesis-Plus-GX/blob/e5f77f14b90fdf1353ee5c65bec6d1676c0551a9/core/vdp_ctrl.c#L2211

@BiZkViT96
Copy link
Author

No, I haven't tested it. A good finding.

LukeUsher added a commit that referenced this issue Oct 5, 2024
@LukeUsher
Squashed 'thirdparty/slang-shaders/' changes from 693c632bdd..ec1b855638
5982fa8 
ec1b855638 Add RF-nes presets to crt-royale-fast folder (#640)
a8e35920c5 Update crt-geom.slang (#639)
901441a496 Update crt-royale-fast and several presets (#638)
33876b3578 ensure testPattern() always has a return condition
5ab3c76109 update patchy-ntsc shaders and presets (#637)
edd2dd3f77 fix some errors identified by librashader scan (#636)
630fe655fe fix mudlord-pal-vhs
49c77cab02 remove another conflicting pass from preset
e1f7c6cc0e remove broken/unused pass from preset
0e29397870 add small, colored border shader (#635)
4ef678cab0 fix bad path
bd0ea94fc8 fix/update glow-trails shaders and presets (#634)
0dd9204791 Update crt-royale-fast and its presets (#633)
24f9468e2e Add crt-royale-pvm-shmup preset (#632)
0a305b879e Update crt-royale-fast and add new presets (#631)
1b2ad364b7 Add edgeNpixels shader (#630)
b9e012f25c Patchy NTSC - Bunch of last minute improvements (#629)
4cf85d3147 New NTSC shader by PlainOldPants (#627)
ef68606c0e Add edge1pixel shader (#628)
0cededfa7f ntsc-simple update to glsl version (#626)
811bb31cdb port tiny_ntsc (#625)
ef702029d8 Fix color clipping in crt-hyllian (#624)
b6b55c3995 Update crt-hyllian (#623)
26e9882eb2 Update crt-hyllian (#622)
b3d795acb9 Add crt-royale-ntsc-composite-fast preset (#620)
111fcedc3b Add crt-royale-fast shaders (#619)
b327343b77 Fix a 7-year old bug in crt-royale-bloom-approx.h (#618)
679a3321c1 Update crt-geom-mini.slang (#617)
f65a4bce69 Sync to koko-aio 1.9.30 (#616)
7d6751a07c update crt-guest to latest (#614)
05a41341be Fix input TF bug & large refactoring; Add box filter AA (#613)
5e702cfdc6 Added flat trinitron TV filters (#611)
1c6f2cd834 Add zfast_crt_geo shader (#612)
46b96cbd39 update crt-geom-mini to glsl version (#610)
959de2bb2e Reverted texture optimizations as they are breaking rendering. (#609)
23f90e3b27 crt-geom-mini update from glsl, crt-pocket fix clamp error (#607)
3796d44482 Update geom.slang (#606)
89dfd9bbd0 Add Geom shader (#605)

git-subtree-dir: thirdparty/slang-shaders
git-subtree-split: ec1b8556388317258376467c1561ecb91a06a466
@TascoDLX TascoDLX mentioned this issue Jan 1, 2025
Merged
@remutro
Copy link
Contributor

remutro commented Jan 1, 2025

Unfortunately it doesn't look like this issue has been resolved as a result of this PR: #1739

I'm re-opening the issue so that we don't lose track of this.

@remutro remutro reopened this Jan 1, 2025
@BiZkViT96
Copy link
Author

It has been confirmed that flickering does exist on real PAL hardware.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
core-md Mega Drive / Genesis, Mega CD, 32X
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

md: vdp improvements, dots and stuff TascoDLX/ares
4 participants
@LukeUsher @rcaridade145 @remutro @BiZkViT96