Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change chrono dependency #153

Closed
wants to merge 1 commit into from
Closed

Conversation

jack2game
Copy link

This PR fixes #137

@argenos
Copy link
Owner

argenos commented Jun 6, 2024

The review itself is not so simple, I'm afraid, since I would have to review your chrono fork. This means for now I can't merge this to solve #137

@jack2game
Copy link
Author

Go ahead.

@olivr70
Copy link

olivr70 commented Jul 23, 2024

Wouldn't be simpler and safer to use the official chrono version (wanasit/chrono ) which is published on npm. It is probably the most used and tested.
By the way it has implemented a much greater number of languages,

@evfro
Copy link

evfro commented Jan 16, 2025

I double the question from @olivr70. It seems that currently there's no progress on the issue due to the differences in chrono source versions.

Alternatively, @jack2game, you already did a great job fixing the issue, do you think it will be too time consuming to port your fixes to liamcain/chrono source for an easier merge process?
It would be great and solve problems for many users, I suppose. Personally, I find the plugin nearly unusable due to the current issue with wrong dates picking.

@jack2game
Copy link
Author

jack2game commented Jan 17, 2025

Thank you @evfro and @olivr70

For the time being, feel free to test out this version that I compiled last year. Apologies I should have put it up way earlier.

nldates-obsidian.zip

@argenos
Copy link
Owner

argenos commented Jan 18, 2025

@jack2game feel free to fork and submit your own plugin for others to use. I think you greatly underestimate how much time and effort this takes. This was a project I did in my free time. Nowadays, I have other priorities and I do not have the time to support the number and variety of requests from the large number of Obsidian users. Good luck!

@argenos argenos closed this Jan 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect parsing of bare day of week, e.g. "friday"
4 participants