From 0e8f1dcbab4effb333eac2982403c1532ac92a2c Mon Sep 17 00:00:00 2001 From: Shigure Kurosaki Date: Sun, 29 Dec 2024 03:13:48 +0800 Subject: [PATCH 1/3] chore: Add options to the checklist --- .github/PULL_REQUEST_TEMPLATE.md | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 382ed7f..85977f3 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -53,6 +53,7 @@ Please check the following before submitting the PR: - [ ] Link the relevant issue to this PR (if applicable) - [ ] Add labels to this PR - [ ] I have read and followed the guidelines in `CONTRIBUTING.md` +- [ ] I have already updated the related templates accordingly (if applicable) ### Additional Notes From aadebbcce55bcf8e456ab34498d9df3482c461a8 Mon Sep 17 00:00:00 2001 From: Shigure Kurosaki Date: Sun, 29 Dec 2024 03:49:04 +0800 Subject: [PATCH 2/3] chore: Removed unnecessary options --- .github/PULL_REQUEST_TEMPLATE.md | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 85977f3..d935667 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -4,18 +4,18 @@ Choose the right checklist for the change(s) that you're making: ### Description -Please include a summary of the changes and the related issue (if applicable). +Please include a summary of the changes and the related issue (if applicable). Explain the reason for the changes and any context that might be helpful for the reviewer. -- **What is the purpose of this PR?** -- **What problem does it solve?** +- **What is the purpose of this PR?** +- **What problem does it solve?** - **Are there any breaking changes or backwards compatibility issues?** ### Related Issue If this PR addresses an existing issue, please provide a reference to it (e.g., "Fixes #123" or "Closes #456"). -Example: +Example: - Closes #123 - Fixes #456 @@ -34,7 +34,7 @@ Please delete options that are not relevant: ### How Has This Been Tested? -Please describe the tests that you ran to verify your changes. +Please describe the tests that you ran to verify your changes. Include any details about the environment or specific configurations used during testing. - [ ] I have run unit tests @@ -46,14 +46,12 @@ Include any details about the environment or specific configurations used during Please check the following before submitting the PR: - [ ] My code follows the coding style guidelines of this project +- [ ] I have already updated the related templates accordingly (if applicable) - [ ] I have written or updated relevant documentation (if applicable) - [ ] I have added or updated tests to cover my changes (if applicable) - [ ] All new and existing tests pass - [ ] I have reviewed my code for any potential issues -- [ ] Link the relevant issue to this PR (if applicable) -- [ ] Add labels to this PR - [ ] I have read and followed the guidelines in `CONTRIBUTING.md` -- [ ] I have already updated the related templates accordingly (if applicable) ### Additional Notes From de9c22b38aee7025e7a134c15e132c9544a1e00b Mon Sep 17 00:00:00 2001 From: Shigure Kurosaki Date: Sun, 29 Dec 2024 03:55:48 +0800 Subject: [PATCH 3/3] chore: Removed unnecessary options --- .github/PULL_REQUEST_TEMPLATE.md | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index d935667..b456f3f 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -45,13 +45,11 @@ Include any details about the environment or specific configurations used during Please check the following before submitting the PR: -- [ ] My code follows the coding style guidelines of this project +- [ ] I have read and followed the guidelines in `CONTRIBUTING.md` - [ ] I have already updated the related templates accordingly (if applicable) - [ ] I have written or updated relevant documentation (if applicable) - [ ] I have added or updated tests to cover my changes (if applicable) -- [ ] All new and existing tests pass - [ ] I have reviewed my code for any potential issues -- [ ] I have read and followed the guidelines in `CONTRIBUTING.md` ### Additional Notes