Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BasicBuildMain always takes the same options, inline optins and promote real parameter for readability #110

Open
Neppord opened this issue Jun 13, 2024 · 1 comment

Comments

@Neppord
Copy link

Neppord commented Jun 13, 2024

This seams to be a premature abstraction, the true options that are different between runs are the args and cliRoot.

I suggest starting by inlining options:

  • analyzeCustom
  • foreignSemantics

these two options don't depend on args and cliRoot, and therefore would be the smallest change.

Then extract all functions that needs the true parameters in scope, promoting them to parameters for the subtask, then using them inside basicBuildMain passing args and cliRoot as arguments, or in args only the part of arg that is needed.

@natefaubion
Copy link
Collaborator

It just forwards on all the options.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants