You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This seams to be a premature abstraction, the true options that are different between runs are the args and cliRoot.
I suggest starting by inlining options:
analyzeCustom
foreignSemantics
these two options don't depend on args and cliRoot, and therefore would be the smallest change.
Then extract all functions that needs the true parameters in scope, promoting them to parameters for the subtask, then using them inside basicBuildMain passing args and cliRoot as arguments, or in args only the part of arg that is needed.
The text was updated successfully, but these errors were encountered:
purescript-backend-optimizer/backend-es/src/PureScript/Backend/Optimizer/Codegen/EcmaScript/Builder.purs
Line 85 in bdef8b5
This seams to be a premature abstraction, the true options that are different between runs are the
args
andcliRoot
.I suggest starting by inlining options:
these two options don't depend on
args
andcliRoot
, and therefore would be the smallest change.Then extract all functions that needs the true parameters in scope, promoting them to parameters for the subtask, then using them inside
basicBuildMain
passingargs
andcliRoot
as arguments, or inargs
only the part of arg that is needed.The text was updated successfully, but these errors were encountered: