Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Task]: Improve code for meson-gxm-c400-plus.dtb #7678

Open
jomadeto opened this issue Jan 8, 2025 · 1 comment
Open

[Task]: Improve code for meson-gxm-c400-plus.dtb #7678

jomadeto opened this issue Jan 8, 2025 · 1 comment
Labels
Task/To-Do Project management: To-Do or task(s) someone is working on

Comments

@jomadeto
Copy link
Contributor

jomadeto commented Jan 8, 2025

Task description

With default meson-gxm-q201.dts in linux kernel code ethernet and wifi works, only need to add bluetooth driver. But in armbian the patch "meson-gxl-gxm-arm64-dts-meson-set-p212-p23x-q20x-SDIO-to-100MH.patch" broke wifi, more exactly the problem is increase to 100MH in the file "/arch/arm64/boot/dts/amlogic/meson-gx-p23x-q20x.dtsi", the line "max-frequency = <100000000>;". If revert this line to "max-frequency = <50000000>;" wifi works perfect.

In my actual code take the meson-gxm-q201.dts base, add bluetooth driver and duplicate all the code of "/* Wireless SDIO Module */" reverting only "max-frequency = <50000000>;", but all the rest of the code is duplicated.

I'm trying to change the code for not duplicate the code:

  • Try to add a new patch for partialy revert previous patch. But this patch affect all the dtbs that uses meson-gx-p23x-q20x.dtsi so this is not the solution.
  • Actually are testing removing the line "#include "meson-gx-p23x-q20x.dtsi"" in meson-gxm-c400-plus.dts and manually adding and adapting all the code in patched meson-gx-p23x-q20x.dtsi (present in folder /build/cache/sources/linux-kernel-worktree/meson64__arm64/arch/arm64/boot/dts/amlogic), in theory must work, but in the future need to manually add all new patches added to meson-gx-p23x-q20x.dtsi.

I think that the better option is keep #include "meson-gx-p23x-q20x.dtsi" in meson-gxm-c400-plus.dts, remove duplicated "/* Wireless SDIO Module */" and make a patch that revert max-frequency = <100000000>; to max-frequency = <50000000>; only when build aml-c400-plus, but don't know how to do this, don't know if somebody can help me will be apreciated.

Sorry for my bad english.

@jomadeto jomadeto added the Task/To-Do Project management: To-Do or task(s) someone is working on label Jan 8, 2025
Copy link
Contributor

github-actions bot commented Jan 8, 2025

Jira ticket: AR-2582

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Task/To-Do Project management: To-Do or task(s) someone is working on
Development

No branches or pull requests

1 participant