Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Engineering Console only sent to some clients #190

Open
StarryWisdom opened this issue Dec 7, 2019 · 2 comments
Open

Engineering Console only sent to some clients #190

StarryWisdom opened this issue Dec 7, 2019 · 2 comments

Comments

@StarryWisdom
Copy link
Collaborator

the object Engineering Console is only sent clients with an engineering console selected *
I think this is worth noting (and maybe with a quick explination as to why)

I would suggest something like the following after "Engineering Console" before "Bit fields (4 bytes)"
The stock artemis server doesn't send Engineering Console packets to any client without engineering station selected, the stock artemis client misunderstands this resulting in repeated corrections when power levels are not 100%. Stock artemis clients do understand Engineering Console packets even if they do not have the engineering station selected.


there is a similar (but not identical) issue with weapons consoles


  • in typing this I have just become aware I couldnt swear if every ships engineering console is sent to all engineering consoles or if its just that ships one
    ** there needs to be a test as to how multiship games work with engineering data being sent as I think there may be bugs there as well
    *** I think it may actually be whatever that client last saw rather than 100%, I will test later
    **** I havent actually looked at the html for this page, otherwise I would at least post this as a diff, I will at some point if no one else does this in the mean time
    *****I dont know if the footnotes help or hinder clarity, I need to get round to setting up dev tools on this box to be able to do diffs, which I think will help
@rjwut
Copy link
Member

rjwut commented Apr 30, 2020

Confirmed that the engineering console (containing system energy, heat, and coolant values) is only sent to engineering clients. However, the weapons console (containing tube status) does seem to go out to all clients.

@NoseyNick
Copy link
Collaborator

Oh you're right, I saw 135k packets and thought I couldn't possibly have played Eng that many times...
... but that's 50 games WITH, 1405 games WITHOUT 😮
... and double-checking, I have clientConsoles([...] Eng=>1 [...]) on all those as well, EXCEPT some that I have labelled as "Starry" which is probably @StarryWisdom 's "special server" that adds the EngConsoles back in as a workaround.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants