From 5a59a7d8b5461901124d45f6829669da87423755 Mon Sep 17 00:00:00 2001 From: Robin Tang Date: Mon, 21 Oct 2024 15:15:26 -0700 Subject: [PATCH] Clean up. --- lib/debezium/converters/time_test.go | 10 +++++++++- lib/debezium/schema_test.go | 17 ++++++++++++----- 2 files changed, 21 insertions(+), 6 deletions(-) diff --git a/lib/debezium/converters/time_test.go b/lib/debezium/converters/time_test.go index 947844d57..67e68baa6 100644 --- a/lib/debezium/converters/time_test.go +++ b/lib/debezium/converters/time_test.go @@ -114,13 +114,21 @@ func TestZonedTimestamp_Convert(t *testing.T) { } func TestTime_Convert(t *testing.T) { + { + val, err := Time{}.Convert(int64(54720321)) + assert.NoError(t, err) + + extTime, isOk := val.(*ext.ExtendedTime) + assert.True(t, isOk) + assert.Equal(t, "15:12:00.321", extTime.String("")) + } { val, err := Time{}.Convert(int64(54720000)) assert.NoError(t, err) extTime, isOk := val.(*ext.ExtendedTime) assert.True(t, isOk) - assert.Equal(t, "15:12:00+00", extTime.String("")) + assert.Equal(t, "15:12:00.000", extTime.String("")) } } diff --git a/lib/debezium/schema_test.go b/lib/debezium/schema_test.go index e990c53c0..1c725f011 100644 --- a/lib/debezium/schema_test.go +++ b/lib/debezium/schema_test.go @@ -254,13 +254,20 @@ func TestField_ToKindDetails(t *testing.T) { } } { - // Time - for _, dbzType := range []SupportedDebeziumType{Time, TimeKafkaConnect, TimeWithTimezone} { - kd, err := Field{DebeziumType: dbzType}.ToKindDetails() + { + // Time with timezone + kd, err := Field{DebeziumType: TimeWithTimezone}.ToKindDetails() assert.NoError(t, err) - assert.Equal(t, typing.NewExtendedTimeDetails(typing.ETime, ext.TimeKindType, ""), kd, dbzType) + assert.Equal(t, typing.NewExtendedTimeDetails(typing.ETime, ext.TimeKindType, ""), kd) + } + { + // Time + for _, dbzType := range []SupportedDebeziumType{Time, TimeKafkaConnect, TimeWithTimezone} { + kd, err := Field{DebeziumType: dbzType}.ToKindDetails() + assert.NoError(t, err) + assert.Equal(t, typing.NewExtendedTimeDetails(typing.ETime, ext.TimeKindType, "15:04:05.000"), kd, dbzType) + } } - { // Micro time kd, err := Field{DebeziumType: MicroTime}.ToKindDetails()